Re: [opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-26 Thread Stone Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/#review652 --- Ship it! hg rm llconfusingcode.cpp is better, but llmax() works h

[opensource-dev] Review Request: CHOP-629 symbol information for llcommon.dll is missing both in the debugger and in crash reports

2011-04-26 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/281/ --- Review request for Viewer. Summary --- Somewhere in the VS2010 transit

Re: [opensource-dev] Review Request: VWR-25609 crash on shutdown in LLGLNamePool::sInstances destructor

2011-04-26 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/279/ --- (Updated April 26, 2011, 5:40 p.m.) Review request for Viewer. Summary (u

Re: [opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

2011-04-26 Thread Stone Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/#review651 --- Ship it! - Stone On April 26, 2011, 5:36 p.m., Brad Kittenbrink

[opensource-dev] Review Request: VWR-25610 LLControlGroup::loadFromFile makes unnecessary copies of large LLSD objects

2011-04-26 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/280/ --- Review request for Viewer. Summary --- Unnecessary copying was slowing

[opensource-dev] Review Request: VWR-25609 crash on shutdown in LLGLNamePool::sInstances destructor

2011-04-26 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/279/ --- Review request for Viewer. Summary --- The error is due to the fact th

[opensource-dev] Review Request: VWR-25608 error on shutdown due to buffer overrun in LLVFS::audit

2011-04-26 Thread Brad Kittenbrink
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/278/ --- Review request for Viewer. Summary --- Fix for a minor buffer overrun

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-26 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/#review650 --- Ship it! - Vadim On April 25, 2011, 4:40 p.m., Boroondas Gupte

[opensource-dev] Daily Scrum Summary - Monday, April 25

2011-04-26 Thread Anya Kanevsky
Sprint 14, ends 04.25.11 Monday, April 25 General Notes -- - Sprint planning today - PE OOO today - short standup! - Seth on vacation this week Team Status -- Oz Linden -- *PAST* - Reviewed and mer