Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/ --- (Updated April 25, 2011, 4:40 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Vadim ProductEngine
> On April 25, 2011, 10:27 a.m., Vadim ProductEngine wrote: > > Looks good, thanks. > > > > One note that applies to my patch as well: rfind() seems to fit better than > > find() in this case. > > Boroondas Gupte wrote: > Using string::rfind instead of string::find would avoid problems if

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Boroondas Gupte
> On April 25, 2011, 10:27 a.m., Vadim ProductEngine wrote: > > Looks good, thanks. > > > > One note that applies to my patch as well: rfind() seems to fit better than > > find() in this case. Using string::rfind instead of string::find would avoid problems if someone checks out the source to

Re: [opensource-dev] IM/Group chat icons?

2011-04-25 Thread Anya Kanevsky
Definitely is a bug, and thank you for bringing it up. Social team is on it. 2011/4/25 Opensource Obscure > On Mon, Apr 25, 2011 at 00:19, Trilo Byte wrote: > > I can't tell if this is a bug or not (since a fair number of jira's > referenced in recent builds are issues we don't have permission

Re: [opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/#review647 --- Ship it! Looks good, thanks. One note that applies to my patch a

Re: [opensource-dev] PO Review

2011-04-25 Thread Opensource Obscure
On Mon, Apr 25, 2011 at 13:13, Oz Linden (Scott Lawrence) wrote: > On 2011-04-22 14:09, Oz Linden (Scott Lawrence) wrote: > > http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/227402/index.html After installing this I tried to upload a texture and the viewer c

[opensource-dev] Review Request: STORM-1182: XUI Preview Tool fails to load XMLs from indra/newview/skins (Ported Vadim's Linux fix to Mac)

2011-04-25 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/277/ --- Review request for Viewer. Summary --- Just looked at Vadim's fix for

Re: [opensource-dev] PO Review

2011-04-25 Thread Oz Linden (Scott Lawrence)
On 2011-04-22 14:09, Oz Linden (Scott Lawrence) wrote: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/227402/index.html STORM-320 Script Editor in Viewer 2.0+ "tabs" incorrectly Approved STORM-595

Re: [opensource-dev] IM/Group chat icons?

2011-04-25 Thread Opensource Obscure
On Mon, Apr 25, 2011 at 00:19, Trilo Byte wrote: > I can't tell if this is a bug or not (since a fair number of jira's > referenced in recent builds are issues we don't have permission to view), but > in build 227447 (Mac client), it appears there's been a change to the way > IM's and group cha