Re: [opensource-dev] PO Review Build

2011-04-13 Thread Trilo Byte
I was able to check a few of these, Mac client. > STORM-842 "Start at" list isn't populated with favorites if user name is > typed in fashion "firstname.lastname" OK > STORM-1139 "Apply Changes to Region" works for water but not for sky Untestable with this viewer (it doesn't have estate-level

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-13 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review595 --- indra/newview/llfloaterworldmap.cpp

Re: [opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/#review598 --- Ship it! No major objections. indra/newview/llfloaterworldmap.c

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ? > > Jonathan Yap wrote: > Yes

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
> On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote: > > doc/contributions.txt, line 416 > > > > > > fix this before committing Fixed > On April 13, 2011, 1:13 p.m., Vadim ProductEngine wrote: > > doc/contribu

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Vadim ProductEngine
> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ? > > Jonathan Yap wrote: > Yes

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review596 --- Ship it! doc/contributions.txt

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
> On April 13, 2011, 10:24 a.m., Vadim ProductEngine wrote: > > indra/newview/llbottomtray.cpp, lines 560-561 > > > > > > Any reason not to move this to LLNearbyChatBar::postBuild() ? Yes, there is a reason, though no

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 12:32 p.m.) Review request for Viewer. Changes -

[opensource-dev] Review Request: Storm-1128 Sort the results of using search in the World Map

2011-04-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/262/ --- Review request for Viewer. Summary --- The results of using the World

[opensource-dev] PO Review Build

2011-04-13 Thread Oz Linden (Scott Lawrence)
http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/oz_viewer-poreview/rev/226501/index.html STORM-413 The presentation of IM sessions in message well depends on method that was used for opening IM window STORM-721

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

2011-04-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/#review593 --- Ship it! Looks plausible. - Vadim On April 13, 2011, 8:11 a.m.

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review591 --- Thanks, Jonathan. No major issues this time. I've got a few comme

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
> On April 13, 2011, 7:19 a.m., Boroondas Gupte wrote: > > indra/newview/llviewerchat.h, lines 37-39 > > > > > > Why repeat the 'public:' ? Vadim's RB comments and other LL code implied this was the way to go. I've

Re: [opensource-dev] Review Request: (STORM-941) IM log naming should go by SL name, not DN.

2011-04-13 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/249/ --- (Updated April 13, 2011, 8:11 a.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Latest Snowstorm build details seem broken

2011-04-13 Thread Oz Linden (Scott Lawrence)
On 2011-04-13 6:43, Hitomi Tiponi wrote: I've been trying to click on my favourite'Details for these builds ' link from the Snowstorm wiki page for the last twelve hours (well not every min

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/#review589 --- Ship it! Looks good. Some minor stuff still: indra/newview/llv

Re: [opensource-dev] Review Request: STORM-1095 Chat preferences > font size should increase size of input text in the chat box

2011-04-13 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/244/ --- (Updated April 13, 2011, 6:40 a.m.) Review request for Viewer. Summary --

Re: [opensource-dev] Latest Snowstorm build details seem broken

2011-04-13 Thread Opensource Obscure
On Wed, Apr 13, 2011 at 12:43, Hitomi Tiponi wrote: > I've been trying to click on my favourite 'Details for these builds' link > from the Snowstorm wiki page for the last twelve hours (well not every > minute obviously, even I'm not that sad), but all I am getting now is ' > > Build Results Pendi

[opensource-dev] Latest Snowstorm build details seem broken

2011-04-13 Thread Hitomi Tiponi
I've been trying to click on my favourite'Details for these builds' link from the Snowstorm wiki page for the last twelve hours (well not every minute obviously, even I'm not that sad), but all I am getting now is ' Build Results Pending... Architectures being built: CYGWIN Linux Darwin' I presu