Re: [opensource-dev] Review Request: Suggested fix for OPEN-45

2011-03-17 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/215/#review485 --- Ship it! Even better than my solution - Oz On March 17, 2011,

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

2011-03-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review484 --- Ship it! No further objections. Great work! - Boroondas On Mar

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

2011-03-17 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/ --- (Updated March 17, 2011, 4:19 p.m.) Review request for Viewer. Changes --

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-17 Thread Lance Corrimal
> On March 17, 2011, 11:46 a.m., Jonathan Yap wrote: > > The code that creates a ring @ 100 meters has been removed and I changed > > the mystery constant 20.0 to CHAT_NORMAL_RADIUS. Struggling with the diff > > hence that part is not updated. I found both rings quite useful. oh and btw I thi

Re: [opensource-dev] Review Request: Suggested fix for OPEN-45

2011-03-17 Thread Alain Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/215/ --- (Updated March 17, 2011, 3:02 p.m.) Review request for Viewer, Oz Linden an

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-17 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/#review480 --- The code that creates a ring @ 100 meters has been removed and I c

[opensource-dev] VWR-25188

2011-03-17 Thread Erin Mallory
Created https://jira.secondlife.com/browse/VWR-25188 as per grumpity's request for those like myself who are unable to get the 2.6.1 viewer to initialize at all... ___ Policies and (un)subscribe information av

Re: [opensource-dev] merov's viewer-autobuild2010

2011-03-17 Thread Ima Mechanique
> > I pulled down Merov's viewer-autobuild2010 as was suggested in the meeting > yesterday > and manually inserted fmod files and then ran > > autobuild --debug configure -c OpenSourceRelWithDebInfo > > autobuild --debug build -c OpenSourceRelWithDebInfo > > logged in with LindenDeveloper.

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-03-17 Thread Cron Stardust
> On March 12, 2011, 7:16 a.m., Oz Linden wrote: > > indra/llcharacter/llbvhloader.cpp, line 1199 > > > > > > I think it would be clearer to either add a new constant > > POSITION_MOTION_THRESHOLD_SQUARED or to write

[opensource-dev] merov's viewer-autobuild2010

2011-03-17 Thread Twisted Laws
I pulled down Merov's viewer-autobuild2010 as was suggested in the meeting yesterday and manually inserted fmod files and then ran autobuild --debug configure -c OpenSourceRelWithDebInfo autobuild --debug build -c OpenSourceRelWithDebInfo logged in with LindenDeveloper.exe in the RelWithDe

Re: [opensource-dev] Review Request: Squared all dist_vec() based comparisons and other dist_vec() operations where sensible.

2011-03-17 Thread Oz Linden
> On March 12, 2011, 7:16 a.m., Oz Linden wrote: > > indra/llcharacter/llbvhloader.cpp, line 1199 > > > > > > I think it would be clearer to either add a new constant > > POSITION_MOTION_THRESHOLD_SQUARED or to write

Re: [opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened

2011-03-17 Thread Seth ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/175/#review477 --- Ship it! Docking the side panels on ctrl+shift+w seems to be the

Re: [opensource-dev] Review Request: STORM-1016 Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened

2011-03-17 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/175/ --- (Updated March 17, 2011, 9:24 a.m.) Review request for Viewer and Seth Prod

Re: [opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

2011-03-17 Thread Alain Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/213/#review476 --- I don't like leaking these details into the executable interface.

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-17 Thread Cron Stardust
> On March 17, 2011, 4:50 a.m., Vadim ProductEngine wrote: > > indra/newview/llnetmap.cpp, lines 473-474 > > > > > > Please move these numbers to settings. Those two should be CHAT_NORMAL_RADIUS and CHAT_SHOUT_RADIUS

Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode

2011-03-17 Thread Moriz Gupte
Wondering if the ability to create a user's own spotlights is desirable? That would add an extra control point to the UI which we do not want ... may be. I think we will find that some UI features in the basic mode will migrate to the advanced mode as they are found to be useful not only for newcom

Re: [opensource-dev] Review Request: fix for STORM-1049: [crashhunters] crash at LLViewerFetchedTexture::forceToSaveRawImage(int, bool)

2011-03-17 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/193/#review474 --- Bao, please upload a diff. - Vadim On None, Xiaohong Bao wrote:

Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode

2011-03-17 Thread Daniel
Does the "Advanced" menu in the "Advanced" mode get renamed to "Expert" or something to avoid confusion? ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to

Re: [opensource-dev] Review Request: STORM-1025 Chat preferences > font size should increase size of input text as well

2011-03-17 Thread Vadim Savchuk
On 03/13/2011 02:42 AM, Jonathan Yap wrote: This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/139/ Review request for Viewer. By Jonathan Yap. /Updated March 12, 2011, 4:42 p.m./ Changes Ignore this and the previous message--just changing the

Re: [opensource-dev] Review Request: Add optional range ring to the mini-map -- one centered on you with a radius of 20m to show local chat range

2011-03-17 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/197/#review473 --- Ship it! Looks good, apart from hard-coded radiuses and unclear p

Re: [opensource-dev] Review Request: (STORM-250) Unexpected "More" text appears in the About Landmark panel after minimizing the floater

2011-03-17 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/198/#review472 --- Ship it! Looks good. Please fix the two minor doc issues and subm

Re: [opensource-dev] Review Request: OPEN-45: Correctly include the pass-through options when displaying the configure and build commands

2011-03-17 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/213/#review471 --- Ship it! This change looks correct and well done. (Didn't test it

Re: [opensource-dev] Snowstorm 2.6.1 with Advanced and Basic mode

2011-03-17 Thread Yoz Grahame
On 16 March 2011 20:25, Yoz Grahame wrote: > > You can switch between Basic and Advanced mode on the login screen. > Switching currently requires a viewer restart; we're looking into ways to > make that easier, though that may not be achievable for the 2.6 release. > Sorry, I should make sure to