Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-08 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/#review436 --- Discarding my fix, as I didn't properly investigate the situation.

[opensource-dev] STORM-1038 & VWR-24337 (was: PO Test build (222938))

2011-03-08 Thread Boroondas Gupte
On 03/08/2011 06:14 AM, Philippe (Merov) Bossut wrote: > * STORM-1038 : Viewer crash in texture cache pruning on startup Might be a duplicate of VWR-24337 , the fix of which has a "Ship it!" for over one month n

Re: [opensource-dev] PO Test build (222938)

2011-03-08 Thread Erin Mallory
* STORM-1016 : Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened No longer crashes the viewer... DOES dock panels which is annoying * STORM-1038 : Viewer crash in texture cache pruning on startup not sure how to test for this? * STORM-1040 : Text that shows

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-03-08 Thread Ima Mechanique
> > > On 2011-03-03 1:45, Philippe (Merov) Bossut wrote: > > > > > > > > Dropping privately built 3rd party libs though was always a bit of a > > > > black art. Now that most 3rd party libs have a public repo available > > > > at lindenlab/3p- though, you have another possibility which > > > > i

Re: [opensource-dev] Is 'STANDALONE' confusing?

2011-03-08 Thread Ima Mechanique
> > On 2011-03-03 1:45, Philippe (Merov) Bossut wrote: > > > > > > Dropping privately built 3rd party libs though was always a bit of a > > > black art. Now that most 3rd party libs have a public repo available > > > at lindenlab/3p- though, you have another possibility which > > > is to build t

Re: [opensource-dev] Review Request: fix for STORM-1046:[crashhunters] crash in LWorld::removeRegion STORM-1014: Viewer crash in LLSurface::getWaterHeight STORM-1047:[crashhunters] crash at LLViewerOb

2011-03-08 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/189/#review435 --- Ship it! I reviewed the changeset and it seems correct. I'll tran

Re: [opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

2011-03-08 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/180/#review434 --- Ship it! Seems correct. - Merov On March 7, 2011, 9:33 p.m., X