[opensource-dev] Daily Scrum Summary - Monday, March 7

2011-03-07 Thread Anya Kanevsky
Sprint 12, ends 03.21.11 Monday, March 7 General Notes -- - MMOTD: Merov Team Status -- Merov Linden -- *PAST* - MM : mostly code review, no push - STORM-1023 : fmod : got the various strategies to wo

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-07 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/#review433 --- Ship it! Seems good. - Merov On March 7, 2011, 4:44 p.m., Boro

Re: [opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

2011-03-07 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/179/#review432 --- I like the intent. In the code though, I don't really understand w

Re: [opensource-dev] Review Request: STORM-1044 Improved message template checking.

2011-03-07 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/174/#review431 --- Ship it! This seems to be good. - Merov On March 3, 2011, 2:20

Re: [opensource-dev] Review Request: STORM-1001: Viewer needlessly hits the "ObjectMedia" cap with thousands of requests

2011-03-07 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/162/#review430 --- Ship it! Satisfied with Kelly's answer to my comment. I don't hav

Re: [opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

2011-03-07 Thread Xiaohong Bao
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/180/ --- (Updated March 7, 2011, 9:33 p.m.) Review request for Viewer and Merov Lind

[opensource-dev] Review Request: fix for STORM-1046:[crashhunters] crash in LWorld::removeRegion STORM-1014: Viewer crash in LLSurface::getWaterHeight STORM-1047:[crashhunters] crash at LLViewerObject

2011-03-07 Thread Xiaohong Bao
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/189/ --- Review request for Viewer and Merov Linden. Summary --- changeset: e4c

[opensource-dev] PO Test build (222938)

2011-03-07 Thread Philippe (Merov) Bossut
Hi there, Here's a new PO test build: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/222938/index.html Fixes it contains: * STORM-1016 : Crash: ctrl-shift-w hides undocked Side Bar panels if almost any floater is opened * STORM-1038 : Viewer c

[opensource-dev] Boost libraries and includes. For testing and comments (good and bad)

2011-03-07 Thread Nicky Perian
Boost libraries and includes for 1x and 2x code bases. Built with VS 2010. Have complied on imprudence 1.4 and viewer-autobuild2010. diff's from LL 3p are include/coroutine and 1x libraries. This boost isnot included in any autobuild repository's autobuild.xml. Just needed a place to allow f

Re: [opensource-dev] Review Request: make PREHASH variables char const* const (fixes VWR-24487: llurlentry_stub.cpp:196: error: deprecated conversion from string constant to 'char*')

2011-03-07 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/#review429 --- Ship it! Perfect. - Aleric On March 7, 2011, 3:51 p.m., Boroon

Re: [opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/#review428 --- indra/cmake/Copy3rdPartyLibs.cmake

[opensource-dev] Review Request: quote all COPY_IF_DIFFERENT argument variables (fixes OPEN-36: error "COPY_IF_DIFFERENT Macro invoked with incorrect arguments" due to insufficient quoting)

2011-03-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/182/ --- Review request for Viewer. Summary --- Searched all uses of the copy_i

Re: [opensource-dev] Review Request: make PREHASH variables char const* const (fixes VWR-24487: llurlentry_stub.cpp:196: error: deprecated conversion from string constant to 'char*')

2011-03-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/100/ --- (Updated March 7, 2011, 3:51 p.m.) Review request for Viewer and Seth Produ

Re: [opensource-dev] Review Request: Implementation of new testing hooks to enable the creation of a headless viewer for testing.

2011-03-07 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/181/#review426 --- Any chance this big change could be split into several smaller (ho

[opensource-dev] Review Request: Implementation of new testing hooks to enable the creation of a headless viewer for testing.

2011-03-07 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/181/ --- Review request for Viewer and Oz Linden. Summary --- Massive changes i

[opensource-dev] Review Request: STORM-1018 Improve error messaging for External Editor feature

2011-03-07 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/179/ --- Review request for Viewer and Seth ProductEngine. Summary --- Let the

[opensource-dev] Review Request: the fix for STORM-1026: Viewer crahes while trying to reset Graphics quality

2011-03-07 Thread Xiaohong Bao
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/180/ --- Review request for Viewer. Summary --- This is for STORM-1026: Viewer