Re: [opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/72/#review128 --- This is really not how you want to deal with this bug :/. It's a k

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Jonathan Yap
> On Jan. 6, 2011, 7 a.m., Aleric Inglewood wrote: > > What about /Me, /ME or /me followed by another punctuation? Ie, "/me?", > > "/me!", etc... > > Just asking because these comparisions with just "/me " and "/me'" seem > > very limited, > > almost weird. More logical would be to not check an

[opensource-dev] Review Request: STORM-830 Volume slider isn't properly remembered if set to zero

2011-01-06 Thread Jonathan Yap
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/72/ --- Review request for Viewer. Summary --- There is an edge case in setMast

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Twisted Laws
that would be bad to check for "/me", what about "/meow" ? From: aleric.inglew...@gmail.com To: opensource-dev@lists.secondlife.com; aleric.inglew...@gmail.com; jhwe...@gmail.com Date: Thu, 6 Jan 2011 22:03:14 + Subject: Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not pa

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Aleric Inglewood
> On Jan. 6, 2011, 7 a.m., Aleric Inglewood wrote: > > What about /Me, /ME or /me followed by another punctuation? Ie, "/me?", > > "/me!", etc... > > Just asking because these comparisions with just "/me " and "/me'" seem > > very limited, > > almost weird. More logical would be to not check an

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review124 --- Ship it! Should be ok, I see no diff on the review board at all :p

[opensource-dev] Snowstorm Sprint meeting cancellation info

2011-01-06 Thread Sarah (Esbee) Kuehnle
Hi everybody, Due to conflicting meetings, I've had to cancel the Snowstorm Sprint meeting we had planned for 12pm PT today. We will still be having a Sprint Review meeting, but it will be held at 1pm PT. -- Esbee ___ Policies and (un)subscribe informat

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Oz Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/ --- (Updated Jan. 6, 2011, 10:20 a.m.) Review request for Viewer. Summary (upd

Re: [opensource-dev] Review Request: VWR-24347 Reversion in Copy3rdPartyLibs.cmake -- cannot find msvc* files using VS 2005 Express

2011-01-06 Thread Jonathan Yap
> On Jan. 4, 2011, 4:14 p.m., Merov Linden wrote: > > Those lines have been missing since a long time: the first version in hg is > > already missing them: > > https://bitbucket.org/lindenlab/viewer-development/changeset/07304583316d They are not in that early version, but they are (plus code f

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Jonathan Yap
> On Jan. 6, 2011, 7 a.m., Aleric Inglewood wrote: > > What about /Me, /ME or /me followed by another punctuation? Ie, "/me?", > > "/me!", etc... > > Just asking because these comparisions with just "/me " and "/me'" seem > > very limited, > > almost weird. More logical would be to not check an

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/71/#review120 --- What about /Me, /ME or /me followed by another punctuation? Ie, "/m

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Aleric Inglewood
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review119 --- You missed indra/newview/llfloaterwebcontent.cpp Also, why not fix

Re: [opensource-dev] Very Strange occurrence...

2011-01-06 Thread Carlo Wood
On Wed, Jan 05, 2011 at 04:44:31PM -0500, Kent Quirk (Q Linden) wrote: > So the reason that semi-plausible strings are used for these things is that > they're the only strings available when we use the test floater feature from > the login screen. > > But we should probably try not to use real n

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Jonathan Yap
> On Jan. 5, 2011, 7:33 p.m., Wolfpup Lowenhar wrote: > > indra/newview/llviewermessage.cpp, line 2752 > > > > > > Looks good to me, but just wondering why your checking for "/me " and > > "/me'" . That is the check us

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Boroondas Gupte
> On Jan. 6, 2011, 4:01 a.m., Boroondas Gupte wrote: > > "View Diff" doesn't display anything and with "Download Diff", I get a > > patch file that doesn't change anything: It removes some lines and adds > > back the exact same lines, with the same line endings (just LF). The > > surrounding l

Re: [opensource-dev] Review Request: STORM-826 (partial): fix line endings in files that use a mix of CRLF and LF

2011-01-06 Thread Boroondas Gupte
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/70/#review115 --- "View Diff" doesn't display anything and with "Download Diff", I ge

Re: [opensource-dev] Review Request: STORM-829 Viewer 2 does not parse /me in object Instant Messages

2011-01-06 Thread Liny Odell
Ever done "/me's happy"? It comes out (in my case) "Liny Odell's happy". On Thu, Jan 6, 2011 at 7:33 PM, Wolfpup Lowenhar wrote: >This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/71/ > > Ship it! > > indra/newview/llviewermessage.cpp