[opensource-dev] Test binary for in review JIRAs

2010-12-27 Thread Philippe (Merov) Bossut
Hi, We're having a lot of JIRAs in the "In Review" swim lane for sprint 9 waiting for reviews from PO and/or devs. I created a Mac binary (others building right now) for those: http://automated-builds-secondlife-com.s3.amazonaws.com/hg/repo/merov_viewer-development-import/rev/217880/arch/Darwin/in

Re: [opensource-dev] Review Request: VWR-20879 FTBFS: find_vc_dir() fails with Visual Studio Express

2010-12-27 Thread Merov Linden
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/66/#review98 --- Ship it! Seems correct though I could test with Express. At least,

Re: [opensource-dev] Review Request: The world map can point to the wrong URL

2010-12-27 Thread Merov Linden
> On 2010-12-23 05:16:08, Vadim ProductEngine wrote: > > indra/newview/llstartup.cpp, lines 3098-3099 > > > > > > Frankly speaking, I'm not a fan of adding another setting to only use > > it as a global variable. > >

Re: [opensource-dev] VWR-24172 (tab key not working)

2010-12-27 Thread Philippe (Merov) Bossut
Hi, On Sat, Dec 18, 2010 at 8:02 AM, Boroondas Gupte wrote: > On 12/18/2010 04:55 PM, Trilo Byte wrote: > > [...] tab key stopped working to jump between fields (in the build > window, debugged settings window, etc). [...] anybody else experiencing > this? > Yes, me. > I can repro on Mac too a

[opensource-dev] Sky and water settings per parcel

2010-12-27 Thread Laurent Bechir
Hello, I've added a comment on this feature request about sky and water settings per parcel, if anyone is interested : https://jira.secondlife.com/browse/VWR-6463 ___ Policies and (un)subscribe information available here: http://wiki.secondlife.com/

[opensource-dev] no snowstorm meetings today

2010-12-27 Thread aklo
Oz, Merov, &c., then, please, turn off your computers and have a day off! Y'all deserve it! Thx for all you do, Happy Holidays!! - AK On 2010-12-27 13:36, Erin Mallory wrote: > Did i miss an announcement or have my times off? or did snowstorm meetings today just get quietly cancelled on accoun

Re: [opensource-dev] no snowstorm meetings today?

2010-12-27 Thread Erin Mallory
ah. forgot that. forgot that grumpity is on vacation too. >< see you tommorrow I guess :) Date: Mon, 27 Dec 2010 14:16:17 -0500 From: o...@lindenlab.com To: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] no snowstorm meetings today? On 2010-12-27 13:

Re: [opensource-dev] no snowstorm meetings today?

2010-12-27 Thread Philippe (Merov) Bossut
Hi Erin, Sorry for the absence of notice: today is actually an official day off at LL as part of Xmas. Cheers, - Merov On Mon, Dec 27, 2010 at 10:36 AM, Erin Mallory wrote: > Did i miss an announcement or have my times off? or did snowstorm meetings > today just get quietly cancelled on accou

Re: [opensource-dev] no snowstorm meetings today?

2010-12-27 Thread Oz Linden (Scott Lawrence)
On 2010-12-27 13:36, Erin Mallory wrote: Did i miss an announcement or have my times off? or did snowstorm meetings today just get quietly cancelled on account of weather? Today and the Monday after New Years next week are Linden Lab holidays. ___ Po

[opensource-dev] no snowstorm meetings today?

2010-12-27 Thread Erin Mallory
Did i miss an announcement or have my times off? or did snowstorm meetings today just get quietly cancelled on account of weather? ___ Policies and (un)subscribe information available here: http://wiki.secondlif

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-27 Thread Oz Linden
> On 2010-12-24 13:25:16, Aleric Inglewood wrote: > > I'm going to respectfully disagree with Aleric on one minor style point. When comparing equality between a literal or constant and a variable, putting the constant value has an advantage: it avoids the "=" vs "==" error: if (FOO_LIMIT ==

Re: [opensource-dev] STORM-34 Test Binaries

2010-12-27 Thread Carlo Wood
> I kinda have to agree with hitomi. I agree with Andrew; it's a privacy sensitive thing and users shouldn't accidently flip it without thinking because it's on the normal 'General' page. If they need or want it, then I'm sure they'll find it, like they find everything else. Also, it will take a w

Re: [opensource-dev] STORM-34 Test Binaries

2010-12-27 Thread Trilo Byte
I understand the rationale for putting it on the Privacy tab. But it still seems like something that should be grouped with the Start Location options on the general tab. Perhaps to make room, the 'Enable Viewer Hints' checkbox could be moved to the Notifications tab? On Dec 27, 2010, at 7:5

Re: [opensource-dev] STORM-34 Test Binaries

2010-12-27 Thread Erin Mallory
I kinda have to agree with hitomi. Date: Mon, 27 Dec 2010 15:23:43 + From: hitomi.tip...@yahoo.co.uk To: adyu...@productengine.com CC: opensource-dev@lists.secondlife.com Subject: Re: [opensource-dev] STORM-34 Test Binaries Fair point Andrew - but I was just thinking that from a resident'

Re: [opensource-dev] STORM-34 Test Binaries

2010-12-27 Thread Hitomi Tiponi
Fair point Andrew - but I was just thinking that from a resident's point-of-view it doesn't seem that obvious when you already have the other login options in 'General' >From: Andrew Dyukov >To: Hitomi Tiponi >Cc: opensource-dev@lists.secondlife.com >Sent:

Re: [opensource-dev] Review Request: KDU Improvements: add unit tests for llkdu

2010-12-27 Thread Vadim ProductEngine
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/63/#review94 --- Thanks, Merov. I have no more objections. indra/llimagej2coj/llima

Re: [opensource-dev] STORM-34 Test Binaries

2010-12-27 Thread Andrew Dyukov
This preference is in "Privacy", because enabling it allows other users who use your machine to see your favorites from login screen without using a password, so it lets you share your private information. 2010/12/25 Hitomi Tiponi : > That looks great Merov.  Would suggest that the option for disp

[opensource-dev] Review Request: VWR-20879 FTBFS: find_vc_dir() fails with Visual Studio Express

2010-12-27 Thread Robin Cornelius
--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/66/ --- Review request for Viewer. Summary --- Add VCExpress as a search option

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-27 Thread Vadim ProductEngine
> On 2010-12-24 13:25:16, Aleric Inglewood wrote: > > indra/newview/llpanelmaininventory.cpp, line 948 > > > > > > While you're removing that empty line anyway, I thought I'd help you to > > not learn the bad coding habb

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-27 Thread Vadim ProductEngine
> On 2010-12-24 15:30:55, Jonathan Yap wrote: > > indra/newview/llpanelmaininventory.cpp, line 948 > > > > > > I updated the code per Aleric's suggestion but the 2nd diff failed to > > upload. There must be some unusual

Re: [opensource-dev] Review Request: STORM-737 Add "+" menu to Inventory/Recent

2010-12-27 Thread Vadim ProductEngine
> On 2010-12-24 10:55:28, Vadim ProductEngine wrote: > > indra/newview/llpanelmaininventory.cpp, line 509 > > > > > > This line can now be removed at all. > > Jonathan Yap wrote: > Line 509 on the left is removed; it