On Thursday 03 September 2009, David Brownell wrote:
> Anyone feeling like addressing the rest of these?
>
> It's code cleanup, by and large... except that "test
> floats for equality" bug.
The answer was evidently "no". :(
I just merged the following patch.
==
From: David
Anyone feeling like addressing the rest of these?
It's code cleanup, by and large... except that "test
floats for equality" bug.
On Monday 24 August 2009, Steve Grubb wrote:
> Hello,
>
> This is my last set of findings from looking through the code in svn. This set
> mostly concentrates on vari
Steve,
Thanks for the code review. Re this one:
On Monday 24 August 2009, Steve Grubb wrote:
> In src/flash/davinci_nand.c at line 648 we find this code:
>
> chip = strtoul(argv[2], &ep, 0);
> if (*ep || chip == 0 || chip == ULONG_MAX) {
> LOG_ERROR("Invalid NAND
Hello,
This is my last set of findings from looking through the code in svn. This set
mostly concentrates on variable tests that are unnecessary or could be copy
and paste issues.
In src/helper/jim.c at line 6066 we find this code:
if (end) {
then at 6071, we find this:
} else if (!end && inde
On Sunday 23 August 2009, Steve Grubb wrote:
>
>
> In src/target/etb.c is this code:
>
> if (!(etm_ctx->capture_status && TRACE_TRIGGERED))
>
> Was that supposed to be '&' rather than '&&' ?
Yes
___
Openocd-development mailing list
Openo
Hello,
I was looking though the code in svn and found a couple items that might
warrant attention.
In src/jtag/arm-jtag-ew.c around line 428. There is a variable initialized
here:
uint8_t outp_en = 0;
and then at 428 is this:
outp_en &= ~srst_mask;
Which is the same as outp_en = 0 & ~srst_m
