Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-13 Thread Jerry Ling
M Subject: Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order Hi Jerry, could you test the patch to see if it solves your problems? -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale C

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-12 Thread Øyvind Harboe
Hi Jerry, could you test the patch to see if it solves your problems? -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer From 682beb8ca5506a8fdb3b89fc227942bdee51a6d1 Mon

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread Øyvind Harboe
Take #3. Fix some warnings. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer From 682beb8ca5506a8fdb3b89fc227942bdee51a6d1 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?=C3=98

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread Øyvind Harboe
On Mon, Jan 11, 2010 at 10:04 AM, David Brownell wrote: > On Monday 11 January 2010, Øyvind Harboe wrote: >> > Maybe if you passed wp_type not bp_type ... ? >> >> Thanks. Fixed. I meant well. :-) > > Looks right now.  ;) I'll await test results. I haven't tried it. -- Øyvind Harboe US toll fre

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread David Brownell
On Monday 11 January 2010, Øyvind Harboe wrote: > > Maybe if you passed wp_type not bp_type ... ? > > Thanks. Fixed. I meant well. :-) Looks right now. ;) ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread Øyvind Harboe
> If that enumeration is defined by GDB protocol, it should not be placed > in target.h - doing so is a layering violation which leads to errors > just like this one. It isn't. What happens in gdb_server.c is that there is a switch statement to convert from GDB enum to OpenOCD enum. This is a clea

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread Øyvind Harboe
On Mon, Jan 11, 2010 at 9:27 AM, David Brownell wrote: > On Monday 11 January 2010, Øyvind Harboe wrote: >> How's this patch? > > Maybe if you passed wp_type not bp_type ... ? Thanks. Fixed. I meant well. :-) -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http:/

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread Michael Schwingen
Jerry Ling wrote: > There is a bug when using gdb to set read/write watchpoint. > OOCD will actually set a "write" watchpoint if you set "read" watchpoint > through gdb, and vis versa. > > Since... > [target/breakpoints.h] > enum watchpoint_rw > { > WPT_READ = 0, WPT_WRITE = 1, WPT_ACCESS = 2

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread David Brownell
On Monday 11 January 2010, Øyvind Harboe wrote: > How's this patch? Maybe if you passed wp_type not bp_type ... ? ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread David Brownell
On Sunday 10 January 2010, Jerry Ling wrote: >  ... watchpoint_add(target, address, size, type-2, 0, 0xu) ... Yeah, why isn't it passing "wp_type", which was already set up with the right enum value? It does the right thing for setting breakpoints, just a couple lines before. Sigh. Doin

Re: [Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-11 Thread Øyvind Harboe
How's this patch? -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer From ac931e8a3bd7fa6bb4434d0cb58a0a55d2fd3507 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?=C3=98yvind=20

[Openocd-development] gdb: mismatch gdb watchpoint enumeration order

2010-01-10 Thread Jerry Ling
Hi, There is a bug when using gdb to set read/write watchpoint. OOCD will actually set a "write" watchpoint if you set "read" watchpoint through gdb, and vis versa. Since... [target/breakpoints.h] enum watchpoint_rw { WPT_READ = 0, WPT_WRITE = 1, WPT_ACCESS = 2 }; But... [server/gdb_server.