Re: [Openocd-development] bugfix for step mips_m4k

2011-03-29 Thread Øyvind Harboe
Merged. There will be some followup discussion on whether this would affect more targets. -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-29 Thread Øyvind Harboe
On Tue, Mar 29, 2011 at 12:20 PM, Spencer Oliver wrote: > On 28/03/2011 11:28, Andrew Lyon wrote: >> >> Hi, >> >> The patch below fixes step  on mips_m4k: >> > > Just a quick question. > The current code is used on all other arch's - is there a underlying issue > with those aswell ? There is some

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-29 Thread Spencer Oliver
On 28/03/2011 11:28, Andrew Lyon wrote: Hi, The patch below fixes step on mips_m4k: Just a quick question. The current code is used on all other arch's - is there a underlying issue with those aswell ? Cheers Spen ___ Openocd-development mailing

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-29 Thread Øyvind Harboe
> Yes that's correct, in future I will send patches as attachments to > avoid such problems. Why not: git format-patch HEAD^ git send-email -to=openocd-development@lists.berlios.de --smtp-server=foo 000* ? -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-343

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-29 Thread Andrew Lyon
On Tue, Mar 29, 2011 at 9:28 AM, Øyvind Harboe wrote: > Hi, > > I wasn't able to apply your patch. > > Is the attached patch correct? > > > > > -- > Øyvind Harboe > > Can Zylin Consulting help on your project? > > US toll free 1-866-980-3434 / International +47 51 87 40 27 > > http://www.zylin.com

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-29 Thread Øyvind Harboe
Hi, I wasn't able to apply your patch. Is the attached patch correct? -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer F

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-28 Thread Andrew Lyon
On Mon, Mar 28, 2011 at 11:31 AM, Øyvind Harboe wrote: > Any objections to committing? > > Could you also list the necessary patches here? > > > Thanks! > > > -- > Øyvind Harboe > > Can Zylin Consulting help on your project? > > US toll free 1-866-980-3434 / International +47 51 87 40 27 > > http:

Re: [Openocd-development] bugfix for step mips_m4k

2011-03-28 Thread Øyvind Harboe
Any objections to committing? Could you also list the necessary patches here? Thanks! -- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and fla

[Openocd-development] bugfix for step mips_m4k

2011-03-28 Thread Andrew Lyon
Hi, The patch below fixes step on mips_m4k: diff --git a/src/target/mips_m4k.c b/src/target/mips_m4k.c index 8afee9c..78786a5 100644 --- a/src/target/mips_m4k.c +++ b/src/target/mips_m4k.c @@ -422,6 +422,8 @@ static int mips_m4k_step(struct target *target, int current, /* current = 1: co