Re: [Openocd-development] General SWD Support in OpenOCD

2011-07-28 Thread Tomek CEDRO
Everything went to master of the repository - I have cleaned it up so i should be now easy to rebase with openocd/master when necessary. Thank you for all hints on using git this is very nice tool and I seem to get familiar with it already :-) Best regards! :-) Tomek -- CeDeROM, SQ7MHZ, http://w

Re: [Openocd-development] General SWD Support in OpenOCD

2011-07-28 Thread Tomek CEDRO
Good news - libswd-openocd driver bridge is now ready and functional [1] it reads out the IDCODE. I have already pushed the patches to the repository [2]. Right now have to multitask to another task but at weekend I will try to make arm_adi_v5 work with my swd target using crafted drivers and swd f

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-13 Thread Tomek CEDRO
On Mon, Jun 13, 2011 at 8:25 AM, Øyvind Harboe wrote: > it's great that your focusing on functionality. Cracking the > technical problems and making a patch series that's right > for OpenOCD are two hard problems. Perhaps better > attack one at the time? exactly. producing smaller patches only co

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-13 Thread Øyvind Harboe
Hi Tomek, it's great that your focusing on functionality. Cracking the technical problems and making a patch series that's right for OpenOCD are two hard problems. Perhaps better attack one at the time? One hard thing about SWD is to crack the technical problems, the other hard thing is to create

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-12 Thread Tomek CEDRO
Well, the changes are bigger than only moving files, because this impacts code in many different places (i.e. headers inclusion). This is why I did not split the patches into single step because this takes too much time that I want to spend on code development and in fact makes no sense - we simply

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-12 Thread Øyvind Harboe
Hi Tomek, for others to be able to review your work, it is essential that it is a sequence of small logical changes. This will also create a much greater degree of continuity in the official master branch, which is very important to the maintainers. We also want to reorder your commits, so that w

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-12 Thread Tomek CEDRO
Hello Peter! Thank you for all hints :-) Now I know it, but few months ago when I started using GIT I did not (yet) :-P The changes introduced by my work could be applied to current openocd/master repository as I wanted because changes are too big, so I gave up and simply squashed logical patches

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-12 Thread Peter Stuge
Tomek CEDRO wrote: > Im afraid there is not much sense in that interactive rebasing for > such big change - it took me so many hours to split patches and in > result now there are even more patches some new patches patched by old > patches ;] This is far from perfect. You know that interactive reb

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-12 Thread Tomek CEDRO
I have deleted ols meddy openocd-swd branch and pushed new branch with the same name openocd-swd, this one: -use fresh openocd master head -is already rebased openocd master with changes from my fork -has already squashed commits of my work (less commits than before, more changes at once, no need t

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-11 Thread Tomek CEDRO
Im afraid there is not much sense in that interactive rebasing for such big change - it took me so many hours to split patches and in result now there are even more patches some new patches patched by old patches ;] This is far from perfect. I think we should simply use the default rebase patches

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-11 Thread Tomek CEDRO
Sure thing I want to support in an useful way! This is also good skills training for me :-) Thank you all for useful hints - interactive rebasing seems to be what I need, as presented on http://book.git-scm.com/4_interactive_rebasing.html "You can also rebase interactively. This is often used to r

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-11 Thread Øyvind Harboe
Hi Tomek, thank you so much for being willing to do the work of rebasing, splitting into patches, etc. This saves maintainers a lot of work and opens up for everybody being able to pitch in and make suggestions for improvements to your work. I plan to look at the SWD stuff, but it will not be in t

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-10 Thread Peter Stuge
Tomek CEDRO wrote: > Now when I do "git format-patch openocd-master file" I get bunch of > patch files based on my local commits. This is nasty as brings > unnecessary commits. I would rather produce one patch that contains > only important changes.. or you prefer the way format-patch produces? A

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-10 Thread Rodrigo Rosa
On Fri, Jun 10, 2011 at 3:53 PM, Tomek CEDRO wrote: > Oyvid, > > I have also created branch openocd-master to have up-to-date openocd > repository at site to produce patches. > > Now when I do "git format-patch openocd-master file" I get bunch of > patch files based on my local commits. This is na

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-10 Thread Tomek CEDRO
Do you think its time to create and work on 0.5 branch? -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-10 Thread Tomek CEDRO
Oyvid, I have also created branch openocd-master to have up-to-date openocd repository at site to produce patches. Now when I do "git format-patch openocd-master file" I get bunch of patch files based on my local commits. This is nasty as brings unnecessary commits. I would rather produce one pat

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-10 Thread Tomek CEDRO
Done. I have created new branch in my repository, just in case, it is named openocd-swd, it is already rebased with actual openocd/master branch :-) It builds fine. The interface_signal and bitbang works fine, I will prepare patches in a moment. The rest of functionality is not yet verified! bewar

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-09 Thread Øyvind Harboe
On Fri, Jun 10, 2011 at 4:57 AM, Tomek CEDRO wrote: > On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe wrote: >> First thing I tried was to rebase your master branch on >> top of origin/master and that didn't work... >> >> Could you rebase it on top of master branch and force a push? > > I also have

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-09 Thread Tomek CEDRO
On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe wrote: > First thing I tried was to rebase your master branch on > top of origin/master and that didn't work... > > Could you rebase it on top of master branch and force a push? I also have problem with merge conflict in src/jtag/core.c :-( How can I

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-09 Thread simon qian
Great, I'll add SWD driver of versaloon when it's testable. 2011/6/8, Øyvind Harboe : > On Tue, Jun 7, 2011 at 7:05 PM, Tomek CEDRO wrote: >> On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe >> wrote: >>> First thing I tried was to rebase your master branch on >>> top of origin/master and that didn

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-07 Thread Øyvind Harboe
On Tue, Jun 7, 2011 at 7:05 PM, Tomek CEDRO wrote: > On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe wrote: >> First thing I tried was to rebase your master branch on >> top of origin/master and that didn't work... > > Uhm, this is based on a version from March or April... and there are > also some

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-07 Thread Tomek CEDRO
On Tue, Jun 7, 2011 at 5:02 PM, Øyvind Harboe wrote: > First thing I tried was to rebase your master branch on > top of origin/master and that didn't work... Uhm, this is based on a version from March or April... and there are also some unnecessary changes that should be filtered out I guess. >

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-07 Thread Tomek CEDRO
Sure thing Oyvind! I am working on the separate repository that is publicly available, so anyone can take a look at the code, also the migration using git should be possible easily. When I consider the work is definitely finished (soon I hope), I will work on providing small patches :-) You may st

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-07 Thread Øyvind Harboe
First thing I tried was to rebase your master branch on top of origin/master and that didn't work... Could you rebase it on top of master branch and force a push? Below "swd" refers to your git repository and "origin" to the OpenOCD repository. git fetch origin git checkout swd/master git rebase

Re: [Openocd-development] General SWD Support in OpenOCD

2011-06-07 Thread Øyvind Harboe
Hi Tomek, thanks for working on SWD for OpenOCD. This is obviously a big change and I hope that everybody on the list understands that even if this was ready as-is it we would have to allow plenty of time for everybody to review this code before it goes into the master branch. I hope that we can

[Openocd-development] General SWD Support in OpenOCD

2011-06-07 Thread Tomek CEDRO
Hello world :-) The work on SWD is almost ready. You can watch the code at [1]. This is the source tree I am currently working on with KT-LINK interface and STM32Primer{1,2}. After some fixes and verification its in a few days it should be merged with OpenOCD source tree. You can already test, fam