Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-24 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe http://www.zylin.com/zy1000.html ARM7 ARM9 XScale Cortex JTAG debugger and flash programmer ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openo

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-23 Thread Daniel Gimpelevich
On Sat, 23 Aug 2008 10:33:37 +0200, Øyvind Harboe wrote: > a flash starting at 0 is a common case. > > How about: > > (addr <= c->base + c->size - 1) Ah! How late it was… Index: src/flash/flash.c === --- src/flash/flash.c (revis

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-23 Thread Øyvind Harboe
> Currently, it would work for a flash at zero, and not at the end. The > proposed change would make it work at the end, and not at zero. A > hypothetical flash containing the zero address in its middle would not > work either way. I don't have immediate ideas of how to account for all > these poss

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-23 Thread Daniel Gimpelevich
On Sat, 23 Aug 2008 10:13:05 +0200, Øyvind Harboe wrote: > On Sat, Aug 23, 2008 at 10:04 AM, Daniel Gimpelevich > <[EMAIL PROTECTED]> > wrote: >> On Sat, 23 Aug 2008 09:57:42 +0200, Øyvind Harboe wrote: >> /* check whether address belongs to this flash bank */ -

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-23 Thread Øyvind Harboe
On Sat, Aug 23, 2008 at 10:04 AM, Daniel Gimpelevich <[EMAIL PROTECTED]> wrote: > On Sat, 23 Aug 2008 09:57:42 +0200, Øyvind Harboe wrote: > >>>/* check whether address belongs to this flash bank */ >>> - if ((addr >= c->base) && (addr < c->base + c->size) && >>> targe

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-23 Thread Daniel Gimpelevich
On Sat, 23 Aug 2008 09:57:42 +0200, Øyvind Harboe wrote: >>/* check whether address belongs to this flash bank */ >> - if ((addr >= c->base) && (addr < c->base + c->size) && >> target == c->target) + if ((addr >= c->base) && (addr - 1 >> < c->base + c->s

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-23 Thread Øyvind Harboe
>/* check whether address belongs to this flash bank */ > - if ((addr >= c->base) && (addr < c->base + c->size) && target > == c->target) > + if ((addr >= c->base) && (addr - 1 < c->base + c->size - 1) > && target == c->target) >

Re: [Openocd-development] Fix for target_read/write_buffer

2008-08-22 Thread Daniel Gimpelevich
On Fri, 22 Aug 2008 14:10:52 +0200, Dominic wrote: > Commited. The patch below fixes a bug in target/target.c that causes > errors on reads/writes that access the end of the address space > (0x). > > Regards, > > Dominic Yes, but this is not committed: Index: src/flash/flash.c

[Openocd-development] Fix for target_read/write_buffer

2008-08-22 Thread Dominic
Commited. The patch below fixes a bug in target/target.c that causes errors on reads/writes that access the end of the address space (0x). Regards, Dominic Index: src/target/target.c === --- src/target/target.c (revision 95