Re: [Openocd-development] [patch 2/4] ARM: move opcode macros to

2009-12-09 Thread David Brownell
On Tuesday 08 December 2009, David Brownell wrote: > > From Section B.7 "Determining the core and system state" of "ARM9E-S > > Core Technical Reference Manual" (DDI0240A.pdf): > > > > |   Note > > | > > |   Because all Thumb instructions are only 16 bits long, > > Maybe back then they were!  [

Re: [Openocd-development] [patch 2/4] ARM: move opcode macros to

2009-12-08 Thread David Brownell
On Monday 07 December 2009, Nicolas Pitre wrote: > On Mon, 7 Dec 2009, David Brownell wrote: > > > Move the ARM opcode macros from , and a few > > Thumb2 ones from , to more appropriate homes > > in a new file. > > What about changing the names of a couple of those macros as well? I think that'

Re: [Openocd-development] [patch 2/4] ARM: move opcode macros to

2009-12-07 Thread Nicolas Pitre
On Mon, 7 Dec 2009, David Brownell wrote: > Move the ARM opcode macros from , and a few > Thumb2 ones from , to more appropriate homes > in a new file. What about changing the names of a couple of those macros as well? Say ARMV4_5_STMIA(). This isn't an instruction for ARMv4 or ARMv5 only. I

[Openocd-development] [patch 2/4] ARM: move opcode macros to

2009-12-07 Thread David Brownell
Move the ARM opcode macros from , and a few Thumb2 ones from , to more appropriate homes in a new file. Removed duplicate opcodes from that v7m/Thumb2 set. Protected a few macro argument references by adding missing parentheses. Tightening up some of the line lengths turned up a curious artifac