Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Zach Welch
On Sun, 2009-06-28 at 12:50 +0200, Freddie Chopin wrote: > Dominic pisze: > > It isn't possible with the current ft2232.c code because it uses > > conditional compilation to compile either with libftdi or FTD2XX. While > > offering basically the same functionality there are not only syntactical

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Dominic
On Sunday 28 June 2009 12:54:26 Freddie Chopin wrote: > Everything would be easier if libftdi would be a dll <: Now I'd have to > change and recompile libftdi <: Heh, that's exactly where I was heading with my questions ;). Regards, Dominic ___ Openocd

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Freddie Chopin
Dominic pisze: > How is libftdi, and more specifically OpenOCD with libftdi support build > on Windows? > > OpenOCD ft2232.o references symbols from libftdi which references > symbols from libusb0. On Linux, libftdi and libusb are shared objects > that get dynamically linked. > > You say libft

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Freddie Chopin
Dominic pisze: > It isn't possible with the current ft2232.c code because it uses > conditional compilation to compile either with libftdi or FTD2XX. While > offering basically the same functionality there are not only syntactical > but also semantical differences. If ft2232.c was to support bot

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Dominic
On Sunday 28 June 2009 11:07:56 Freddie Chopin wrote: > Martin Panter pisze: > > So why loading libusb rather than libftdi? Is it because libftdi is > > only built (or linked to) as a static library on Windows but still > > needs the libusb DLL? > > libftdi is not a .dll, but it's code statically l

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Dominic
On Sunday 28 June 2009 11:06:27 Freddie Chopin wrote: > Zach Welch pisze: > > You cannot have both libftdi and FTD2XX support in > > the same FT2232 driver binary, so this patch not even allowing testing > > them both using the same openocd binary (presumably by adding/removing > > the OS drivers b

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Freddie Chopin
Freddie Chopin pisze: > libftdi is not a .dll, but it's code statically links to libusb0.dll, so > I guess I'd have to modify libusb sources... Don't know whether that > would work, but it should. I meant "libftdi sources" [; 4\/3!! ___ Openocd-develo

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Freddie Chopin
Martin Panter pisze: > So why loading libusb rather than libftdi? Is it because libftdi is > only built (or linked to) as a static library on Windows but still > needs the libusb DLL? libftdi is not a .dll, but it's code statically links to libusb0.dll, so I guess I'd have to modify libusb source

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-28 Thread Freddie Chopin
Zach Welch pisze: > You cannot have both libftdi and FTD2XX support in > the same FT2232 driver binary, so this patch not even allowing testing > them both using the same openocd binary (presumably by adding/removing > the OS drivers between tests). Why is that so impossible? init() will try to

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Zach Welch
On Sun, 2009-06-28 at 01:23 +, Martin Panter wrote: > On 27/06/2009, Freddie Chopin wrote: > > 1. (this one) enable dynamic loading of ftd2xx.dll in ft2232.c > > 2. enable dynamic loading of libusb0.dll in ft2232.c > > So why loading libusb rather than libftdi? Is it because libftdi is > on

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Martin Panter
On 27/06/2009, Freddie Chopin wrote: > 1. (this one) enable dynamic loading of ftd2xx.dll in ft2232.c > 2. enable dynamic loading of libusb0.dll in ft2232.c So why loading libusb rather than libftdi? Is it because libftdi is only built (or linked to) as a static library on Windows but still nee

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Zach Welch
On Sat, 2009-06-27 at 20:50 +0200, Freddie Chopin wrote: > Second version of previous patch improved with suggestions from Ronald. > > Pls try (; Works for me <: This patch now looks 1000 times better with the changes from Ronald. Thanks to both of you for producing and refining it. My only rema

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Freddie Chopin
Second version of previous patch improved with suggestions from Ronald. Pls try (; Works for me <: 4\/3!! Index: ft2232.c === --- ft2232.c(revision 2405) +++ ft2232.c(working copy) @@ -63,6 +63,51 @@ #include #endif +/*

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Freddie Chopin
I take that back, what you propose is possible and works - I've done that wrong a while ago. I'll create a new version of patch soon. 4\/3!! ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listi

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Ronald Vanschoren
al and actually I have nothing to say here anyways, so we can keep it as you made it :-) gr. Ronald Original Message  Subject: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c From: Freddie Chopin To: openocd-development Date: Sat Jun 27 20

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Freddie Chopin
Ronald Vanschoren pisze: > Did you actually try it? There is no redefinition normally (depends on > how the .h file of ftd2xx is made) and I think I used this approach > before (although slightly different). Guess it's a 2 minute check for > you (just one function will do), so if you don't mind

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Ronald Vanschoren
1) Why do you initialize the FT_Close_ptr and FT_Purge_ptr in a different place then all the others? Isn't it cleaner to keep all the initializations together? As a trV embedded engineer I've saved some memory [; Keeping all together would be clearer, but I decided to min

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Freddie Chopin
Ronald Vanschoren pisze: > I don't have any experience in OpenOCD development Just like me [; > 1) Why do you initialize the FT_Close_ptr and FT_Purge_ptr in a > different place then all the others? Isn't it cleaner to keep all the > initializations together? As a trV embedded engineer I've sa

Re: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Ronald Vanschoren
s way you don't have to add ifdef's around all function calls and it'll make the patch smaller and less possibilities for mistakes in the future. gr. Ronald Original Message  Subject: [Openocd-development] [patch] dynamic loading of ftd2xx.dll for    windows in

[Openocd-development] [patch] dynamic loading of ftd2xx.dll for windows in ft2232.c

2009-06-27 Thread Freddie Chopin
This patch enables dynamic loading of ftd2xx.dll in ft2232.c on Win32 platform. It's made to work only on Win32 and for ftd2xx.dll in ft2232.c - it doesn't affect linux, libftdi or any other modules that could use that. That's the first from a series that I am planing (win32 only): 1. (this