Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread Øyvind Harboe
On Thu, Dec 10, 2009 at 9:51 PM, David Brownell wrote: > On Thursday 10 December 2009, Øyvind Harboe wrote: >> On Thu, Dec 10, 2009 at 9:10 PM, David Brownell wrote: >> > On Thursday 10 December 2009, Ųyvind Harboe wrote: >> >> +   values[1]=(1<<5)|reg_addr; >> > >> > Could you please add spa

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread Øyvind Harboe
On Thu, Dec 10, 2009 at 9:10 PM, David Brownell wrote: > On Thursday 10 December 2009, Ųyvind Harboe wrote: >> +   values[1]=(1<<5)|reg_addr; > > Could you please add spaces around the operators? > >        values[1] = (1 << 5) | reg_addr; > > I've been carrying around a cleanup patch, as-yet

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > On Thu, Dec 10, 2009 at 9:10 PM, David Brownell wrote: > > On Thursday 10 December 2009, Ųyvind Harboe wrote: > >> +   values[1]=(1<<5)|reg_addr; > > > > Could you please add spaces around the operators? > > > >        values[1] = (1 << 5) |

Re: [Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread David Brownell
On Thursday 10 December 2009, Øyvind Harboe wrote: > +   values[1]=(1<<5)|reg_addr; Could you please add spaces around the operators? values[1] = (1 << 5) | reg_addr; I've been carrying around a cleanup patch, as-yet unmerged, to fix that routine... _

[Openocd-development] [PATCH 2/4] optimisation: tiny optimisation for embedded ice

2009-12-10 Thread Øyvind Harboe
use two shift operations instead of three to set embedded ice register. Signed-off-by: Øyvind Harboe --- src/target/embeddedice.h |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/target/embeddedice.h b/src/target/embeddedice.h index 1faa1ee..ec381ff 100644 ---