Re: [Openocd-development] [PATCH 1/4] improve command_done() API and docs

2009-12-05 Thread Zach Welch
On Sat, 2009-12-05 at 13:26 -0800, David Brownell wrote: > On Sunday 29 November 2009, Zachary T Welch wrote: > > Note: this audit revealed some potential bugs with the command context > > implementation. There was a reason that commands were added at the > > end of the list. Shallow copying of c

Re: [Openocd-development] [PATCH 1/4] improve command_done() API and docs

2009-12-05 Thread David Brownell
On Sunday 29 November 2009, Zachary T Welch wrote: > Note: this audit revealed some potential bugs with the command context > implementation.  There was a reason that commands were added at the > end of the list.  Shallow copying of command_context means that > the list is shared between them. Whe

[Openocd-development] [PATCH 1/4] improve command_done() API and docs

2009-11-29 Thread Zachary T Welch
command_done() does not need to return an error, but it needed Doxygen comment. Provide some for copy_command_context as well. Note: this audit revealed some potential bugs with the command context implementation. There was a reason that commands were added at the end of the list. Shallow copyi