Re: [Openocd-development] [PATCH 1/2] ecos: crisper implementation of timeval_ms()

2009-12-15 Thread Øyvind Harboe
I believe this patch addresses the issues you raised. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer From c8b8a34bb5e98660c4ce3683fb64af31b494d55c Mon Sep 17 00:00:00

Re: [Openocd-development] [PATCH 1/2] ecos: crisper implementation of timeval_ms()

2009-12-15 Thread Zach Welch
I would almost prefer that you use a Makefile trick here. We should avoid adding new #if's in the code when it's possible to avoid them. At the very least, provide two _complete_ versions of the function. Your new comment is misleading, as it only applies to one branch. On Tue, 2009-12-15 at 15:

[Openocd-development] [PATCH 1/2] ecos: crisper implementation of timeval_ms()

2009-12-15 Thread Øyvind Harboe
A crisper implementation makes profiling a tad easier. Signed-off-by: Øyvind Harboe --- src/helper/time_support.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/helper/time_support.c b/src/helper/time_support.c index 693528f..4e69c42 100644 --- a/src