Re: [Openocd-development] [PATCH] updated Fujitsu FM3 Flash driver

2011-10-01 Thread Peter Stuge
openOCD.fseu wrote: > please find attached the updated Fujistu CORTEX M3 NOR Flash driver. > It includes: > - Improvement of error handling of "retval = target_read/write_xxx();" Great to get better error handling! All the repeated retval=..if() return look absolutely horrible but that's indeed no

Re: [Openocd-development] [PATCH] updated Fujitsu FM3 Flash driver

2011-10-01 Thread Øyvind Harboe
Hi, some comments: 1. please fix warning: fm3.c: In function ‘fm3_chip_erase’: fm3.c:785:25: error: declaration of ‘fm3_info’ shadows a global declaration fm3.c:774:12: error: shadowed declaration is here 2. Remove this history, git keeps it: +// History: +// 2011-07-13 MWi First version +//