Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 23:31 +0100, Spencer Oliver wrote: > Zach, > > > > This breaks my build on cygwin, native win32 and ubuntu (intrepid). > > > I will try and find some time later this week to look into. > > > > I will look at Ubuntu shortly and potentially post a patch, > > but I can also ta

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 22:48 +0100, Spencer Oliver wrote: [snip] > This breaks my build on cygwin, native win32 and ubuntu (intrepid). > I will try and find some time later this week to look into. I will look at Ubuntu shortly and potentially post a patch, but I can also take a stab at cygwin if yo

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Spencer Oliver
> > Committed. > > Note that treating warnings as errors may well have to stay > non-default. Be prepared for a bit of flak... > > Since you're willing to address issues that are brought up > here, I'm applying the patch to see if we can navigate some > dire straits w/a few patches and then b

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-19 Thread Zach Welch
On Sun, 2009-04-19 at 23:06 +0200, Øyvind Harboe wrote: > Committed. > > Note that treating warnings as errors may well have to stay > non-default. Be prepared for a bit of flak... Did you mean "on as default"? I hope that to be the case, as I think most developers do not report warnings - only

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-19 Thread Øyvind Harboe
Committed. Note that treating warnings as errors may well have to stay non-default. Be prepared for a bit of flak... Since you're willing to address issues that are brought up here, I'm applying the patch to see if we can navigate some dire straits w/a few patches and then be out into more open w

[Openocd-development] [PATCH] treat warnings as errors

2009-04-19 Thread Zach Welch
Hi all, I have attached a patch that allows the OpenOCD project to use the -Wextra and -Werror flags, providing new configuration options to disable them (--disable-wextra and --disable-werror, respectively). In the process, I updated the help text of the gccwarnings option to better reflect th