I need to look into details, but I believe that this breaks
synchronous execution of JTAG calls (for hardware
implementations of JTAG FIFOs).
I believe this is what Dick was trying to point out, but I need
more time to look into this.
--
Øyvind Harboe
Embedded software and hardware consulting s
Magnus Lundin wrote:
> Dick Hollenbeck skrev:
>> Zach,
>>
>> I think this patch is fundamentally wrong and is a disaster the
>> moment it is applied.
>>
>> The queue sits between the jtag api and the drivers. The api calls
>> track "future" state according to the most recent api call submitted
Sorry I take back my earlier comment. I didn't check tap_set_state()
and only assumed that it wraps cmd_queue_cur_state. But it doesn't and
I just checked the patch on arm11 and it breaks arm11.
When arm11 queries cmd_queue_cur_state it wants to know in what state
the previously queue command left
Dick Hollenbeck skrev:
> Zach,
>
> I think this patch is fundamentally wrong and is a disaster the moment
> it is applied.
>
> The queue sits between the jtag api and the drivers. The api calls
> track "future" state according to the most recent api call submitted
> (and put onto the back end o
Zach,
I think this patch is fundamentally wrong and is a disaster the moment
it is applied.
The queue sits between the jtag api and the drivers. The api calls
track "future" state according to the most recent api call submitted
(and put onto the back end of the queue) via the cmd_queue_cur_st
Looks good.
Michael
On Sat, May 23, 2009 at 11:08 PM, Zach Welch wrote:
> Hi all,
>
> The attached patch removes the cmd_queue_cur_state global variable,
> replacing all uses with calls to tap_set_state() or tap_get_state().
>
> While this seems completely trivial, I wanted to post it for review
Hi all,
The attached patch removes the cmd_queue_cur_state global variable,
replacing all uses with calls to tap_set_state() or tap_get_state().
While this seems completely trivial, I wanted to post it for review.
Any objections? All in favor?
Cheers,
Zach
---
jtag/jtag.c | 13 ++
