Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
> What exactly is checked by jenkins currently? I suggest at least one > build with the default "./configure" (no options) and one with as many > "./configure" options enabled as is possible on the build host. It's very early days still and we're still sorting out problems. We have ambitions to d

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Uwe Hermann
On Wed, Oct 19, 2011 at 08:32:42PM +0200, Øyvind Harboe wrote: > - Jenkins will build and check your patch for warnings. If you generate > warnings in some of the configurations that Jenkins checks for, you will > get an email w/info about that. No other humans will waste time on your > patch befor

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Attila Kinali
On Thu, 20 Oct 2011 07:18:18 +0200 Peter Stuge wrote: > You need an OpenID from somewhere (let me know if you want one from me) > You need to register on a web page and pick a username > You need to set an HTTP password or upload a public SSH key > > The above takes not two minutes. If you have

Re: [Openocd-development] [PATCH] Unused variables

2011-10-20 Thread Øyvind Harboe
Actually, in some ways nothing has changed when we switched to Gerrit. Before Gerrit, OpenOCD maintainers had stopped lifting patches into git and now we don't lift them into Gerrit. Same thing, except with Gerrit contributors (or anyone) have the option of lifting patches into Gerrit themselves.

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Jon Povey
Øyvind Harboe wrote: > If you want to spend the time taking other people's patches and > pushing them to Gerrit so they don't have to, go right ahead. Obviously not if I am not in a hurry to take the time to setup for gerrit even for myself. Don't think the sarcasm was helpful there. > We're sta

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Jon Povey
openocd-development-boun...@lists.berlios.de wrote: > Jon Povey wrote: >> this additional barrier to contributing does put me and others off >> contributing in future. > > Using Git is also a barrier for some, perhaps even for many. Gerrit > is new, so sure there will be resistance. Maybe sometime

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
On Thu, Oct 20, 2011 at 8:38 AM, Peter Stuge wrote: > Øyvind Harboe wrote: >> Some graphing I've been thinking about: >> >> - plot a number that shows the redundancy in maintainers. I.e. are we >> relying on a single maintainer or are there multiple maintainers > > I've so far taken infinitely man

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Øyvind Harboe wrote: > Some graphing I've been thinking about: > > - plot a number that shows the redundancy in maintainers. I.e. are we > relying on a single maintainer or are there multiple maintainers I've so far taken infinitely many more commits from Gerrit into openocd.git than before. Much

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
On Thu, Oct 20, 2011 at 7:35 AM, Peter Stuge wrote: > Øyvind Harboe wrote: >> I'm thinking a bit about how I can draw up some graphs on this... > > Graphing number of commits is easy, but graphing the review is > difficult. Before we got Gerrit going I decided that I could no longer spend time su

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Øyvind Harboe wrote: > I'm thinking a bit about how I can draw up some graphs on this... Graphing number of commits is easy, but graphing the review is difficult. //Peter ___ Openocd-development mailing list Openocd-development@lists.berlios.de https:/

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
If you want to spend the time taking other people's patches and pushing them to Gerrit so they don't have to, go right ahead. You do not have to be an OpenOCD maintainer to do this, anyone can push anyones patches to Gerrit for review. I don't expect you to step up to take such a role, nor do I e

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Jon Povey wrote: > this additional barrier to contributing does put me and others off > contributing in future. Using Git is also a barrier for some, perhaps even for many. Gerrit is new, so sure there will be resistance. Maybe sometime it will be just as common as Git itself. I think the learnin

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Jon Povey
openocd-development-boun...@lists.berlios.de wrote: > If you don't have time to work on OpenOCD, then I don't have any > problems with that. The world is full of smart people who could have, > but don't have time to, contribute to OpenOCD. [...] > If this means that we loose those contributors who

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Peter Stuge
Freddie Chopin wrote: >> Please read HACKING and post to Gerrit. I second this. > Sorry, I don't have time to do so because: Sorry, noone has time to deal with your patch. > 1. The patch is trivial It might seem so, but actually it's not. It has multiple logical changes combined in a single

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
If you don't have time to work on OpenOCD, then I don't have any problems with that. The world is full of smart people who could have, but don't have time to, contribute to OpenOCD. If you do want to spend some time on OpenOCD, then I urge you to have a look at what Gerrit+Jenkins does for the com

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Freddie Chopin
On 2011-10-19 19:50, Øyvind Harboe wrote: Please read HACKING and post to Gerrit. Sorry, I don't have time to do so because: 1. The patch is trivial 2. I use git in Linux hosted in VitualBox, where emailing patches kinda does not work 3. My knowledge of Linux and Git is minimal So basically

Re: [Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Øyvind Harboe
Please read HACKING and post to Gerrit. Thanks! -- Øyvind Harboe - Can Zylin Consulting help on your project? US toll free 1-866-980-3434 http://www.zylin.com/ ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.ber

[Openocd-development] [PATCH] Unused variables

2011-10-19 Thread Freddie Chopin
Nothing to comment here - pretty straightforward. 4\/3!! From 39cb927737d653db8610fce8001aa98e8b256451 Mon Sep 17 00:00:00 2001 From: Freddie Chopin Date: Wed, 19 Oct 2011 17:55:33 +0200 Subject: [PATCH] Unused variables Fix a few errors with set and unused variables detected by GCC 4.7.0 ---