Re: [Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread Øyvind Harboe
On Mon, Nov 30, 2009 at 6:04 PM, David Brownell wrote: > On Monday 30 November 2009, Ųyvind Harboe wrote: >> eCos does not have C99 support, which is kinda annoying, >> but not totally unexpected for deeply embedded systems. > > Could you elaborate on what's missing?  I'm guessing some > aspects o

Re: [Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread David Brownell
On Monday 30 November 2009, Øyvind Harboe wrote: > eCos does not have C99 support, which is kinda annoying, > but not totally unexpected for deeply embedded systems. Could you elaborate on what's missing? I'm guessing some aspects of the runtime support. Clearly not all the language parsing aspe

Re: [Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread Øyvind Harboe
On Mon, Nov 30, 2009 at 11:28 AM, Zach Welch wrote: > The proper solution: tell the maintainers of your vsnprintf to improve > their implementation! ;) --Z Actually it turns out eCos does offer a C99 compliant vsnprintf now, it just isn't enabled by default. This fix in eCos is more recent than m

Re: [Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread Zach Welch
Rather, send them a patch to fix it what was I thinking. :) In any event, don't break OpenOCD's perfectly acceptable code. On Mon, 2009-11-30 at 02:28 -0800, Zach Welch wrote: > The proper solution: tell the maintainers of your vsnprintf to improve > their implementation! ;) --Z > > On Mon,

Re: [Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread Zach Welch
The proper solution: tell the maintainers of your vsnprintf to improve their implementation! ;) --Z On Mon, 2009-11-30 at 02:20 -0800, Zach Welch wrote: > Do not apply. The old implementation was total crap, and your vsnprintf > implementation must be too. That's not our problem, and it can be >

Re: [Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread Zach Welch
Do not apply. The old implementation was total crap, and your vsnprintf implementation must be too. That's not our problem, and it can be worked around without destroying the improvements for others. Use a single 'char' on the stack. One character should be enough. --Z On Mon, 2009-11-30 at 1

[Openocd-development] [PATCH] Revert "improve alloc_vprintf"

2009-11-30 Thread Øyvind Harboe
Whether or not vsnprintf() allows NULL as pointer to destination string to calculate length depends on the implementation. Revert more efficient, but non-portable implementation. This reverts commit 338a674faa96ae321560efa3f1b1e8122d61aac4. --- src/helper/log.c | 43 +++