Re: [Openocd-development] [PATCH] More printf fixes

2009-05-22 Thread Rick Altherr
Committed revision 1882. On May 21, 2009, at 11:43 AM, Rick Altherr wrote: On May 21, 2009, at 11:24 AM, David Brownell wrote: On Thursday 21 May 2009, Rick Altherr wrote: I believe the fix for off_t should be portable, but I'm less certain of the struct timeval fix. The timeval fix loo

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread David Brownell
On Thursday 21 May 2009, Rick Altherr wrote: > Yeah, given that it is an integer and of variable size, casting to   > intmax_t is probably appropriate.  Please try the attached patch. The '%j' format worked on an x86_64 build. Live and learn... I'd never heard of '%j' before! Next thing you know

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Øyvind Harboe
> Anyone have a chance to test on Linux? svn head builds on my Debian box this morning. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berli

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Rick Altherr
On May 21, 2009, at 11:50 AM, Øyvind Harboe wrote: Builds fine on Cygwin. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com Anyone have a chance to test on Linux? -- Rick Altherr kc8...@kc8apf.net "He said he hadn't had a byte in three da

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Øyvind Harboe
Builds fine on Cygwin. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-developm

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Rick Altherr
On May 21, 2009, at 11:24 AM, David Brownell wrote: On Thursday 21 May 2009, Rick Altherr wrote: I believe the fix for off_t should be portable, but I'm less certain of the struct timeval fix. The timeval fix looks like it reverses a fix I needed: pld.c: In function ‘handle_pld_load_command

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread David Brownell
On Thursday 21 May 2009, Rick Altherr wrote: > I believe the fix for   > off_t should be portable, but I'm less certain of the struct timeval   > fix.   The timeval fix looks like it reverses a fix I needed: pld.c: In function ‘handle_pld_load_command’: pld.c:194: error: format ‘%i’ expects type

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Rick Altherr
On May 21, 2009, at 11:05 AM, Øyvind Harboe wrote: This patch makes it better and worse w/Cygwin. svn head Cygwin build fails on xsvf.c without this patch. pld.c fails w/this patch and builds fine w/svn head. libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../../ openocd/src/pld

Re: [Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Øyvind Harboe
This patch makes it better and worse w/Cygwin. svn head Cygwin build fails on xsvf.c without this patch. pld.c fails w/this patch and builds fine w/svn head. libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I../../../openocd/src/pld -I../.. -I../../../openocd/src/server -I../../../openocd

[Openocd-development] [PATCH] More printf fixes

2009-05-21 Thread Rick Altherr
At least on OS X, a few additional printf warning cropped up due to the wrong format sequence being used for things like off_t (variably sized) and struct timeval. The attached patch resolves the issues on OS X, but I haven't tested it on anything else. I believe the fix for off_t should