Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-30 Thread David Brownell
On Wednesday 30 December 2009, Michael Schwingen wrote: > David Brownell wrote: > > On Tuesday 29 December 2009, Antonio Borneo wrote: > > > >> Should every file in the project be converted to TAB width = 4 ? > >> > > > > NO!!! > > Why not? > > I do not like tab=4 myself, That's part of i

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-30 Thread David Brownell
On Tuesday 29 December 2009, Antonio Borneo wrote: > In attachment there is the first patch of the set, compressed. > It just touches the following files: > ./BUGS > ./NEWS-0.2.0 > ./NEWTAPS > ./PATCHES > ./README.Win32 > ./TODO > ./bootstrap > ./configure.in > ./doc/manual/primer/commands.txt > ./

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-30 Thread Michael Schwingen
David Brownell wrote: > On Tuesday 29 December 2009, Antonio Borneo wrote: > >> Should every file in the project be converted to TAB width = 4 ? >> > > NO!!! > Why not? I do not like tab=4 myself, but if the styleguide says to use that tabwidth for OpenOCD, then every file should confor

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-30 Thread Øyvind Harboe
On Wed, Dec 30, 2009 at 6:08 AM, David Brownell wrote: > On Tuesday 29 December 2009, Antonio Borneo wrote: >> Should every file in the project be converted to TAB width = 4 ? > > NO!!! I'm inclined not to touch the patch. I'm kinda whitespace blind and this seems to be an area with strong opinio

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-29 Thread David Brownell
On Tuesday 29 December 2009, Antonio Borneo wrote: > Should every file in the project be converted to TAB width = 4 ? NO!!! ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-devel

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-29 Thread Antonio Borneo
In attachment there is the first patch of the set, compressed. It just touches the following files: ./BUGS ./NEWS-0.2.0 ./NEWTAPS ./PATCHES ./README.Win32 ./TODO ./bootstrap ./configure.in ./doc/manual/primer/commands.txt ./doc/manual/release.txt ./doc/manual/server.txt ./doc/openocd.texi ./ecosfla

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-29 Thread Antonio Borneo
I agree, that's why I added comment "If, for any reason, you prefer to not apply this patch on current rc1, I have no problem to provide an update patch later on." I already skipped all binary files, and expect patch is safe. Anyway, I will provide the patch spitted, and let you decide. Best Rega

Re: [Openocd-development] [PATCH] Code cleanup - remove useless space/tab

2009-12-29 Thread Øyvind Harboe
Spooky. How do we *know* that this doesn't subtly break something? Before 0.4 I would want to break apart this patch and take the least risky ones, e.g. .c/.h files should be safe enough. -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.ht