Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-20 Thread Spencer Oliver
David Brownell wrote: > On Wednesday 20 January 2010, Spencer Oliver wrote: As a side note this issue will also apply to armv5 cores with the bkpt instruction. >>> Curious ... there's already some logic to skip breakpoints >>> there, you're saying it doesn't handle this case right? >>> >

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-20 Thread David Brownell
On Wednesday 20 January 2010, Spencer Oliver wrote: > >> As a side note this issue will also apply to armv5 cores with the bkpt > >> instruction. > > > > Curious ... there's already some logic to skip breakpoints > > there, you're saying it doesn't handle this case right? > > > > yes openocd wi

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-20 Thread Spencer Oliver
David Brownell wrote: > On Tuesday 19 January 2010, Spencer Oliver wrote: >> David Brownell wrote: >>> On Tuesday 19 January 2010, Spencer Oliver wrote: Skip over a bkpt instruction if found on resume/step. Only software breakpoints known to openod are handled. So this handles the sp

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread David Brownell
[ Re semihosting on Cortex-M3/ARMv7-M ] On Tuesday 19 January 2010, Spencer Oliver wrote: > > Hmm, my notion there was to make armv7m use the same "struct arm" > > as other ARM cores, and try to share more core infrastructure. > > It shouldn't be *quite* so different as it is now. > > > > I have

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread David Brownell
On Tuesday 19 January 2010, Spencer Oliver wrote: > David Brownell wrote: > > On Tuesday 19 January 2010, Spencer Oliver wrote: > >> Skip over a bkpt instruction if found on resume/step. > >> Only software breakpoints known to openod are handled. > >> So this handles the special case of a user adde

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread Spencer Oliver
David Brownell wrote: On Tuesday 19 January 2010, Spencer Oliver wrote: David Brownell wrote: On Monday 18 January 2010, Spencer Oliver wrote: Skip over a bkpt instruction if found on resume/step. This is a bugfix for RAM-based code, yes? flash or ram, most semi hosting code would be in flas

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread David Brownell
On Tuesday 19 January 2010, Spencer Oliver wrote: > David Brownell wrote: > > On Monday 18 January 2010, Spencer Oliver wrote: > >> Skip over a bkpt instruction if found on resume/step. > > > > This is a bugfix for RAM-based code, yes? > > flash or ram, most semi hosting code would be in flash ho

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread Spencer Oliver
David Brownell wrote: > On Tuesday 19 January 2010, Spencer Oliver wrote: >> Skip over a bkpt instruction if found on resume/step. >> Only software breakpoints known to openod are handled. >> So this handles the special case of a user added bkpt, eg. semi-hosting. >> >> Signed-off-by: Spencer Olive

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread David Brownell
On Tuesday 19 January 2010, Spencer Oliver wrote: > Skip over a bkpt instruction if found on resume/step. > Only software breakpoints known to openod are handled. > So this handles the special case of a user added bkpt, eg. semi-hosting. > > Signed-off-by: Spencer Oliver OK by me, but I'd change

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread Spencer Oliver
Hi, Updated patch, now correct handles step. Cheers Spen >From 669c0944a09bf40bcd606964e1dee967ab594b0e Mon Sep 17 00:00:00 2001 From: Spencer Oliver Date: Tue, 19 Jan 2010 16:44:03 + Subject: [PATCH] ARMV7M: handle bkpt instruction on resume/step Skip over a bkpt instruction if found on r

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-19 Thread Spencer Oliver
David Brownell wrote: > On Monday 18 January 2010, Spencer Oliver wrote: >> Skip over a bkpt instruction if found on resume/step. > > This is a bugfix for RAM-based code, yes? > > flash or ram, most semi hosting code would be in flash however. I am updating the arm semihosting to support armv7m

Re: [Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-18 Thread David Brownell
On Monday 18 January 2010, Spencer Oliver wrote: > Skip over a bkpt instruction if found on resume/step. This is a bugfix for RAM-based code, yes? > +int armv7m_check_bkpt_inst(struct target *target) This name leaves a lot to be desired. How about using "maybe_skip" instead of "check"? And th

[Openocd-development] [PATCH] ARMV7M: handle bkpt instruction on resume/step

2010-01-18 Thread Spencer Oliver
Skip over a bkpt instruction if found on resume/step. Only software breakpoints known to openod are handled. So this handles the special case of a user added bkpt, eg. semi-hosting. Signed-off-by: Spencer Oliver --- src/target/armv7m.c| 31 +++ src/target/armv