Re: [Openocd-development] OpenOCD Gerrit Review

2011-10-11 Thread Tormod Volden
On Tue, Oct 11, 2011 at 4:14 PM, Laurent Gauch wrote: > Why using a commercial server and a commercial url for an open source > project? heh, like sourceforge.net, code.google.com, github.com or launchpad.net? So that the open-source crowd can spend their valuable time on producing free and open-

Re: [Openocd-development] Fwd: [PATCH] Start porting of usb jtag drivers to libusb-1.0 instead of libusb.0.1

2011-10-10 Thread Tormod Volden
On Mon, Oct 10, 2011 at 9:34 PM, Mauro Gamba wrote: > Hello to everyone, > I start the porting of the usb jtag drivers to the libusb-1.0 library. > I tested the jlink driver under linux and it work quite well. I've > ported also the rlink and usbprog driver but I can't test them without > the hardw

Re: [Openocd-development] [Patch(Resend/corrected)^2] Add definition for the STEVAL-PCC010V2 Board (STM32MF207)

2011-09-01 Thread Tormod Volden
On Thu, Sep 1, 2011 at 4:33 PM, Uwe Bonnes wrote: > appended simple patch adds the definition for the  STEVAL-PCC010V2 Board > withe the STM32F207. At least the detection works: > ( this time with the comment corrected + SI unit etc) It was the file name that I thought was wrong, not the comment.

Re: [Openocd-development] [Patch(Resend/corrected] Add definition for the STEVAL-PCC010V2 Board (STM32MF207)

2011-09-01 Thread Tormod Volden
On Thu, Sep 1, 2011 at 3:44 PM, Uwe Bonnes wrote: > appended simple patch adds the definition for the  STEVAL-PCC010V2 Board > withe the STM32F207. At least the detection works: Sorry to nitpick again, but the card model is called "...010" and... >  tcl/board/steval_pcc0102v2.cfg |    8

Re: [Openocd-development] [Patch] Add definition for the STEVAL-PCC010V2 Board (STM32MF207)

2011-09-01 Thread Tormod Volden
On Thu, Sep 1, 2011 at 11:32 AM, Uwe Bonnes wrote: > Hello, > > appended simple patch adds the definition for the  STEVAL-PCC010V2 Board > withe the STM32F207. At least the detection works: > +# This is an STM32 eval board with a single STM32F10x (128KB) chip. > +# http://www.st.com/internet/evalb

Re: [Openocd-development] Coding style

2011-08-30 Thread Tormod Volden
On Tue, Aug 30, 2011 at 6:53 AM, Øyvind Harboe wrote: > If Kernel programming guidelines requires variable names like that, > then I don't want to see it for OpenOCD. Do not fear :) This is what the Linux Documentation/CodingStyle says: "Encoding the type of a function into the name (so-called Hu

Re: [Openocd-development] rebase vs. merge

2011-08-10 Thread Tormod Volden
On Wed, Aug 10, 2011 at 11:49 AM, Drasko DRASKOVIC wrote: > What I'd like to avoid is this situation : you do development on your > independent branch, making many temporary commits which leave > temporary logs. These temporary logs should not be seen in the > official master's history, but only o

Re: [Openocd-development] rebase vs. merge

2011-08-10 Thread Tormod Volden
On Wed, Aug 10, 2011 at 10:09 AM, Drasko DRASKOVIC wrote: > On Wed, Aug 10, 2011 at 6:53 AM, Øyvind Harboe > wrote: >> I am genuinely interested in hearing the pros and cons of rebasing >> vs. merging pull requests. >> >> rebasing yields a nice linear history, which I like. Perhaps I'm just >> o

Re: [Openocd-development] [PATCH] Fix "unused variable" warnings (errors) detected with GCC 4.7.0

2011-06-03 Thread Tormod Volden
On Thu, Jun 2, 2011 at 10:19 PM, Øyvind Harboe wrote: > On Thu, Jun 2, 2011 at 10:11 PM, Freddie Chopin >> Any hints on the method to split such commited change into several >> commits? GIT is still not my strongest side (; > > wip = work-in-progress, new branch below > > git checkout -b wip > git

Re: [Openocd-development] bootstrap: patch proposal

2011-06-03 Thread Tormod Volden
On Thu, Jun 2, 2011 at 2:32 AM, Jean-Christophe PLAGNIOL-VILLARD wrote: > normaly in shell we so > if [ "x$1" = "xnosubmodule" ]; then > > to compatible with old shell too Yes, I have seen this construct a lot in old scripts, but it reduces readability a lot, and I think it should be avoided nowad

[Openocd-development] [PATCH v2] bootstrap: Various code improvements

2011-06-01 Thread Tormod Volden
From: Tormod Volden - Do not specify -e twice. - Use "which" instead of calling commands that might not exist. - Fix bashism ("==" is C not sh) - Carefully quote potentially empty variables - Check command arguments before doing anything - Rewrite argument checking to be mo

[Openocd-development] [PATCH] bootstrap: Various code improvements

2011-06-01 Thread Tormod Volden
From: Tormod Volden - Do not specify -e twice. - Use "which" instead of calling commands that might not exist. - Fix bashism ("==" is C not sh) - Carefully quote potentially empty variables - Check command arguments before doing anything - Rewrite argument checking to be mo

Re: [Openocd-development] bootstrap: patch proposal

2011-06-01 Thread Tormod Volden
On Wed, Jun 1, 2011 at 4:24 PM, Øyvind Harboe wrote: > Would you mind formulating a patch? > > It would be greatly appreciated. > > Thanks! Feel free to cut and paste from my e-mail. I was just looking at it through gitweb and I don't have any git tree etc set up here and now. But I can come back

Re: [Openocd-development] bootstrap: patch proposal

2011-06-01 Thread Tormod Volden
On Wed, Jun 1, 2011 at 7:22 AM, Øyvind Harboe wrote: > Merged very slightly different version that prints out error message > upon invalid argument. >From the commit: +if [ $1 == nosubmodule ]; then Note that if $1 is empty, some (most) shells will see just [ == nosubmodule ] and fail. So always

Re: [Openocd-development] [PATCH] docs: add HACKING file to help users get started with patches

2011-03-30 Thread Tormod Volden
On Wed, Mar 30, 2011 at 2:07 PM, Øyvind Harboe wrote: > Better? Looks good to me. > If I start explaining different scenarios like "adding files", etc. > then where do I stop? I would guess "adding new files" is basic and common contributor usage (10%?), and "editing existing files" and "adding

Re: [Openocd-development] [PATCH] docs: add HACKING file to help users get started with patches

2011-03-30 Thread Tormod Volden
On Wed, Mar 30, 2011 at 1:09 PM, Øyvind Harboe wrote: > +By the time you have read this, one supposes that > +you have figured out how to clone the OpenOCD git > +repository. Would not hurt to add the git clone command here, for instance if the contributor has gotten the sources from a released ta

Re: [Openocd-development] making contributing easier

2011-03-30 Thread Tormod Volden
On Wed, Mar 30, 2011 at 6:53 AM, Øyvind Harboe wrote: > These are great suggestions. Do you know of anyone who's written > such readmes in GPL projects that we could copy? Googling (readme.patches "git commit") gave some examples: http://git-scm.com/ http://git.savannah.gnu.org/cgit/gnutls.git/tre

Re: [Openocd-development] making contributing easier

2011-03-29 Thread Tormod Volden
On Tue, Mar 29, 2011 at 10:35 PM, Øyvind Harboe wrote: > How about adding a "contribute" script which did the following: > > - fetch from origin > - commit changes from user, bringing up a text editor with > a template commit message. > - rebase origin to the master branch, abort if there are confl

[Openocd-development] [PATCH] olimex_stm32_h103.cfg: Add reset_config for shorted RST-TRST

2010-12-20 Thread Tormod Volden
From: Tormod Volden On these boards (Olimex, IAR) an R-T jumper shorting RST and TRST is soldered from the factory, see the pictures at: http://www.micromouseonline.com/blog/2008/08/05/stm32-and-the-seggeriar-j-link/ Add reset_config trst_and_srst to make reset work out of the box. --- Sorry

[Openocd-development] [PATCH] olimex_stm32_h103.cfg: Add reset_config for shorted RST-TRST

2010-12-20 Thread Tormod Volden
From: Tormod Volden On these boards (Olimex, IAR) an R-T jumper shorting RST and TRST is soldered from the factory. Add reset_config trst_and_srst to make reset work out of the box. --- Hi, I did not get any response on my two questions, but here is the patch that I would suggest. It has been

[Openocd-development] [PATCH 3/3] tcl/interface/flashlink.cfg: Fix broken ST URL

2010-12-19 Thread Tormod Volden
From: Tormod Volden --- With this, all www.st.com URLs have been corrected or verified. Tormod tcl/interface/flashlink.cfg |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcl/interface/flashlink.cfg b/tcl/interface/flashlink.cfg index 5c81cf5..22abe7b 100644 --- a

[Openocd-development] [PATCH 2/3] tcl/board: Clean up STM32 EVAL boards configurations

2010-12-19 Thread Tormod Volden
From: Tormod Volden Make consistent use of hex memory size for flashing. Delete stm32f10x_128k_eval.cfg. It has no product reference nor any settings in it. --- This patch is mostly cosmetic and just makes things that are the same, look the same. Anyway I am not sure if the board name

[Openocd-development] [PATCH 1/3] tcl/board: Fix ST URLs in stm32* eval board configuration files

2010-12-19 Thread Tormod Volden
From: Tormod Volden ST recently rewamped (screwed up) their web site and broke all links. Also match the chip names with those on the web site product descriptions. --- Hi, Here is a series of patches for the STM32. This one only makes documentation changes. Tormod tcl/board

Re: [Openocd-development] reset_config on Olimex STM32 boards

2010-12-17 Thread Tormod Volden
Tormod Volden writes: > Section 9.2 under "Signals shorted" says to use the > "reset_config combination options", however it is not clearly listed which of > the options are of "combination" type. Naively I tried "combined" but that > does

[Openocd-development] reset_config on Olimex STM32 bo ards

2010-12-17 Thread Tormod Volden
Hi, I have an IAR (Olimex OEM) STM32-SK board which has an RST to TRST jumper, soldered together from the factory, like is also commented here: http://www.micromouseonline.com/blog/2008/08/05/stm32-and-the-seggeriar-j-link/ To use it with openocd via the IAR (Segger OEM) j-link I have to run "rese

Re: [Openocd-development] -Wshadow is now default

2010-06-18 Thread Tormod Volden
Freddie Chopin writes: > I don't know if the files will be encoded right... I've created those > patches in Linux (OpenSUSE) with just "git format-patch origin"... There > is something very wrong with the "subject" lines of those patches... /; The Subject lines are technically correct, what hap

[Openocd-development] dev snapshot packages for Ubuntu/Debian

2010-02-15 Thread Tormod Volden
Hi, For anyone interested, I am occasionally posting openocd snapshots to my PPA (personal package archive) at https://launchpad.net/~tormodvolden/+archive/ppa for Ubuntu 9.10 (Karmic). The binaries are built on Ubuntu but should install and work fine in Debian as well. I am just adding Uwe Hermann