Re: [Openocd-development] [PATCH 5/5] ft2232: Handle command buffer malloc() error in ft2232_init()

2011-06-09 Thread Sébastien Farquet
On Thu, 9 Jun 2011 18:13:38 +0200, Peter Stuge wrote: For greater convenience I've also pushed the commits to the repo shown in gitweb here: http://git.stuge.se/?p=openocd.git Thanks -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG inte

Re: [Openocd-development] [PATCH 5/5] ft2232: Handle command buffer malloc() error in ft2232_init()

2011-06-09 Thread Sébastien Farquet
tic int ft2232_quit(void) ftdi_deinit(&ftdic); #endif - free(ft2232_buffer); + if (ft2232_buffer) + free(ft2232_buffer); ft2232_buffer = NULL; return ERROR_OK; -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : Hig

Re: [Openocd-development] Outstanding patches => Fix: Correctly exit function: ft2232_init when an error occurred

2011-05-31 Thread Sébastien Farquet
rrow we will meet again high-quality code in OpenOCD project. Please correct me if im wrong :-) I hope that answers your questions :-) Best regards :-) Tomek -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG interface ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] Outstanding patches => Fix: Correctly exit function: ft2232_init when an error occurred

2011-05-30 Thread Sébastien Farquet
(That is the content of the function: ft2232_quit (from line: 3231 to line: 3242)) The little modification of the free for the variable: ft2232_buffer, it's to only free the memory when is necessary (and possible). -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-

Re: [Openocd-development] Fix: Correctly exit function: ft2232_init when an error occurred

2011-04-26 Thread Sébastien Farquet
} (That is the content of the function: ft2232_quit (from line: 3231 to line: 3242)) The little modification of the free for the variable: ft2232_buffer, it's to only free the memory when is necessary (and possible). -- Regards, Sébastien Farquet http

[Openocd-development] Fix: Correctly exit function: ft2232_init when an error occurred

2011-04-17 Thread Sébastien Farquet
No reaction So monday, I will make a commit on git://openocd.git.sourceforge.net/gitroot/openocd/openocd -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG interface ___ Openocd-development mailing list

[Openocd-development] Fix: Correctly exit function: ft2232_init when an error occurred

2011-04-14 Thread Sébastien Farquet
Hello, The attached file contains the patch. -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG interface openocd-ft2232-fix-ft2232_init-correctly-set-handle.patch Description: Binary data openocd-ft2232-fix-ft2232_init-correctly-set-handle

Re: [Openocd-development] To correctly close the JTAG adapter handle in any cases

2011-04-14 Thread Sébastien Farquet
_init() ft2232_open_x() ft2232_init_x() if error occured ft2232_close_x() ft2232_quit() ft2232_deinit_x() ft2232_close_x() I divide functions and create new to have a more clearly code. -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB

Re: [Openocd-development] To correctly close the JTAG adapter handle in any cases

2011-04-14 Thread Sébastien Farquet
patch to clarify jtag->init() and jtag->quit(). I think that is a good clarification. -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG interface ___ Openocd-development mailing list Openocd-

Re: [Openocd-development] To correctly close the JTAG adapter handle in any cases

2011-04-13 Thread Sébastien Farquet
jtag = NULL; } return ERROR_JTAG_INIT_FAILED; } So the pointer: jtag is null only if the jtag adapter is inactive. -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High

Re: [Openocd-development] To correctly close the JTAG adapter handle in any cases

2011-04-12 Thread Sébastien Farquet
adapters so, I can’t make all tests to grant that I doesn't add bug for others JTAG adapter. So I have made the choice to add: ERROR_JTAG_INIT_FAILED_WITH_UNOPEN_DEVICE -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG interface _

[Openocd-development] To correctly close the JTAG adapter handle in any cases

2011-04-12 Thread Sébastien Farquet
Hello, The attached file contains the patch. Patch to: "To correctly close the JTAG adapter handle in any cases" -- Regards, Sébastien Farquet http://www.amontec.com/ Amontec JTAGkey-2 : High speed USB JTAG interface openocd-jtag-fix-close-jtag-handle.patch Description: B