Re: [Openocd-development] svf patch[2/2]: omit space between '(' and ')'

2010-01-24 Thread David Brownell
> while (str_len > 0 && ((str[str_len - 1] == '0') || (str[str_len - 1] > == ' '))) Shouldn't that be "isspace(str[str_len - 1])" to allow leading tabs, newlines, etc? (If so, I'll just fix the patch before merging.) The "isblank" test is what's used earlier in that routine; it allows t

Re: [Openocd-development] svf patch[2/2]: omit space between '(' and ')'

2010-01-24 Thread simon qian
> That is, you want to see that "svf_all_content..." patch > applied to current git, and nothing else? patch[2/2] doesn't solve the problem, and as you said. You are right about this. The right solution should be this patch svf_all_content_between()_is_one_parameter.patch. > What errors in *SVF* do

Re: [Openocd-development] svf patch[2/2]: omit space between '(' and ')'

2010-01-24 Thread David Brownell
On Sunday 24 January 2010, simon qian wrote: > > Is that straightforward? It sounds like the right approach. > The patch is tested OK with Altera CPLD. Test output: I'm not quite clear. This message included a different patch, "svf_all_content_between()_is_one_parameter.patch". Is this intended

Re: [Openocd-development] svf patch[2/2]: omit space between '(' and ')'

2010-01-24 Thread simon qian
> Is that straightforward? It sounds like the right approach. The patch is tested OK with Altera CPLD. Test output: > svf simple.svf svf processing file: "simple.svf" "FREQUENCY 900.00 HZ" 9000 kHz "TRST ABSENT" "ENDDR IDLE" "ENDIR IRPAUSE" "STATE IDLE" "SIR 10 TDI ( 2C C ) " "( 2C C )"