Re: [Openocd-development] [PATCH] FT2232H/FT4232H w/ configure check

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 20:51 -0700, Zach Welch wrote: [snip] > That patch no longer applies cleanly. I went ahead and cleaned it up > (adding/removing whitespace), but it does not compile for me: > > ft2232.c:300: error: 'FT_DEVICE_2232H' undeclared [...] > ft2232.c:300: error: 'FT_DEVICE_4232H'

Re: [Openocd-development] [PATCH] add static keywords to at91rm9200

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] [PATCH] add static keywords to at91rm9200

2009-04-20 Thread Zach Welch
Hi all, I apparently forgot to revise that last patch one last time. This adds two static keywords that somehow got lost in the mix. Cheers, Zach Index: src/jtag/at91rm9200.c === --- src/jtag/at91rm9200.c (revision 1486) +++ src/j

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] fix at91sam7 uninitialized variable warnings

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] fix mingw32 fd_set macro warnings

2009-04-20 Thread Øyvind Harboe
Let me know when the patch is ready and I'll apply it. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/ma

Re: [Openocd-development] [PATCH] fix str9x type-punned pointer

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] configure.in: add -Wformat-security (4 of 4)

2009-04-20 Thread Øyvind Harboe
Committed. THanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] fix -Wformat-security warnings (1 of 4)

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] Patch: add non-CFI SST flashs

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] use static keyword in jtag layer and drivers

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-20 Thread Zach Welch
On Tue, 2009-04-21 at 13:53 +0900, Hiroshi Ito wrote: > zw> Index: src/helper/jim.c > zw> === > zw> --- src/helper/jim.c (revision 1478) > zw> +++ src/helper/jim.c (working copy) > zw> @@ -133,7 +133,8 @@ > zw> buf[sizeof(b

Re: [Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-20 Thread Hiroshi Ito
zw> Index: src/helper/jim.c zw> === zw> --- src/helper/jim.c(revision 1478) zw> +++ src/helper/jim.c(working copy) zw> @@ -133,7 +133,8 @@ zw> buf[sizeof(buf)-1] = 0; zw> #else zw> char *buf; int result

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Jeff Williams
Zack, I'm keeping tabs on the thread waiting for stuff to test. If I had a FT232-based pod I'd be happy to help. Since I program with the FTDI D2XX drivers in my work I might be able to help on FT232 side too. Does anyone know of a cheap FTDI-based pod and a good place to get it? Jeff E

Re: [Openocd-development] FT2232H/FT4232H support in trunk.

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 15:01 +0100, Ben Dooks wrote: > On Mon, Apr 20, 2009 at 08:00:19AM +0200, Joern Kaipf wrote: > > Hi Ben, > > > > Ben Dooks write: > > >I looked at src/jtag/ft2232.c and didn't notice anything there > > >specific to the extra features in the H parts, such as the new > > >speed

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 23:31 +0100, Spencer Oliver wrote: > Zach, > > > > This breaks my build on cygwin, native win32 and ubuntu (intrepid). > > > I will try and find some time later this week to look into. > > > > I will look at Ubuntu shortly and potentially post a patch, > > but I can also ta

[Openocd-development] [PATCH] fix at91sam7 uninitialized variable warnings

2009-04-20 Thread Zach Welch
Hi all, The attached patch fixes several uninitialized variable warnings for the CygWin and Win32 builds by assigning values. These warnings seem to indicate that 'gcc -O2' does not work as well for those targets, but this will also solve problems when using less optimization (as indicated by my

[Openocd-development] [PATCH] fix mingw32 prototype warning

2009-04-20 Thread Zach Welch
Spencer, The attached patch includes an attempt at fixing the following warning: jim.c: In function `Jim_EnvCoreCommand': jim.c:11977: warning: function declaration isn't a prototype If this doesn't do it, you might explore this one; my patch is a wild stab in the dark, but who knows. Cheers,

[Openocd-development] [PATCH] fix mingw32 fd_set macro warnings

2009-04-20 Thread Zach Welch
Hi all, The attached patch is required to work around bugs in the MinGW32 build. For context, the fd_set macros appear to be poorly defined on MinGW32, causing superfluous sign-compare warnings. The patch turns it off only when building a) that platform and b) those files that use those macros.

[Openocd-development] [PATCH] fix str9x type-punned pointer

2009-04-20 Thread Zach Welch
Hi all, The following patch fixes a type-punned pointer problem in the str9x flash module. I was seeing this a while back (and had a patch for it floating around then), but it had disappeared off my radar for some reason that I still can't explain (maybe different -O options?). Cheers, Zach In

[Openocd-development] [PATCH] configure.in: add -Wformat-security (4 of 4)

2009-04-20 Thread Zach Welch
Hi all, This patch adds -Wformat-security to the build CFLAGS. This appears to be enabled by default with Ubuntu 8.10, beyond the standard -Wformat. It would be nice to get to -Wformat=2, but that will take more work. Cheers, Zach Index: configure.in ===

[Openocd-development] [PATCH] target.c: fix unused return value warnings (3 of 4)

2009-04-20 Thread Zach Welch
Hi all, Ubuntu 8.10 has a newer version of the standard library that causes the compiler to issue warnings for unchecked return values for fwrite. The attached patch fixes related warnings when writing gmon output. I have not tested this, but it's a fairly trivial patch. Cheers, Zach Index: s

[Openocd-development] [PATCH] jim.c: fix unused return value warnings (2 of 4)

2009-04-20 Thread Zach Welch
Hi all, Ubuntu 8.10 has a newer version of the standard library that causes the compiler to issue warnings for unchecked return values for some calls. The attached patch fixes two such issues. Cheers, Zach Index: src/helper/jim.c ==

[Openocd-development] [PATCH] fix -Wformat-security warnings (1 of 4)

2009-04-20 Thread Zach Welch
Hi all, This patch fixes several warnings caused by -Wformat-security, which appears to be the default in Ubuntu 8.10. Cheers, Zach Index: src/helper/options.c === --- src/helper/options.c (revision 1478) +++ src/helper/options.c (w

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Duane Ellis
zach> [jlink problems] micheal> [jlink problems] FYI - the tap changes that I was wroking on where orginated by Jeff Williams and work with Freescale MC1322x https://lists.berlios.de/pipermail/openocd-development/2009-March/005144.html Jeff was *SPECIFICALLY* working on the Yellow Jlink unit, a

Re: [Openocd-development] [PATCH] fix at91rm9200 warning

2009-04-20 Thread Spencer Oliver
> > This patch fixes a missing initializer warning in the > at91rm9200 module. > > Cheers, committed Cheers Spen ___ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development

[Openocd-development] Patch: add non-CFI SST flashs

2009-04-20 Thread Michael Schwingen
Hi, this is the 2nd flash patch - it adds support for some non-CFI SST flashs: SST39VF320 * SST39VF1601 SST39VF1602 SST39VF3201 * SST39VF3202 (* = tested) The SST flashs have a problem: they do not support the DQ5 status bit to indicate errors, so checking that bit in cfi_spansion_wait_status_bu

[Openocd-development] [PATCH] fix at91rm9200 warning

2009-04-20 Thread Zach Welch
Hi all, This patch fixes a missing initializer warning in the at91rm9200 module. Cheers, Zach Index: src/jtag/at91rm9200.c === --- src/jtag/at91rm9200.c (revision 1477) +++ src/jtag/at91rm9200.c (working copy) @@ -104,7 +104,7 @@ s

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 22:48 +0100, Spencer Oliver wrote: [snip] > This breaks my build on cygwin, native win32 and ubuntu (intrepid). > I will try and find some time later this week to look into. I will look at Ubuntu shortly and potentially post a patch, but I can also take a stab at cygwin if yo

Re: [Openocd-development] [PATCH] treat warnings as errors

2009-04-20 Thread Spencer Oliver
> > Committed. > > Note that treating warnings as errors may well have to stay > non-default. Be prepared for a bit of flak... > > Since you're willing to address issues that are brought up > here, I'm applying the patch to see if we can navigate some > dire straits w/a few patches and then b

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Zach Welch
On Mon, 2009-04-20 at 18:56 +0200, Michael Fischer wrote: > Hello Zach, > > >* J-Link driver (w/ yellow hardware): > > - cure buggy madness (this is my own poorly qualified TODO item) > Does it works on your side? Here I have a jlink too and want to get > it working under Mac OS X. And old versio

[Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Michael Fischer
Hi magnus, >Just out of curiosity, does the test program run ? It seems strang to >load the vector table at 0x21cc You are right, there is an error in the link file, many thanks. I have not noticed it before, because I use this example to check the toolchain and the debugger. And the examp

[Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Michael Fischer
Hello Magnus, it looks that the openocd forum will not send mails out in the moment. >Just out of curiosity, does the test program run ? It seems strang to >load the vector table at 0x21cc . Vector tables are usually placed >at the beginning of memory or at an address aligned to a larger p

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Magnus Lundin
The J-Link data looks definitley messed up. It is almost as if it starts to load every linker section at 0x2000. But not quite . Perhaps an inspection of the -d3 debug log might reveal something. I dont have a J-Link so I can't test it. I did load the test-ram.elf on my STR-P711 with a ft

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Magnus Lundin
Hi Do you know if this is an OS X, gdb, J-Link or general OpenOCD problem ? What happens/does not happen when you try to download ? Regards, Magnus Michael Fischer wrote: > Hello Zach, > > >> * J-Link driver (w/ yellow hardware): >> - cure buggy madness (this is my own poorly qualified TO

[Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Michael Fischer
Hello Zach, >* J-Link driver (w/ yellow hardware): > - cure buggy madness (this is my own poorly qualified TODO item) Does it works on your side? Here I have a jlink too and want to get it working under Mac OS X. And old version, I think 717 was working with e.g. STR710, but the new SVN not anymo

Re: [Openocd-development] RFC: tap, ftdi, jlink... what else?

2009-04-20 Thread Dick Hollenbeck
Nice job Zach. Balls will not drop with a net like you around. :) > Hi all, > > Since I have been following these threads carefully for the past weeks, > I thought I would try to help organize the immediately apparent list of > tasks in a hypothetical series of patches that appear to be outstand

Re: [Openocd-development] FT2232H/FT4232H support in trunk.

2009-04-20 Thread Ben Dooks
On Mon, Apr 20, 2009 at 08:00:19AM +0200, Joern Kaipf wrote: > Hi Ben, > > Ben Dooks write: > >I looked at src/jtag/ft2232.c and didn't notice anything there > >specific to the extra features in the H parts, such as the new > >speed selections. > > > > Are there any patches / branches for support

Re: [Openocd-development] [PATCH] fix ft2232/presto warnings

2009-04-20 Thread Michael Bruck
Why not use size_t to denote object sizes? Michael On Mon, Apr 20, 2009 at 5:16 AM, Dick Hollenbeck wrote: > Zach Welch wrote: >> On Sun, 2009-04-19 at 21:25 -0500, Dick Hollenbeck wrote: >> >>> [snip] >>> Why are you changing this argument from the machine's natural size to >>> one that is 32 b

Re: [Openocd-development] [PATCH] Attempt to fix arm7_9 breakpoint handling

2009-04-20 Thread Øyvind Harboe
Committed. Thanks! I haven't tried it, but it looks to me like you've understood what's going on and have fixed a bug. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing li

Re: [Openocd-development] [PATCH] Attempt to fix arm7_9 breakpoint handling

2009-04-20 Thread Holger Freyther
On Monday 20 April 2009 09:55:14 you wrote: > Hi, > > I wasn't able to apply this patch cleanly. > > Could you submit a patch against SVN? maybe this works better Index: src/target/arm7_9_common.c === --- src/target/arm7_9_common

Re: [Openocd-development] [PATCH] Attempt to fix arm7_9 breakpoint handling

2009-04-20 Thread Øyvind Harboe
Hi, I wasn't able to apply this patch cleanly. Could you submit a patch against SVN? Thanks! -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com ___ Openocd-development mailing list Openocd-development@lis