Re: Some suggested 2.5 code cleanups/renames

2021-03-23 Thread Howard Chu
Hallvard Breien Furuseth wrote: > Hello. Hey, long time no see! > > slap_op_time(time_t *t, int *nop) could previously be called with any > 2 arg of those types.  But now it modifies nop[1], so old code other > than slap_op_time(&op->o_time, &op->o_tincr) gets a bad memory write. > > Source-code

Some suggested 2.5 code cleanups/renames

2021-03-23 Thread Hallvard Breien Furuseth
Hello. slap_op_time(time_t *t, int *nop) could previously be called with any 2 arg of those types. But now it modifies nop[1], so old code other than slap_op_time(&op->o_time, &op->o_tincr) gets a bad memory write. Source-code compat looks like a misfeature now. I'd rather rename and re-protot