Re: ITS#8866 (was: ITS review 6/14/2019)

2019-06-27 Thread Michael Ströder
On 6/27/19 6:37 PM, Howard Chu wrote: > Michael Ströder wrote: >> On 6/27/19 6:23 PM, Michael Ströder wrote: >>> On 6/27/19 6:18 PM, Howard Chu wrote: Michael Ströder wrote: > On 6/14/19 5:15 PM, Quanah Gibson-Mount wrote: >> Thanks to Ondrej, this list is a bit shorter now. :) > >

Re: ITS#8866 (was: ITS review 6/14/2019)

2019-06-27 Thread Howard Chu
Michael Ströder wrote: > On 6/27/19 6:23 PM, Michael Ströder wrote: >> On 6/27/19 6:18 PM, Howard Chu wrote: >>> Michael Ströder wrote: On 6/14/19 5:15 PM, Quanah Gibson-Mount wrote: > Thanks to Ondrej, this list is a bit shorter now. :) But one more I'd love to see in 2.4.48: >>

Re: ITS#8866 (was: ITS review 6/14/2019)

2019-06-27 Thread Michael Ströder
On 6/27/19 6:23 PM, Michael Ströder wrote: > On 6/27/19 6:18 PM, Howard Chu wrote: >> Michael Ströder wrote: >>> On 6/14/19 5:15 PM, Quanah Gibson-Mount wrote: Thanks to Ondrej, this list is a bit shorter now. :) >>> >>> But one more I'd love to see in 2.4.48: >>> >>> ITS#8866: RFE: slapo-cons

Re: ITS#8866 (was: ITS review 6/14/2019)

2019-06-27 Thread Michael Ströder
On 6/27/19 6:18 PM, Howard Chu wrote: > Michael Ströder wrote: >> On 6/14/19 5:15 PM, Quanah Gibson-Mount wrote: >>> Thanks to Ondrej, this list is a bit shorter now. :) >> >> But one more I'd love to see in 2.4.48: >> >> ITS#8866: RFE: slapo-constraint to return filter used in diagnostic message >

Re: ITS#8866 (was: ITS review 6/14/2019)

2019-06-27 Thread Howard Chu
Michael Ströder wrote: > On 6/14/19 5:15 PM, Quanah Gibson-Mount wrote: >> Thanks to Ondrej, this list is a bit shorter now. :) > > But one more I'd love to see in 2.4.48: > > ITS#8866: RFE: slapo-constraint to return filter used in diagnostic message > > https://www.openldap.org/its/index.cgi?f

ITS#8866 (was: ITS review 6/14/2019)

2019-06-22 Thread Michael Ströder
On 6/14/19 5:15 PM, Quanah Gibson-Mount wrote: > Thanks to Ondrej, this list is a bit shorter now. :) But one more I'd love to see in 2.4.48: ITS#8866: RFE: slapo-constraint to return filter used in diagnostic message https://www.openldap.org/its/index.cgi?findid=8866 I have a back-port patch f

Re: ITS review 6/14/2019

2019-06-17 Thread Howard Chu
Quanah Gibson-Mount wrote: > --On Monday, June 17, 2019 2:23 PM +0100 Howard Chu wrote: > >>> The following ITSes have a patch or have been committed already. >>> --- >>> >>> ITS#7721 - contrib/lastbind - allow authtimestamp forwardi

Re: ITS review 6/14/2019

2019-06-17 Thread Quanah Gibson-Mount
--On Monday, June 17, 2019 2:23 PM +0100 Howard Chu wrote: The following ITSes have a patch or have been committed already. --- ITS#7721 - contrib/lastbind - allow authtimestamp forwarding with updateref (44e9bda0e42f40e0baf0a2c0e

Re: ITS review 6/14/2019

2019-06-17 Thread Howard Chu
Quanah Gibson-Mount wrote: > Thanks to Ondrej, this list is a bit shorter now. :) > > > The following ITSes have a patch or have been committed already. > --- > > ITS#7721 - contrib/lastbind - allow authtimestamp forwarding with upd

ITS review 6/14/2019

2019-06-14 Thread Quanah Gibson-Mount
Thanks to Ondrej, this list is a bit shorter now. :) The following ITSes have a patch or have been committed already. --- ITS#7721 - contrib/lastbind - allow authtimestamp forwarding with updateref (44e9bda0e42f40e0baf0a2c0ef733eb

Re: ITS review 6/4/2019

2019-06-13 Thread Quanah Gibson-Mount
--On Thursday, June 13, 2019 7:47 PM +0200 Ondřej Kuzník wrote: ITS#9001 - libraries/libldap - Use new Tavl bits to reduce search time (has patch, IPR OK) This one isn't ready yet, might not belong to 2.4 anyway, also pending answer on https://www.openldap.org/lists/openldap-devel/20190

Re: ITS review 6/4/2019

2019-06-13 Thread Ondřej Kuzník
On Tue, Jun 04, 2019 at 02:05:13PM -0700, Quanah Gibson-Mount wrote: > All of the following have patches and need review/approval. Any with I > consider desired for the next releases of LMDB & OpenLDAP: For the ones I had a look at this week (others are written by me or wasn't sure): > LMDB

Re: ITS review 6/4/2019

2019-06-05 Thread Clément OUDOT
Hello, this issue is also opened and could be easy to fix: http://www.openldap.org/its/index.cgi?findid=9000 We can provide a patch but I would like therefore your point of view about the proposed solution (removing old value before adding the new one). -- Clément Oudot | Identity Solutions Man

ITS review 6/4/2019

2019-06-04 Thread Quanah Gibson-Mount
All of the following have patches and need review/approval. Any with I consider desired for the next releases of LMDB & OpenLDAP: LMDB related ITSes -- ITS#8986 - Fix LMDB for FreeBSD12 (has patch, IPR OK) ITS#8739 - liblmdb - Fixes fsync check on FreeBSD (has patc

Re: ITS review 4/17/2019

2019-04-19 Thread Quanah Gibson-Mount
--On Wednesday, April 17, 2019 5:16 PM -0700 Quanah Gibson-Mount wrote: Some of these items are RE24 + master, a couple are master only. Some are for LMDB, not sure if they should be 0.9+master or master only. --- The following

ITS review 4/17/2019

2019-04-17 Thread Quanah Gibson-Mount
Some of these items are RE24 + master, a couple are master only. Some are for LMDB, not sure if they should be 0.9+master or master only. --- The following ITSes have a patch or have been committed already. ---

Re: ITS review

2019-03-12 Thread Michael Ströder
On 1/31/19 3:50 AM, Quanah Gibson-Mount wrote: > There have been some reports coming in to the ITS system that likely > should go into OpenLDAP 2.4.48/LMDB 0.9.23. I know feature requests are not welcome. But it would help to have this in RE24: ITS#7770 - mdb_stat in cn=monitor Ciao, Michael.

Re: ITS review

2019-02-06 Thread Howard Chu
Clément OUDOT wrote: > > > Le 03/02/2019 à 14:30, Clément OUDOT a écrit : >> Hello, >> >> I faced a regression with the fix of >> http://www.openldap.org/its/index.cgi/Software%20Bugs?id=8840 in 2.4.47, >> the script of one of my customer is now failing with: >> >> Feb  1 06:30:21 deimos slapd[12

Re: ITS review

2019-02-06 Thread Clément OUDOT
Le 03/02/2019 à 14:30, Clément OUDOT a écrit : > Hello, > > I faced a regression with the fix of > http://www.openldap.org/its/index.cgi/Software%20Bugs?id=8840 in 2.4.47, > the script of one of my customer is now failing with: > > Feb  1 06:30:21 deimos slapd[12751]: conn=324820 op=2 SEARCH RES

Re: ITS review

2019-02-03 Thread Clément OUDOT
Hello, I faced a regression with the fix of http://www.openldap.org/its/index.cgi/Software%20Bugs?id=8840 in 2.4.47, the script of one of my customer is now failing with: Feb  1 06:30:21 deimos slapd[12751]: conn=324820 op=2 SEARCH RESULT tag=101 err=2 nentries=0 text=domainScope control value no

Re: ITS review

2019-02-02 Thread Michael Ströder
On 1/31/19 3:50 AM, Quanah Gibson-Mount wrote: There have been some reports coming in to the ITS system that likely should go into OpenLDAP 2.4.48/LMDB 0.9.23. Probably this should also be added: (ITS#8971) slapo-accesslog hits assert​ Ciao, Michael. smime.p7s Description: S/MIME Cryptogra

Re: ITS review

2019-01-31 Thread Quanah Gibson-Mount
Done. Looks like just ITS#8967 remains from this list. I forgot yesterday to add ITS#8875 to this list, but that also needs some attention I think. --Quanah --On Thursday, January 31, 2019 11:04 PM + Howard Chu wrote: Quanah Gibson-Mount wrote: There have been some reports coming i

Re: ITS review

2019-01-31 Thread Howard Chu
Quanah Gibson-Mount wrote: > There have been some reports coming in to the ITS system that likely should > go into OpenLDAP 2.4.48/LMDB 0.9.23.  These are: > > ITS#8969 - Tweak to LMDB page splits (already committed to LMDB RE0.9) > > ITS#8968 - ASYNC connect mode does not work on Solaris > (

ITS review

2019-01-30 Thread Quanah Gibson-Mount
There have been some reports coming in to the ITS system that likely should go into OpenLDAP 2.4.48/LMDB 0.9.23. These are: ITS#8969 - Tweak to LMDB page splits (already committed to LMDB RE0.9) ITS#8968 - ASYNC connect mode does not work on Solaris (

Re: ITS review 9/29/2017

2017-10-11 Thread Quanah Gibson-Mount
--On Thursday, October 12, 2017 1:03 AM +0200 Michael Ströder wrote: Quanah Gibson-Mount wrote: --- Purely for RE25: --- What about ITS#8714? RFE: Sendout EXTENDED operation message in back-sock This is already in master. Anything currently in mast

Re: ITS review 9/29/2017

2017-10-11 Thread Michael Ströder
Quanah Gibson-Mount wrote: > --On Friday, October 06, 2017 5:43 PM -0700 Quanah Gibson-Mount > wrote: > >>> This is debatable: >>> >>> 1. OpenLDAP 2.4.x accepts modify operations with LDAP_MOD_INCREMENT >>> >>> 2. OpenLDAP 2.4.x sends modify operations via back-sock to external >>> listeners >>>

Re: ITS review 9/29/2017

2017-10-11 Thread Michael Ströder
Quanah Gibson-Mount wrote: > --- > Purely for RE25: > --- What about ITS#8714? RFE: Sendout EXTENDED operation message in back-sock Could this make it into RE25? Another one which really strikes me: (ITS#7796) LDAP_DEBUG_TRACE for "not indexed" log message

Re: ITS review 9/29/2017

2017-10-11 Thread Quanah Gibson-Mount
--On Friday, October 06, 2017 5:43 PM -0700 Quanah Gibson-Mount wrote: This is debatable: 1. OpenLDAP 2.4.x accepts modify operations with LDAP_MOD_INCREMENT 2. OpenLDAP 2.4.x sends modify operations via back-sock to external listeners Therefore I'd consider this rather a fix than a new fea

Re: ITS review 9/29/2017

2017-10-06 Thread Hallvard Breien Furuseth
On 06/10/17 23:24, Quanah Gibson-Mount wrote: --On Friday, October 06, 2017 10:16 PM +0100 Howard Chu wrote: its7442 - Add debug statements when index_intlen values are out of range Looks pointless. Well, the man page is not clear

Re: ITS review 9/29/2017

2017-10-06 Thread Quanah Gibson-Mount
--On Saturday, October 07, 2017 1:13 AM +0200 Michael Ströder wrote: Quanah Gibson-Mount wrote: its8692 - Support LDAP_MOD_INCREMENT with back-sock Why is this super-trivial patch postponed to RE25? It's a new feature. This is de

Re: ITS review 9/29/2017

2017-10-06 Thread Michael Ströder
Quanah Gibson-Mount wrote: >>> its8692 - Support LDAP_MOD_INCREMENT with back-sock >>> >> >> Why is this super-trivial patch postponed to RE25? > > It's a new feature. This is debatable: 1. OpenLDAP 2.4.x accepts modify operations with LD

Re: ITS review 9/29/2017

2017-10-06 Thread Quanah Gibson-Mount
--On Friday, October 06, 2017 10:16 PM +0100 Howard Chu wrote: its7442 - Add debug statements when index_intlen values are out of range Looks pointless. Well, the man page is not clear on this point. I'm fine dropping the debug st

Re: ITS review 9/29/2017

2017-10-06 Thread Howard Chu
Quanah Gibson-Mount wrote: --On Friday, October 06, 2017 2:27 PM +0100 Howard Chu wrote: Quanah Gibson-Mount wrote: Suggested for RE24: --- its7389 - Fix MozNSS to fallback to PEM if cert not found in certdb (RE24 ONLY)

Re: ITS review 9/29/2017

2017-10-06 Thread Quanah Gibson-Mount
--On Friday, October 06, 2017 2:27 PM +0100 Howard Chu wrote: Quanah Gibson-Mount wrote: Suggested for RE24: --- its7389 - Fix MozNSS to fallback to PEM if cert not found in certdb (RE24 ONLY) Questionable, si

Re: ITS review 9/29/2017

2017-10-06 Thread Quanah Gibson-Mount
--On Saturday, September 30, 2017 11:42 AM +0200 Michael Ströder wrote: Quanah Gibson-Mount wrote: --- Purely for RE25: --- its8692 - Support LDAP_MOD_INCREMENT with back-sock Why is this supe

Re: ITS review 9/29/2017

2017-10-06 Thread Howard Chu
Quanah Gibson-Mount wrote: Howard -- Looking for a thumbs up/down on these. The following ITSes were mostly supplied with patches and are IPR ok. I've imported them into my openldap-scratch repo for easy review. If they didn't have a supplied patch, I did the related work. Branch names are

Re: ITS review 9/29/2017

2017-09-30 Thread Michael Ströder
Quanah Gibson-Mount wrote: > --- > Purely for RE25: > --- > > its8692 - Support LDAP_MOD_INCREMENT with back-sock > Why is this super-trivial patch postponed to RE25? Ciao, Michael. smime.p7s Des

ITS review 9/29/2017

2017-09-29 Thread Quanah Gibson-Mount
Howard -- Looking for a thumbs up/down on these. The following ITSes were mostly supplied with patches and are IPR ok. I've imported them into my openldap-scratch repo for easy review. If they didn't have a supplied patch, I did the related work. Branch names are by ITS. -

Re: ITS review 9/12/2017

2017-09-20 Thread Ryan Tandy
For RE25, possibly (but unlikely) RE24: its6035 - slapd requires restart after modifying olcAuthzRegexp

Re: ITS review 9/12/2017

2017-09-19 Thread Michael Ströder
Quanah Gibson-Mount wrote: --On Monday, September 18, 2017 10:29 PM +0200 Michael Ströder wrote: ITS#8051: 2fbecdd756a288c787d8326d6630ab8500058e2f 129299a9337287527f2046fe5385cdb2afb35f0b Ah, it seems to be complete. IMO this would also be an interesting candiate for RE24. If you port it to

Re: ITS review 9/12/2017

2017-09-18 Thread Quanah Gibson-Mount
--On Monday, September 18, 2017 10:29 PM +0200 Michael Ströder wrote: ITS#8051: 2fbecdd756a288c787d8326d6630ab8500058e2f 129299a9337287527f2046fe5385cdb2afb35f0b Ah, it seems to be complete. IMO this would also be an interesting candiate for RE24. If you port it to RE24 I will test it. The

Re: ITS review 9/12/2017

2017-09-18 Thread Michael Ströder
Quanah Gibson-Mount wrote: --On Wednesday, September 13, 2017 9:50 AM +0200 Michael Ströder wrote: There is also a 'sockdnpat' config directive in git-master. But it seems only the config. This would be very helpful for my deployments. I don't know which ITS though. ITS#8051: 2fbecdd756a288c7

Re: ITS review 9/12/2017

2017-09-18 Thread Quanah Gibson-Mount
--On Wednesday, September 13, 2017 9:50 AM +0200 Michael Ströder wrote: Quanah Gibson-Mount wrote: --- Suggested for RE25, possibly RE24: [..] its8692 - Support LDAP_MOD_INCREMENT with back-sock Yes, please. It w

Re: ITS review 9/12/2017

2017-09-12 Thread Michael Ströder
Quanah Gibson-Mount wrote: --- Suggested for RE25, possibly RE24: [..] its8692 - Support LDAP_MOD_INCREMENT with back-sock Yes, please. It would be also helpful if this could land in RE24: (ITS#8714) RFE: Sendout EX

ITS review 9/12/2017

2017-09-12 Thread Quanah Gibson-Mount
The following ITSes were mostly supplied with patches and are IPR ok. I've imported them into my openldap-scratch repo for easy review. If they didn't have a supplied patch, I did the related work. Branch names are by ITS. --- Suggested for RE24: its5048 - Fix documenta