RFR: 8298167: Opacity in WebView not working anymore

2023-01-10 Thread Roman Marchenko
There was refactoring in WebKit's GraphicsContext class (nativecode) https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't adapted after GraphicsContext's refactoring integration into JFX. As t

Re: RFR: 8298167: Opacity in WebView not working anymore [v2]

2023-01-10 Thread Roman Marchenko
Context's refactoring integration into JFX. As the > result, the methods were not invoked, so TransparencyLayer couldn't be added > to a rendering queue. > > Now the methods are fixed to be used properly in GraphicsContext inheritance > chain. Roman Marchenko has updated

Re: RFR: 8298167: Opacity in WebView not working anymore

2023-01-10 Thread Roman Marchenko
On Wed, 11 Jan 2023 07:32:20 GMT, Roman Marchenko wrote: > There was refactoring in WebKit's GraphicsContext class (nativecode) > https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 > > > GraphicsContextJava's methods begin/endPlatformT

Re: RFR: 8298167: Opacity in WebView not working anymore

2023-01-11 Thread Roman Marchenko
On Wed, 11 Jan 2023 07:49:50 GMT, Roman Marchenko wrote: >> There was refactoring in WebKit's GraphicsContext class (nativecode) >> https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 >> >> >> GraphicsContextJava's met

Re: RFR: 8298167: Opacity in WebView not working anymore [v3]

2023-01-11 Thread Roman Marchenko
Context's refactoring integration into JFX. As the > result, the methods were not invoked, so TransparencyLayer couldn't be added > to a rendering queue. > > Now the methods are fixed to be used properly in GraphicsContext inheritance > chain. Roman Marchenko has updated

Re: RFR: 8298167: Opacity in WebView not working anymore [v2]

2023-01-11 Thread Roman Marchenko
On Wed, 11 Jan 2023 16:24:04 GMT, Kevin Rushforth wrote: >> Roman Marchenko has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> Fixed the opacity issue > > I might add it elsewhe

Re: RFR: 8298167: Opacity in WebView not working anymore [v4]

2023-01-11 Thread Roman Marchenko
Context's refactoring integration into JFX. As the > result, the methods were not invoked, so TransparencyLayer couldn't be added > to a rendering queue. > > Now the methods are fixed to be used properly in GraphicsContext inheritance > chain. Roman Marchenko has updated

Re: RFR: 8298167: Opacity in WebView not working anymore [v5]

2023-01-11 Thread Roman Marchenko
Context's refactoring integration into JFX. As the > result, the methods were not invoked, so TransparencyLayer couldn't be added > to a rendering queue. > > Now the methods are fixed to be used properly in GraphicsContext inheritance > chain. Roman Marchenko has updated

Integrated: 8298167: Opacity in WebView not working anymore

2023-01-12 Thread Roman Marchenko
On Wed, 11 Jan 2023 07:32:20 GMT, Roman Marchenko wrote: > There was refactoring in WebKit's GraphicsContext class (nativecode) > https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 > > > GraphicsContextJava's methods begin/endPlatformT

RFR: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit

2025-04-08 Thread Roman Marchenko
All the crashes are on "`movaps`" instructions, like "`movaps xmmword ptr [esi+0x30], xmm0`". "`movaps`" must operate with aligned addresses as > When the source or destination operand is a memory operand, the operand must > be aligned on a 16-byte boundary or a general-protection exception (#G

Re: RFR: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit [v2]

2025-04-08 Thread Roman Marchenko
dress 0x`" from `hs_err` file > implicitly says it is GP, not a real "reading address 0x". > > It might be related to clang-cl bug, see > https://github.com/llvm/llvm-project/issues/55844 > > The workaround is to disable SSE when building 32bit on Windo

Re: RFR: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit [v2]

2025-04-08 Thread Roman Marchenko
On Tue, 8 Apr 2025 15:49:44 GMT, Roman Marchenko wrote: >> All the crashes are on "`movaps`" instructions, like "`movaps xmmword ptr >> [esi+0x30], xmm0`". >> >> "`movaps`" must operate with aligned addresses as >>> When the

Integrated: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit

2025-04-08 Thread Roman Marchenko
On Tue, 8 Apr 2025 07:48:19 GMT, Roman Marchenko wrote: > All the crashes are on "`movaps`" instructions, like "`movaps xmmword ptr > [esi+0x30], xmm0`". > > "`movaps`" must operate with aligned addresses as >> When the source or destinati