Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-06-24 Thread Michael Strauß
On Tue, 24 Jun 2025 08:16:48 GMT, Cormac Redmond wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix resizable state of macOS window > > I have found another bug/issue, which is again related to wrapping a root

Re: HeaderBar (preview) clipped out of window during resize

2025-06-24 Thread Michael Strauß
We had a brief discussion back in October 2024 whether HeaderBar should be a normal layout container in the scene graph, or whether it should live somewhere else (for example something like Scene.setHeaderBar(), analogous to Scene.setRoot()). It became clear that we wanted HeaderBar to be a part of

Re: RFR: 8359108: Mac - When Swing starts First, native application menu doesn't work for JavaFX

2025-06-24 Thread Martin Fox
On Wed, 18 Jun 2025 20:58:20 GMT, Pabulaner IV wrote: > This pull request fixes the system menu bar on Mac when combining windows of > Swing and JavaFX. > > The first issue was to get the native menu bar working simultaneously on > Swing and JavaFX, which was done by just returning always true

Re: RFR: 8324941: POC for Headless platform for JavaFX [v4]

2025-06-24 Thread Marius Hanl
On Mon, 23 Jun 2025 08:26:30 GMT, Johan Vos wrote: >> After spending a year in the sandbox repository, the Headless Platform is >> now ready to be reviewed in the main repository. >> >> ### the Headless Platform >> The Headless Platform is a top-level com.sun.glass.ui platform that replaces >>

Re: HeaderBar (preview) clipped out of window during resize

2025-06-24 Thread Cormac Redmond
Thanks for the background info, Michael -- also, my knowledge of basic JavaFX layout is surprisingly abysmal (compared to other areas), I didn't expect it could be fixed as easily like that (or without affecting *other* nodes or something negatively). I would consider this a ControlsFx bug based o

HeaderBar (preview) clipped out of window during resize

2025-06-24 Thread Cormac Redmond
Hi, I have found an "issue" (open to debate) where the HeaderBar's nodes are pushed out of view. This issue is easily reproduced by wrapping a scene's root node in a StackPane (something that is common for ControlsFx to do, as an example, & without the developer even being aware -- I suspect other

Re: RFR: 8271024: Implement macOS Metal Rendering Pipeline [v3]

2025-06-24 Thread Joeri Sykora
On Mon, 23 Jun 2025 11:01:59 GMT, Ambarish Rapte wrote: >> ### Description >> This is the implementation of new graphics rendering pipeline for JavaFX >> using Metal APIs on MacOS. >> We released two Early Access (EA) builds and have reached a stage where it >> is ready to be integrated. >> Def

Re: RFR: 8353599: TabPaneSkin: add 'menuGraphicFactory' property [v4]

2025-06-24 Thread Andy Goryachev
> Tries to address the mystery of missing graphic in the TabPane overflow menu. > > ### Summary of Changes > > - minor `TabPaneSkin` constructor javadoc clarification > - added the property > - changed popup menu to be created on demand > - removing adding the popup reference to the `TabHeaderSki

Support for new blend modes: CLEAR, ALPHA_MAX

2025-06-24 Thread John Hendrikx
I've been doing some Canvas work to implement a simple image editing system, and I noticed that some things are quite hard to do due to a lack of certain blend modes. 1) Given an empty fully transparent Canvas, you can easily draw opaque ovals onto it (using a circular brush) but cannot use `fillO

Re: Support for new blend modes: CLEAR, ALPHA_MAX

2025-06-24 Thread Michael Strauß
The CLEAR blend mode seems to be an obvious addition. The case for ALPHA_MAX is a bit more difficult to justify, as it seems like a special-purpose mode. You need this particular blend mode, but the next developer might need COLOR_DODGE_WITH_ALPHA_MAX or LIGHTEN_WITH_ALPHA_ATOP. Maybe we can prev

Re: RFR: 8359601: Fix window button states of an extended stage [v6]

2025-06-24 Thread Cormac Redmond
On Sat, 21 Jun 2025 23:37:13 GMT, Michael Strauß wrote: >> The window button states (disabled/hidden) of extended stages with a >> `HeaderButtonOverlay` or custom header buttons are inconsistent with what we >> would expect from the OS (Windows and Linux). To figure out what we would >> expect

Aw: Proposal: Bump minimum JDK for JavaFX 25 to JDK 23 (more generally, set min for JavaFX N to JDK N-2)

2025-06-24 Thread Marius Hanl
+1, good idea.Moving from JDK 22 to JDK 23 seems pretty unproblematic, so I think most people out there should not have a problem with that either.Also +1 for the idea of setting the minimum version to JDK N-2 in the future.- MariusAm 17.06.25, 17:49 schrieb Kevin Rushforth oracle.com>: All, Even