Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Kevin Rushforth
On Wed, 9 Apr 2025 19:17:33 GMT, Michael Strauß wrote: > > https://github.com/openjdk/jfx/pull/1766/checks?check_run_id=40273913986 > > this is a weird failure, I've never seen it before. something happened at > > cygwin (after yesterday outage) perhaps? > > @mstr2 could you re-run the windows j

Re: RFR: 8340464: [TestBug] Convert parametrized base tests to JUnit 5 [v8]

2025-04-09 Thread Andy Goryachev
On Mon, 7 Apr 2025 12:26:33 GMT, Jay Bhaskar wrote: >> Migrated JUnit 4 tests in the jafax.base module to JUnit 5, replacing >> deprecated APIs, updating assertions, and refactoring test structures to >> align with JUnit 5's improved features. > > Jay Bhaskar has updated the pull request increm

Integrated: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE

2025-04-09 Thread Michael Strauß
On Wed, 9 Apr 2025 07:06:29 GMT, Michael Strauß wrote: > Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. This pull request has now been integrated. Changeset: 9ac707da Author:Michael Strauß URL: https://git.openjdk.org/jfx/commit/9ac

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread Thiago Milczarek Sayão
Thank you all for the feedback. I believe the documentation for the Stage class could benefit from additional clarification. I will draft some suggestions and submit them for review. -- Thiago Em qua., 9 de abr. de 2025 às 12:28, Martin Fox escreveu: > On macOS 15.3.2 I get the same results as

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null Ch

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 18:27:12 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - hashSet.equ

[jfx24u] RFR: 8354182: Create release notes for JavaFX 24.0.1

2025-04-09 Thread Kevin Rushforth
Release notes for JavaFX 24.0.1. Notes to reviewers: I used the following filter to pick the issues: https://bugs.openjdk.org/issues/?filter=47358 The original filter, with the backport IDs, is here: https://bugs.openjdk.org/issues/?filter=47357 As usual, I excluded test bugs, cleanup bugs, e

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread Andy Goryachev
I've got Mac with one (or possibly two) external monitors. I'll test and report later today. -andy From: openjfx-dev on behalf of Thiago Milczarek Sayão Date: Wednesday, April 9, 2025 at 03:56 To: openjfx-dev Subject: Help test the behavior of a multi-screen setup with both Mac and Window

Integrated: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test

2025-04-09 Thread Lukasz Kostyra
On Fri, 4 Apr 2025 11:30:04 GMT, Lukasz Kostyra wrote: > This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done > changes to Popup public API. > > Popup used to have an `owner` and `parentWindow` properties. I couldn't track > how far back that change happened so I can't ful

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v3]

2025-04-09 Thread Lukasz Kostyra
On Wed, 9 Apr 2025 08:18:56 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

[jfx24u] Integrated: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit

2025-04-09 Thread Jay Bhaskar
On Wed, 9 Apr 2025 12:02:20 GMT, Jay Bhaskar wrote: > A clean backport to jfx24u. The patch fixes startup issue of javafx web > application on window i586 machine. This pull request has now been integrated. Changeset: d0a61f4b Author:Jay Bhaskar URL: https://git.openjdk.org/jfx24u

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread John Hendrikx
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null Lo

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 09:07:40 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > obj == null th

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread John Hendrikx
On Wed, 9 Apr 2025 18:27:12 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - hashSet.equ

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v3]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 08:18:56 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread Andy Goryachev
Here are the results on macOS 15.3.2, with the primary (retina, scale=2) at the bottom and the external (scale=1) at the top like so [cid:image001.png@01DBA925.BCAC1580] In both cases, the first button (Move To 1800.0) moves the window to the same screen partially outside of the viewing area (o

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Andy Goryachev
On Wed, 9 Apr 2025 18:27:12 GMT, Michael Strauß wrote: >> Fixes the bug that `BitSet.equals(null)` throws NPE. >> >> A single reviewer should be sufficient. > > Michael Strauß has updated the pull request incrementally with three > additional commits since the last revision: > > - hashSet.equ

Re: [External] : Re: TabPane overflow menu showing blanks

2025-04-09 Thread Andy Goryachev
No problem, Cormac, and thank you for suggestions! I guess you will be volunteering for the code review? (No promises as to when this feature will be available though). Speaking of the disabling the overflow menu: this may not be a good idea from the accessibility perspective, but the idea of

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v3]

2025-04-09 Thread Michael Strauß
> Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. Michael Strauß has updated the pull request incrementally with three additional commits since the last revision: - hashSet.equals(bitSet) - review comments - review comments - Cha

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread John Hendrikx
On Windows it is not restricted AFAIK, moving a screen anywhere is allowed, and one can also drag windows beyond those limits.  When a monitor is added/removed Windows may however decide to reshuffle all your Windows (or randomly if a monitor is slow to respond when waking from sleep) to ensure the

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread Thiago Milczarek Sayão
Odd in the sense it's unrestrictive to the bounds. It shouldn't be allowed in a TopLevel taskbar shown window at least, but that's my opinion. But it's windows being windows. They value compatibility and that's probably an old behaviour that some apps depend on. Gnome being gnome has a lot of restr

Re: RFR: 8353916: Unexpected event type for DOM mutation events with WebKit 620.1

2025-04-09 Thread Ambarish Rapte
On Tue, 8 Apr 2025 11:50:05 GMT, Jay Bhaskar wrote: > Issue: In WebKit 619.1, MutationEvent was properly handled and overridden, so > casting to it worked as expected. In newer WebKit versions (like the one > embedded in current JavaFX), MutationEvent is deprecated, and the actual > event disp

[jfx24u] RFR: 8353916: Unexpected event type for DOM mutation events with WebKit 620.1

2025-04-09 Thread Jay Bhaskar
A clean backport to jfx24u , the patch fixes the mutation event typecast issue the change for supportig old style mutation event type. - Commit messages: - Backport dc115d5862894953fb27c1f209b2d81d3694db70 Changes: https://git.openjdk.org/jfx24u/pull/17/files Webrev: https://webr

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE

2025-04-09 Thread Nir Lisker
On Wed, 9 Apr 2025 07:06:29 GMT, Michael Strauß wrote: > Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 536: > 534: return true; > 535: } > 536:

Re: RFR: 8207333: [Linux, macOS] Column sorting is triggered always after context menu request on table header

2025-04-09 Thread Jose Pereda
On Tue, 8 Apr 2025 23:22:18 GMT, Martin Fox wrote: >> Can you try the monkey tester? it allows setting properties on the table >> view / table column at runtime... > > I just verified that on Linux the released event usually goes to the popup > window. Basically it's whatever window is under t

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Michael Strauß
> Fixes the bug that `BitSet.equals(null)` throws NPE. > > A single reviewer should be sufficient. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: obj == null - Changes: - all: https://git.openjdk.org/jfx/pull/1766/

Re: RFR: 8353845: com.sun.javafx.css.BitSet.equals(null) throws NPE [v2]

2025-04-09 Thread Michael Strauß
On Wed, 9 Apr 2025 08:59:37 GMT, Nir Lisker wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> obj == null > > modules/javafx.graphics/src/test/java/test/com/sun/javafx/css/BitSetTest.java > line 50: > >> 48:

Integrated: 8353916: Unexpected event type for DOM mutation events with WebKit 620.1

2025-04-09 Thread Jay Bhaskar
On Tue, 8 Apr 2025 11:50:05 GMT, Jay Bhaskar wrote: > Issue: In WebKit 619.1, MutationEvent was properly handled and overridden, so > casting to it worked as expected. In newer WebKit versions (like the one > embedded in current JavaFX), MutationEvent is deprecated, and the actual > event disp

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v3]

2025-04-09 Thread Ambarish Rapte
On Wed, 9 Apr 2025 08:18:56 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v3]

2025-04-09 Thread Lukasz Kostyra
> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done > changes to Popup public API. > > Popup used to have an `owner` and `parentWindow` properties. I couldn't track > how far back that change happened so I can't fully say what these Properties > actually were, but to my

Re: RFR: 8313424: JavaFX controls in the title bar [v62]

2025-04-09 Thread Michael Strauß
> Implementation of > [`StageStyle.EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09). Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: Remove StageStyle.EXTENDED_UTILITY - Changes: - all: htt

Re: RFR: 8234153: [TEST_BUG] Rewrite Popup_parentWindow_Test [v2]

2025-04-09 Thread Ambarish Rapte
On Mon, 7 Apr 2025 08:09:32 GMT, Lukasz Kostyra wrote: >> This change rewrites `Popup_parentWindow_Test` after a-long-time-ago-done >> changes to Popup public API. >> >> Popup used to have an `owner` and `parentWindow` properties. I couldn't >> track how far back that change happened so I can'

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread John Hendrikx
Small addition; the 3520 button moved the top left of the Window to the middle of the right screen, but the window as a whole was not centered. --John On 09/04/2025 13:22, John Hendrikx wrote: > > Hi Thiago, > > I ran this on Windows.  My monitor setup is: > > Left: 3840x2160 (150%) -- top left c

Re: Help test the behavior of a multi-screen setup with both Mac and Windows

2025-04-09 Thread Nir Lisker
I followed John's 'peek' addition. I have 2 monitors, the second one has a 125% magnification. Windows 10. Rectangle2D [minX=0.0, minY=0.0, maxX=1920.0, maxY=1080.0, width=1920.0, height=1080.0] Rectangle2D [minX=1920.0, minY=0.0, maxX=3456.0, maxY=864.0, width=1536.0, height=864.0] The buttons

[jfx24u] Integrated: 8353916: Unexpected event type for DOM mutation events with WebKit 620.1

2025-04-09 Thread Jay Bhaskar
On Wed, 9 Apr 2025 08:50:29 GMT, Jay Bhaskar wrote: > A clean backport to jfx24u , the patch fixes the mutation event typecast > issue the change for supportig old style mutation event type. This pull request has now been integrated. Changeset: 1228ee6b Author:Jay Bhaskar URL: http

[jfx24u] RFR: 8350284: WebKit 620.1 crashes on startup on Windows x86 32-bit

2025-04-09 Thread Jay Bhaskar
A clean backport to jfx24u. The patch fixes startup issue of javafx web application on window i586 machine. - Commit messages: - Backport d31f764b565cafdb6cafe88a9676ffba8cb7cdbb Changes: https://git.openjdk.org/jfx24u/pull/18/files Webrev: https://webrevs.openjdk.org/?repo=jfx2