On Sat, 29 Mar 2025 07:10:22 GMT, Michael Strauß wrote:
>> I agree: this change is out of scope for this PR.
>
> I suggest to remove the comment and file a JBS ticket.
Comment removed then
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1742#discussion_r2019758060
> This PR will forward more Label calculations to LabeledSkinBase, as they are
> quite complex, especially when a Graphic is involved which is a full-fledged
> `Node`. More specifically, this solves issues with TitledPane when the
> graphic is resizable (ie. an HBox is placed as Graphic in the t
On Sat, 29 Mar 2025 09:10:51 GMT, John Hendrikx wrote:
>> This PR will forward more Label calculations to LabeledSkinBase, as they are
>> quite complex, especially when a Graphic is involved which is a full-fledged
>> `Node`. More specifically, this solves issues with TitledPane when the
>> gr
On Sat, 29 Mar 2025 07:08:40 GMT, Michael Strauß wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TitledPaneSkin.java
> line 394:
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to
> skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009
> is fixed.
I'm a bit worried with disabling the test, as there is no guarantee the
When a window is maximized, if only the width or height is programmatically
set, the window will retain its current maximized dimension (either height or
width) as is, unless the other dimension is also explicitly set.
This is consistent with what Gtk does.
-
Commit messages:
- Re
On Sat, 29 Mar 2025 12:17:29 GMT, Thiago Milczarek Sayao
wrote:
> When a window is maximized, if only the width or height is programmatically
> set, the window will retain its current maximized dimension (either height or
> width) as is, unless the other dimension is also explicitly set.
>
>
@Christopher Schnick
Hi, did you open a bug? I have a fix for this.
Thanks
-- Thiago.
Em seg., 17 de mar. de 2025 às 09:49, Christopher Schnick <
crschn...@xpipe.io> escreveu:
> So on Windows at least, it will change the width temporarily and then
> revert back to the original width value. So
Thanks, yeah I did not submit an issue there because I don't like the
bug report website form. But that is another story.
I looked at the PR, seems to be pretty straightforward. Thinking about
this, I have not tested how it behaves with the fullscreen property
instead of the maximized property
On Sat, 29 Mar 2025 12:17:29 GMT, Thiago Milczarek Sayao
wrote:
> When a window is maximized, if only the width or height is programmatically
> set, the window will retain its current maximized dimension (either height or
> width) as is, unless the other dimension is also explicitly set.
>
>
I did not find a bug report, so I did one and provided a fix:
https://github.com/openjdk/jfx/pull/1748
Em sáb., 29 de mar. de 2025 às 08:26, Thiago Milczarek Sayão <
thiago.sa...@gmail.com> escreveu:
> @Christopher Schnick
>
> Hi, did you open a bug? I have a fix for this.
>
> Thanks
>
> -- T
11 matches
Mail list logo
