Hi John,
Many thanks for the feedback and the confirmation, much appreciated!
As for the question "when can we switch?" -> aha, great question. I believe
the major todo is to make sure that this approach is maintainable, without
putting a burden on the openjkd/jdk development, making sure it does
SwingNodePlatformExitCrashTest hangs while running on wayland, we need to skip
this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009 is fixed.
-
Commit messages:
- 8353163: [XWayland] Disable SwingNodePlatformExitCrashTest on wayland
Changes: https://git.openjdk.or
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote:
>> Allows MenuBar to be created in a background thread by delaying
>> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the
>> scene graph.
>
> Andy Goryachev has updated the pull request with a new target base due to
On Fri, 28 Mar 2025 18:43:34 GMT, Andy Goryachev wrote:
> Provides the base class for manual tests which displays the test
> instructions, the UI under test, and the Pass/Fail buttons.
>
> Uses `EmojiTest` to illustrate the use of the new class.
>
> Example:
>
>
> public class ManualTestExam
This isn’t an area of the code that I’m familiar with. Searching for
updateCachedBounds in the bug database shows that there’s some history here so
maybe someone with more experience can chime in.
> On Mar 28, 2025, at 11:06 AM, Christopher Schnick wrote:
>
> So I tried various different thing
On Fri, 28 Mar 2025 21:21:11 GMT, Kevin Rushforth wrote:
>> Introduce a facility, in the form of JUnit5 annotation, to allow for
>> capturing a desktop screenshot of a failed test.
>>
>> The primary intent is to be able to debug an intermittent test case, rather
>> than wholesale addition of t
On Fri, 28 Mar 2025 18:20:59 GMT, Kevin Rushforth wrote:
>> That doesn't sound like a compelling reason to me. In fact, it makes it
>> seems like a bug in JavaFX that a line break is only rendered with `\n`, but
>> not with `\r\n` or `\r`.
>>
>> In any case, the goal here is to (semantically)
> Windows programs may reuse a clipboard buffer that is larger than the new
> content. In this case de NUL terminator is not at the end of the buffer, but
> within it.
> The current implementation copys the whole buffer into a text field,
> including the NUL terminator and the remaining chars.
Introduce a facility, in the form of JUnit5 annotation, to allow for capturing
a desktop screenshot of a failed test.
The primary intent is to be able to debug an intermittent test case, rather
than wholesale addition of the new annotation to all the tests.
A possible improvement could be to ou
On Tue, 25 Mar 2025 22:24:51 GMT, Ziad El Midaoui
wrote:
> With the minimum JDK set to 22, the reflection calls is replaced with direct
> calls to enableNativeAccess
This pull request has now been integrated.
Changeset: ff777c7a
Author:Ziad El Midaoui
Committer: Kevin Rushforth
URL:
Provides the base class for manual tests which displays the test instructions,
the UI under test, and the Pass/Fail buttons.
Uses `EmojiTest` to illustrate the use of the new class.
Example:
public class ManualTestExample extends ManualTestWindow {
public ManualTestExample() {
supe
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to
> skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009
> is fixed.
LGTM with one inline suggestion about adding the bug ID being used to sk
On Fri, 28 Mar 2025 17:28:22 GMT, Ziad El Midaoui
wrote:
>> With the minimum JDK set to 22, the reflection calls is replaced with direct
>> calls to enableNativeAccess
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
> up
On Fri, 28 Mar 2025 17:28:22 GMT, Ziad El Midaoui
wrote:
>> With the minimum JDK set to 22, the reflection calls is replaced with direct
>> calls to enableNativeAccess
>
> Ziad El Midaoui has updated the pull request incrementally with one
> additional commit since the last revision:
>
> up
So I tried various different things to reproduce it without the
StackOverflow, but no success so far. But I can definitely tell you from
many user issue reports that this issue frequently happens. Looking at
the logs when this happens, there were no other exceptions reported when
this happens.
I’ve been able to reproduce this inside a debugger on my Mac every eighth try
or so.
I’m not sure what I’m seeing is all that helpful. Your reproducing case is
inducing a stack overflow exception. If the exception occurs while
Parent.updateCachedBounds is executing the StackPane will be left in
On Thu, 27 Mar 2025 17:44:17 GMT, Kevin Rushforth wrote:
>> Martin Fox has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Removed unnecessary import
>> - The max nested event loop constant is no longer public
>
> Since this fix has been
On Thu, 27 Mar 2025 13:14:27 GMT, Oliver Schmidtmer
wrote:
>> modules/javafx.graphics/src/main/native-glass/win/GlassClipboard.cpp line
>> 207:
>>
>>> 205: {
>>> 206: addPair(GLASS_TEXT_PLAIN, CF_UNICODETEXT);
>>> 207: addPair(GLASS_TEXT_PLAIN_LOCALE, CF_UNICODETEXT);
>>
>> Seems like
On Wed, 26 Mar 2025 14:11:34 GMT, Michael Strauß wrote:
>> The tests show that only LF "\n" is rendered as a new line, there is no need
>> to add more restrictions that is not needed
>> and the same was tested by @andy-goryachev-oracle previously in the comments
>> and it confirms the same.
>
>
On Fri, 28 Mar 2025 20:55:31 GMT, Kevin Rushforth wrote:
> Without using an IDE (which is the default use case for manual tests), how
> would someone compile and run these?
Frankly, I have no idea. We might create a special module which contains
common test code and utilities, I suppose. Any
On Fri, 28 Mar 2025 18:43:34 GMT, Andy Goryachev wrote:
> Provides the base class for manual tests which displays the test
> instructions, the UI under test, and the Pass/Fail buttons.
>
> Uses `EmojiTest` to illustrate the use of the new class.
>
> Example:
>
>
> public class ManualTestExam
Hi Phil,
Thanks for your reply. I agree that the webkit build should be very doable,
as it is in fact simply invoking make to an external project.
I am slightly more worried about the generation of the shader code, and the
use of antlr for this. I'd like to use the gensrc phase of the jdk for
this
On Fri, 28 Mar 2025 09:21:56 GMT, Jayathirth D V wrote:
> menuBar test passes even without the fix in macOS.
That's strange: for me it fails in the current master branch (the line number
is different bc I just appended the test to the end of file). macOS 15.3.2.
java.lang.IllegalStateExcepti
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to
> skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009
> is fixed.
Marked as reviewed by angorya (Reviewer).
-
PR Review: htt
On Fri, 28 Mar 2025 08:56:36 GMT, Jayathirth D V wrote:
> SwingNodePlatformExitCrashTest hangs while running on wayland, we need to
> skip this test on wayland until https://bugs.openjdk.org/browse/JDK-8350009
> is fixed.
Gradle Wrapper Validation step failed - could you re-start the job? I s
> With the minimum JDK set to 22, the reflection calls is replaced with direct
> calls to enableNativeAccess
Ziad El Midaoui has updated the pull request incrementally with one additional
commit since the last revision:
updated copyright year
-
Changes:
- all: https://git.open
On Tue, 25 Mar 2025 22:41:59 GMT, Andy Goryachev wrote:
> looks good!
>
> please update the copyright year in the modified files. 1 reviewer is
> probably enough.
Done,
Can I integrate ?
-
PR Comment: https://git.openjdk.org/jfx/pull/1743#issuecomment-2761989807
27 matches
Mail list logo
