Re: RFR: 8335547: Support multi-line prompt text for TextArea [v2]

2025-03-22 Thread Andy Goryachev
On Fri, 21 Mar 2025 14:37:56 GMT, Ziad El Midaoui wrote: >> Added multi line prompt support for TextArea this will provide the ability >> to have multiple lines in textArea as expected, >> Also fixed tests to meet the new changes > > Ziad El Midaoui has updated the pull request incrementally wi

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-22 Thread Martin Fox
On Sat, 22 Mar 2025 02:12:48 GMT, Jay Bhaskar wrote: > It is better to use dynamically calculated safe limit instead of a hardcoded > value like 250. The problem doesn't seem to be resource exhaustion. It seems that Apple is using a hard-coded number specifically to detect a potential case of

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v2]

2025-03-22 Thread John Hendrikx
On Tue, 25 Feb 2025 00:42:04 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> comm

Re: RFR: 8350149: VBox ignores bias of child controls when fillWidth is set to false [v4]

2025-03-22 Thread Kevin Rushforth
On Fri, 28 Feb 2025 21:30:31 GMT, John Hendrikx wrote: >> Fixes the case where `VBox` will ignore the (horizontal) bias of a child >> when its fill width property is set to `false`. This manifests itself with >> labels that have their wrap text property set to `true`, and the container >> is

Re: RFR: 8351733: [macos] Crash when creating too many nested event loops

2025-03-22 Thread Martin Fox
On Fri, 21 Mar 2025 21:25:43 GMT, Andy Goryachev wrote: >> There is an undocumented limit on nesting calls to CFRunLoopRun (or the >> equivalent wrapper NSRunLoop methods). When the limit is hit the OS >> terminates the Java app. The situation arises when a JavaFX app creates too >> many neste

RFR: 8351047: TitledPane should handle titles that are resizable

2025-03-22 Thread John Hendrikx
This PR will forward more Label calculations to LabeledSkinBase, as they are quite complex, especially when a Graphic is involved which is a full-fledged `Node`. More specifically, this solves issues with TitledPane when the graphic is resizable (ie. an HBox is placed as Graphic in the titled pa