Caution: upgrading to Eclipse 2025.03

2025-03-18 Thread Andy Goryachev
Hi, Just a friendly warning: the latest Eclipse has a compiler bug that triggers two warnings in OpenJFX [0]. The bug is already fixed in one of the nightly builds. -andy [0] https://github.com/eclipse-platform/eclipse.platform/issues/1779

[jfx24u] RFR: 8351264: Some images don't load with WebKit 620.1

2025-03-18 Thread Jay Bhaskar
clean backport to jfx24u. The patch fixes image rendering issue on some websites that might have non compatible images for JavaFX Webkit platform. - Commit messages: - Backport c4fa462f1444c69693aab4107b4b6feee7ee4c7c Changes: https://git.openjdk.org/jfx24u/pull/14/files Webrev:

[jfx24u] Integrated: 8351264: Some images don't load with WebKit 620.1

2025-03-18 Thread Jay Bhaskar
On Tue, 18 Mar 2025 12:50:38 GMT, Jay Bhaskar wrote: > clean backport to jfx24u. The patch fixes image rendering issue on some > websites that might have non compatible images for JavaFX Webkit platform. This pull request has now been integrated. Changeset: e322a042 Author:Jay Bhaskar URL

Re: RFR: 8351038: ConcurrentModificationException in EventType constructor [v2]

2025-03-18 Thread Ambarish Rapte
On Mon, 10 Mar 2025 14:31:33 GMT, Andy Goryachev wrote: >> - synchronized `EventType::register()` method >> - simplified internal constructor which is only used for `EventType.ROOT` >> >> There should negligent impact on performance when `EventTypes` are created >> in the FX Application Thread.

Re: RFR: 8335547: Support multi-line prompt text for TextArea

2025-03-18 Thread Ziad El Midaoui
On Wed, 19 Feb 2025 16:50:02 GMT, Ziad El Midaoui wrote: > Added multi line prompt support for TextArea this will provide the ability to > have multiple lines in textArea as expected, > Also fixed tests to meet the new changes I did test the mentioned line separators without filtering and the

Re: RFR: 8351038: ConcurrentModificationException in EventType constructor [v3]

2025-03-18 Thread Andy Goryachev
> - synchronized `EventType::register()` method > - simplified internal constructor which is only used for `EventType.ROOT` > > There should negligent impact on performance when `EventTypes` are created in > the FX Application Thread. > > There might be a distant potential for a deadlock if the

Re: RFR: 8351038: ConcurrentModificationException in EventType constructor [v3]

2025-03-18 Thread Ambarish Rapte
On Tue, 18 Mar 2025 16:57:31 GMT, Andy Goryachev wrote: >> - synchronized `EventType::register()` method >> - simplified internal constructor which is only used for `EventType.ROOT` >> >> There should negligent impact on performance when `EventTypes` are created >> in the FX Application Thread.

Re: RFR: 8351867: No UI changes while iconified

2025-03-18 Thread Ambarish Rapte
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 This does fix the issue on windows. The issue on mac seem

Re: RFR: 8313424: JavaFX controls in the title bar [v56]

2025-03-18 Thread Andy Goryachev
On Mon, 17 Mar 2025 18:54:27 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since t

RFR: 8352268: [TestBug] Saving in Rich Editor Demo

2025-03-18 Thread Andy Goryachev
Fixes embarrassing bugs in Rich Editor Demo: - File -> Save not saving - File -> Open not emphasizing .rich files - Commit messages: - save Changes: https://git.openjdk.org/jfx/pull/1739/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1739&range=00 Issue: https://bugs.op

Re: RFR: 8351867: No UI changes while iconified

2025-03-18 Thread John Hendrikx
On Tue, 18 Mar 2025 15:01:46 GMT, Ambarish Rapte wrote: > This does fix the issue on windows. The issue on mac seems intermittent even > without this change, and stays intermittent with this change. > > The change seems to achieve the intended but the trigger check may not be the > best way. `

Re: RFR: 8351867: No UI changes while iconified

2025-03-18 Thread Martin Fox
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 At least on the Mac there seems to be a timing issue. If

Re: RFR: 8313424: JavaFX controls in the title bar [v56]

2025-03-18 Thread Andy Goryachev
On Mon, 17 Mar 2025 18:54:27 GMT, Michael Strauß wrote: >> Implementation of >> [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) >> and `EXTENDED_UTILITY` stage style. > > Michael Strauß has updated the pull request incrementally with one additional > commit since t