Re: RFR: 8341670: [Text, TextFlow] Public API for Text Layout Info [v19]

2025-03-15 Thread Michael Strauß
On Mon, 10 Mar 2025 16:30:25 GMT, Andy Goryachev wrote: >> Please refer to >> >> https://github.com/andy-goryachev-oracle/Test/blob/main/doc/Text/LayoutInfo.md >> >> The RichTextArea control >> ([JDK-8301121](https://bugs.openjdk.org/browse/JDK-8301121)), or any custom >> control that needs n

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v12]

2025-03-15 Thread John Hendrikx
On Mon, 10 Mar 2025 17:22:16 GMT, Michael Strauß wrote: > What if we didn't call back the second listener (as you said, it would > probably result in an infinite loop), and logged an error instead (that's not > without precedence, bindings also log errors)? It seems like this would still > all

Re: [jfx24] RFR: 8350136: Create release notes for JavaFX 24

2025-03-15 Thread Andy Goryachev
On Fri, 14 Mar 2025 13:20:47 GMT, Kevin Rushforth wrote: > Clean backport of the JavaFX 24 release notes to the `jfx24` stabilization > branch, so they will be available in that branch when JavaFX 24 is published > (and from there also synced into the jfx24u repo). > > NOTE: The release notes

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2025-03-15 Thread John Hendrikx
On Sun, 9 Mar 2025 22:27:00 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix non-convergence logic one more time... > > modules/javafx.base/src/main/java/com/sun/javafx/binding/OldValueCachingLi

Removing the default application menu on the Mac

2025-03-15 Thread Martin Fox
On the Mac the JavaFX core creates the application menu, the one immediately adjacent to the Apple menu in the menu bar. There is no JavaFX API to access it so a developer can’t localize the existing items or add additional ones (like About). We can’t easily provide access to it since it’s not b

Re: RFR: 8351878: RichTextArea: Pasting from RTF doesn't apply formatting [v2]

2025-03-15 Thread Andy Goryachev
> Fixed two issues found in importing RTF text: > > - charset translation (brought back removed code) > - missing font size attribute > - missing strike-through attribute > > The charset issue was caused by my removal of the character decoder code > present in the original JDK RTF parser/reader.

Re: JVM crashes on macOS when entering too many nested event loops

2025-03-15 Thread Martin Fox
Hi Christopher, I was able to reproduce this crash. I wrote a small routine that recursively calls itself in a runLater block and then enters a nested event loop. The program crashes when creating loop 254. I’m not sure where that limit comes from so it’s possible that consuming some other syst

Re: RFR: 8350136: Create release notes for JavaFX 24 [v5]

2025-03-15 Thread Kevin Rushforth
On Thu, 13 Mar 2025 22:43:24 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 24 release. This will first go >> into master, and then be backported to the jfx24 branch so it will be >> available in that branch when JavaFX 24 is published (and from there also >> sync

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2025-03-15 Thread John Hendrikx
On Mon, 10 Mar 2025 02:34:02 GMT, Nir Lisker wrote: > First part of the review. > > There are several class (and their methods) that are `public`, but are only > used in their package and can just have package-access: > `OldValueCachingListenerList` `ListenerManagerBase` `ListenerListBase` >

Re: RFR: 8349373: Support JavaFX preview features [v6]

2025-03-15 Thread Kevin Rushforth
On Sat, 15 Mar 2025 03:41:29 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional