Re: RFR: 8349373: Support JavaFX preview features [v6]

2025-03-14 Thread Michael Strauß
> This PR contains a definition of preview features for JavaFX, as well as a > helper class to verify that an application has opted into preview features. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: banner -> warning -

Integrated: 8351653: Webkit debug build failure after update to 620.1

2025-03-14 Thread Jay Bhaskar
On Thu, 13 Mar 2025 05:04:00 GMT, Jay Bhaskar wrote: > issue : build fails on debug mode. invalid casting > Solution: the casting should be with char* , need to use SourceUTF8().data() This pull request has now been integrated. Changeset: 99ee34fe Author:Jay Bhaskar URL: https://git

Re: [jfx24] RFR: 8350136: Create release notes for JavaFX 24

2025-03-14 Thread Kevin Rushforth
On Fri, 14 Mar 2025 13:20:47 GMT, Kevin Rushforth wrote: > Clean backport of the JavaFX 24 release notes to the `jfx24` stabilization > branch, so they will be available in that branch when JavaFX 24 is published > (and from there also synced into the jfx24u repo). > > NOTE: The release notes

[jfx24] RFR: 8350136: Create release notes for JavaFX 24

2025-03-14 Thread Kevin Rushforth
Clean backport of the JavaFX 24 release notes to the `jfx24` stabilization branch, so they will be available in that branch when JavaFX 24 is published (and from there also synced into the jfx24u repo). NOTE: The release notes are not part of the build, so this backport to jfx24 will not cause

[jfx24] Integrated: 8350136: Create release notes for JavaFX 24

2025-03-14 Thread Kevin Rushforth
On Fri, 14 Mar 2025 13:20:47 GMT, Kevin Rushforth wrote: > Clean backport of the JavaFX 24 release notes to the `jfx24` stabilization > branch, so they will be available in that branch when JavaFX 24 is published > (and from there also synced into the jfx24u repo). > > NOTE: The release notes

Re: RFR: 8351653: Webkit debug build failure after update to 620.1

2025-03-14 Thread Kevin Rushforth
On Thu, 13 Mar 2025 05:04:00 GMT, Jay Bhaskar wrote: > issue : build fails on debug mode. invalid casting > Solution: the casting should be with char* , need to use SourceUTF8().data() Looks good. This fixes the debug build on macOS. We already have an older bug, [JDK-8329874](https://bugs.open

Integrated: 8351067: Enforce Platform threading use

2025-03-14 Thread Andy Goryachev
On Tue, 4 Mar 2025 19:00:06 GMT, Andy Goryachev wrote: > Summary > --- > > Adds a thread check to a number of `Platform` methods: > > accessibilityActiveProperty() > getPreferences() > isAccessibilityActive() > > These methods will throw an `IllegalStateException` if called on a thread >

Re: RFR: 8349373: Support JavaFX preview features [v5]

2025-03-14 Thread Kevin Rushforth
On Fri, 14 Mar 2025 16:21:22 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional

Re: RFR: 8091629: [Mac] Support the automatic hiding of the "java" menu bar item when using the system menu bar

2025-03-14 Thread Kevin Rushforth
On Fri, 14 Mar 2025 18:09:23 GMT, Martin Fox wrote: > On the Mac the application menu (the one to the right of the Apple logo menu) > is created by JavaFX and there is no public API to customize or localize it. > This PR allows a client to get rid of it and replace it with an entirely > custom

Re: RFR: 8347937: Canvas pattern test fails on WebKit 620.1

2025-03-14 Thread Sergey Nazarkin
On Fri, 14 Mar 2025 14:12:30 GMT, Kevin Rushforth wrote: >> Hi! >> >> This is my desperate fix for what I believe to be a critical bug. Since my >> knowledge of the codebase is minimal, and the class structure is a bit >> controversial, my fix is mostly based on historical excavation. >> >> #

Re: RFR: 8350136: Create release notes for JavaFX 24 [v5]

2025-03-14 Thread Kevin Rushforth
> This PR adds the release notes for the JavaFX 24 release. This will first go > into master, and then be backported to the jfx24 branch so it will be > available in that branch when JavaFX 24 is published (and from there also > synced into the jfx24u repo). > > The following filter was used to

Integrated: 8350136: Create release notes for JavaFX 24

2025-03-14 Thread Kevin Rushforth
On Fri, 14 Feb 2025 23:15:46 GMT, Kevin Rushforth wrote: > This PR adds the release notes for the JavaFX 24 release. This will first go > into master, and then be backported to the jfx24 branch so it will be > available in that branch when JavaFX 24 is published (and from there also > synced i

Re: RFR: 8351867: No UI changes while iconified

2025-03-14 Thread Martin Fox
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 Adding `entireSceneNeedsRepaint` fixes this on the Mac.

Re: RFR: 8349373: Support JavaFX preview features [v5]

2025-03-14 Thread Andy Goryachev
On Fri, 14 Mar 2025 16:21:22 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional

Re: RFR: 8351067: Enforce Platform threading use [v3]

2025-03-14 Thread Kevin Rushforth
On Fri, 7 Mar 2025 21:59:10 GMT, Michael Strauß wrote: >>> move to a more structured form of documentation, for example with custom >>> javadoc tags. >> >> what custom tags? could you elaborate? > >> what custom tags? could you elaborate? > > Maybe a custom tag like `@threadAccess JavaFX appl

Re: RFR: 8349373: Support JavaFX preview features [v4]

2025-03-14 Thread Kevin Rushforth
On Thu, 13 Mar 2025 03:29:28 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with one additional

Re: RFR: 8347937: Canvas pattern test fails on WebKit 620.1

2025-03-14 Thread Kevin Rushforth
On Thu, 13 Mar 2025 18:17:53 GMT, Sergey Nazarkin wrote: > Hi! > > This is my desperate fix for what I believe to be a critical bug. Since my > knowledge of the codebase is minimal, and the class structure is a bit > controversial, my fix is mostly based on historical excavation. > > # What

Re: RFR: 8351867: No UI changes while iconified

2025-03-14 Thread Martin Fox
On Thu, 13 Mar 2025 10:36:40 GMT, John Hendrikx wrote: > Adds code to trigger a scene update when a Window is restored > > This seems to solve https://bugs.openjdk.org/browse/JDK-8351867 and > https://bugs.openjdk.org/browse/JDK-8146479 I just verified that this PR does not fix the original is

Re: RFR: 8349373: Support JavaFX preview features [v5]

2025-03-14 Thread Michael Strauß
> This PR contains a definition of preview features for JavaFX, as well as a > helper class to verify that an application has opted into preview features. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: rename system property

RFR: 8091629: [Mac] Support the automatic hiding of the "java" menu bar item when using the system menu bar

2025-03-14 Thread Martin Fox
On the Mac the application menu (the one to the right of the Apple logo menu) is created by JavaFX and there is no public API to customize or localize it. This PR allows a client to get rid of it and replace it with an entirely custom JavaFX Menu. Prior to OS X 10.6 (Snow Leopard) the applicati

Re: RFR: 8347937: Canvas pattern test fails on WebKit 620.1

2025-03-14 Thread Jay Bhaskar
On Thu, 13 Mar 2025 18:17:53 GMT, Sergey Nazarkin wrote: > Hi! > > This is my desperate fix for what I believe to be a critical bug. Since my > knowledge of the codebase is minimal, and the class structure is a bit > controversial, my fix is mostly based on historical excavation. > > # What