Re: JVM crashes on macOS when entering too many nested event loops

2025-03-12 Thread Christopher Schnick
Thank you for your effort on that investigation. Hopefully this issue can be fixed somehow. For now, we tweaked some calls to runLater and enterNestedEventLoop to be called a little bit less often. On 11/03/2025 20:40, Martin Fox wrote: I entered a bug https://bugs.openjdk.org/browse/JDK-83517

Re: Probably bug: UI changes made while minimized, not reflected upon restore/maximize

2025-03-12 Thread Andy Goryachev
Reproduced, thanks! I am going to create a bug shortly. -andy From: openjfx-dev on behalf of John Hendrikx Date: Wednesday, March 12, 2025 at 07:52 To: openjfx-dev@openjdk.org Subject: Re: Probably bug: UI changes made while minimized, not reflected upon restore/maximize Here's a simpler v

Re: Probably bug: UI changes made while minimized, not reflected upon restore/maximize

2025-03-12 Thread Andy Goryachev
Thank you for reporting the issue! I’ve created https://bugs.openjdk.org/browse/JDK-8351867 -andy From: openjfx-dev on behalf of Cormac Redmond Date: Tuesday, March 11, 2025 at 18:36 To: openjfx-dev@openjdk.org Subject: Re: Probably bug: UI changes made while minimized, not reflected upon r

Re: RFR: 8349373: Support JavaFX preview features [v3]

2025-03-12 Thread Andy Goryachev
On Wed, 12 Mar 2025 13:31:11 GMT, Kevin Rushforth wrote: > Should we specify that the `@Deprecated` annotation on preview features be > marked as `forRemoval=true` wouldn't this send a wrong message? could we invent a new annotation `@Preview` ? - PR Comment: https://git.openjdk.o

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v16]

2025-03-12 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > See also #837 for a previous attempt which instead of triggering nested > emissions immediately (like this PR and `ExpressionHelper`) would wait until > the current emiss

Re: RFR: 8349373: Support JavaFX preview features [v3]

2025-03-12 Thread Kevin Rushforth
On Wed, 12 Mar 2025 14:24:08 GMT, Andy Goryachev wrote: > > Should we specify that the `@Deprecated` annotation on preview features be > > marked as `forRemoval=true` > > wouldn't this send a wrong message? Yes, that's the main counter-argument. Unlike incubator modules, which necessarily nee

Re: Probably bug: UI changes made while minimized, not reflected upon restore/maximize

2025-03-12 Thread John Hendrikx
Here's a simpler version that shows the problem. It appears that a stage in iconified mode (minimized) is simply not doing any updates when it becomes visible again. In my system, when I click the task bar to show the stage, I just see an empty box (with a color that is clearly not the correct back

Re: RFR: 8349373: Support JavaFX preview features [v3]

2025-03-12 Thread Kevin Rushforth
On Fri, 7 Feb 2025 09:16:54 GMT, Michael Strauß wrote: >> This PR contains a definition of preview features for JavaFX, as well as a >> helper class to verify that an application has opted into preview features. > > Michael Strauß has updated the pull request incrementally with four > additiona

Re: RFR: 8350136: Create release notes for JavaFX 24 [v4]

2025-03-12 Thread Abhinay Agarwal
On Tue, 11 Mar 2025 20:23:44 GMT, Kevin Rushforth wrote: >> This PR adds the release notes for the JavaFX 24 release. This will first go >> into master, and then be backported to the jfx24 branch so it will be >> available in that branch when JavaFX 24 is published (and from there also >> sync

Re: Probably bug: UI changes made while minimized, not reflected upon restore/maximize

2025-03-12 Thread Cormac Redmond
Great -- thanks John & Andy! On Wed, 12 Mar 2025 at 15:06, Andy Goryachev wrote: > Thank you for reporting the issue! > > I’ve created https://bugs.openjdk.org/browse/JDK-8351867 > > > > -andy > > > > > > *From: *openjfx-dev on behalf of Cormac > Redmond > *Date: *Tuesday, March 11, 2025 at 18

Re: Building OpenJFX with the JDK build system

2025-03-12 Thread John Neffenger
On 2/27/25 7:15 AM, Johan Vos wrote: The POC I have for this (linux-only at the moment) is at https://github.com/johanvos/jdk/tree/jfxpoc-blog That's very clever, Johan. I never thought of using the JDK repository as-is to build JavaFX. I agree it's "one of the most excellent build systems fo

Re: RFR: 8349373: Support JavaFX preview features [v4]

2025-03-12 Thread Michael Strauß
> This PR contains a definition of preview features for JavaFX, as well as a > helper class to verify that an application has opted into preview features. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: warning can be suppressed -

Re: RFR: 8313424: JavaFX controls in the title bar [v53]

2025-03-12 Thread Michael Strauß
> Implementation of > [`EXTENDED`](https://gist.github.com/mstr2/0befc541ee7297b6db2865cc5e4dbd09) > and `EXTENDED_UTILITY` stage style. Michael Strauß has updated the pull request incrementally with one additional commit since the last revision: tweak header button glyph scaling --

Re: RFR: 8350976: MenuBarSkin: exception initializing in a background thread [v2]

2025-03-12 Thread Michael Strauß
On Wed, 5 Mar 2025 18:19:53 GMT, Andy Goryachev wrote: >> Allows MenuBar to be created in a background thread by delaying >> MenuBarSkin::rebuildUI() call until after the MenuBar becomes a part of the >> scene graph. > > Andy Goryachev has updated the pull request with a new target base due to

Re: RFR: 8351067: Enforce Platform threading use [v4]

2025-03-12 Thread Michael Strauß
On Mon, 10 Mar 2025 20:30:43 GMT, Andy Goryachev wrote: >> Summary >> --- >> >> Adds a thread check to a number of `Platform` methods: >> >> accessibilityActiveProperty() >> getPreferences() >> isAccessibilityActive() >> >> These methods will throw an `IllegalStateException` if called on a

Re: RFR: 8349373: Support JavaFX preview features [v3]

2025-03-12 Thread Michael Strauß
On Wed, 12 Mar 2025 14:24:08 GMT, Andy Goryachev wrote: > > Should we specify that the `@Deprecated` annotation on preview features be > > marked as `forRemoval=true` > > wouldn't this send a wrong message? could we invent a new annotation > `@Preview` ? We could, but then we'd lose the integ

RFR: 8351653: Webkit debug build failure after update to 620.1

2025-03-12 Thread Jay Bhaskar
issue : build fails on debug mode. invalid casting Solution: the casting should be with char* , need to use SourceUTF8().data() - Commit messages: - 8351653: Webkit debug build failure after update to 620.1 Changes: https://git.openjdk.org/jfx/pull/1732/files Webrev: https://webre

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v15]

2025-03-12 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > See also #837 for a previous attempt which instead of triggering nested > emissions immediately (like this PR and `ExpressionHelper`) would wait until > the current emiss