RFR: 8351368: RichTextArea: exception pasting from Word

2025-03-06 Thread Andy Goryachev
The original code used String attribute keys. I'd like to backport this fix to jfx24u. - Commit messages: - fix Changes: https://git.openjdk.org/jfx/pull/1731/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1731&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8351368

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-06 Thread Marius Hanl
On Thu, 6 Mar 2025 16:21:52 GMT, Andy Goryachev wrote: >> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (b

Re: RFR: 8351368: RichTextArea: exception pasting from Word

2025-03-06 Thread Kevin Rushforth
On Thu, 6 Mar 2025 23:16:41 GMT, Andy Goryachev wrote: > The original code used String attribute keys. > > I'd like to backport this fix to jfx24u. This is a simple enough fix that a single reviewer should be sufficient. modules/jfx.incubator.richtext/src/main/java/com/sun/jfx/incubator/scene/

Re: RFR: 8342565: [TestBug] StubTextLayout [v2]

2025-03-06 Thread Andy Goryachev
On Tue, 4 Feb 2025 08:53:31 GMT, Marius Hanl wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits s

RFR: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed

2025-03-06 Thread John Hendrikx
8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed - Commit messages: - Add test case - Prevent redundant compute value calls Changes: https://git.openjdk.org/jfx/pull/1730/files Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1730&range=00

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v7]

2025-03-06 Thread John Hendrikx
On Thu, 6 Mar 2025 03:08:58 GMT, Nir Lisker wrote: > I tested the new convergence check. If listener A and listener B fight over a > value, it works, but if I add after then listener C that just prints what it > sees without changing the value, it completes without an error. > > Is it not poss

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v7]

2025-03-06 Thread John Hendrikx
On Thu, 6 Mar 2025 03:08:58 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix docs > > I tested the new convergence check. If listener A and listener B fight over a > value, it works, but if I a

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v8]

2025-03-06 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they were registered, invalidation listeners > always before ch

Integrated: 8313556: Create implementation of NSAccessibilitySlider protocol

2025-03-06 Thread Alexander Zuev
On Tue, 29 Aug 2023 10:10:54 GMT, Alexander Zuev wrote: > Create implementation for Slider and Stepper accessibility protocols. > Fix mapping. > Fix performAction parameter type in declaration. This pull request has now been integrated. Changeset: c7091e1f Author:Alexander Zuev Committer:

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v9]

2025-03-06 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they were registered, invalidation listeners > always before ch

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v10]

2025-03-06 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they were registered, invalidation listeners > always before ch

Re: RFR: 8342565: [TestBug] StubTextLayout [v6]

2025-03-06 Thread Marius Hanl
On Wed, 5 Mar 2025 15:54:49 GMT, Andy Goryachev wrote: >> Changed the StubTextLayout to use product PrismTextLayout with much >> simplified glyph layout (via stubbed fonts). The new layout assumes all the >> glyphs are squares of font size, while the bold type face produces wider >> glyphs (b

Re: RFR: 8345261: Refactor the Dimension2D classes

2025-03-06 Thread John Hendrikx
On Thu, 6 Mar 2025 02:50:33 GMT, Nir Lisker wrote: > The int-based Dimension is only used by Rectangle even if in another class I've taken another look. Rectangle is not using this class at all. I think it would be much better to give the GTK screencast logic its own little int/int record (n

Re: RFR: 8277000: Tree-/TableRowSkin: replace listener to fixedCellSize by live lookup [v5]

2025-03-06 Thread Kevin Rushforth
On Mon, 17 Feb 2025 22:56:56 GMT, Marius Hanl wrote: >> This PR improves the `Tree-/TableRowSkin` code by doing a normal live lookup >> for the `fixedCellSize` instead of adding listener just to update >> variables(`fixedCellSizeEnabled` and `fixedCellSize`) which can otherwise be >> also just

Re: RFR: 8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

2025-03-06 Thread John Hendrikx
> This provides and uses a new implementation of `ExpressionHelper`, called > `ListenerManager` with improved semantics. > > # Behavior > > |Listener...|ExpressionHelper|ListenerManager| > |---|---|---| > |Invocation Order|In order they were registered, invalidation listeners > always before ch

Re: RFR: 8342565: [TestBug] StubTextLayout [v9]

2025-03-06 Thread Andy Goryachev
> Changed the StubTextLayout to use product PrismTextLayout with much > simplified glyph layout (via stubbed fonts). The new layout assumes all the > glyphs are squares of font size, while the bold type face produces wider > glyphs (by 1 pixel). The default font size has changed from 10 to 12

Re: RFR: 8342565: [TestBug] StubTextLayout [v8]

2025-03-06 Thread Andy Goryachev
> Changed the StubTextLayout to use product PrismTextLayout with much > simplified glyph layout (via stubbed fonts). The new layout assumes all the > glyphs are squares of font size, while the bold type face produces wider > glyphs (by 1 pixel). The default font size has changed from 10 to 12