> The bug happened when setting only width or height (not both) on a Stage that
> was oriented by the view size.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix test package
-
Changes:
- all: https://git
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
The bug happened when setting only width or height (not both) on a Stage that
was oriented by the view size.
-
Commit messages:
- Fix 8344372
Changes: https://git.openjdk.org/jfx/pull/1654/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1654&range=00
Issue: https://bugs.
> The bug happened when setting only width or height (not both) on a Stage that
> was oriented by the view size.
Thiago Milczarek Sayao has updated the pull request incrementally with one
additional commit since the last revision:
Fix test class name
-
Changes:
- all: https://
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote:
> A small refactoring of the Dimension classes.
>
> * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by
> `com.sun.javafx.geom.Dimension2D`.
> * `com.sun.javafx.geom.Dimension2D` became a record.
> * `javafx.geometry.Di
On Fri, 29 Nov 2024 09:24:31 GMT, Marius Hanl wrote:
>> This PR changes all `RT-` references to `JDK-XXX`.
>> It also removes all `http://javafx-jira.kenai.com/browse/` occurrences.
>>
>> As discussed, this will help a lot when looking up old issues, especially
>> since not everybody kn
I agree with your type analysis. However, I'm hesitant to change the logic
in regarding 'numedges' without someone who is familiar with the domain
taking a look; these sorts of computations often have non-obvious sides to
them.
I also think that the class was copied. The raw types usage suggests a
Probably derived from java.awt.Area:
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/geom/Area.java
Le sam. 30 nov. 2024, 17:59, Nir Lisker a écrit :
> I agree with your type analysis. However, I'm hesitant to change the logic
> in regarding 'numedges' without
You're right, these geometry classes were copied from AWT. Here is the
offending AreOp:
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/awt/geom/AreaOp.java
.
They generified their code at some point like John did. They also just
create a new vector in the 'numedges'
