Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v4]

2024-11-29 Thread Marius Hanl
> This PR changes all `RT-` references to `JDK-XXX`. > It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. > > As discussed, this will help a lot when looking up old issues, especially > since not everybody know how to do a lookup with the `RT-` number in the > JI

Re: RFR: 8344899: Map RT-nnnn bug IDs to JDK-mmmmmmm in JavaFX sources [v3]

2024-11-29 Thread Marius Hanl
On Thu, 28 Nov 2024 12:52:33 GMT, Marius Hanl wrote: >> This PR changes all `RT-` references to `JDK-XXX`. >> It also removes all `http://javafx-jira.kenai.com/browse/` occurrences. >> >> As discussed, this will help a lot when looking up old issues, especially >> since not everybody kn

RFR: 8345261: Refactor the Dimension2D classes

2024-11-29 Thread Nir Lisker
A small refactoring of the Dimension classes. * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by `com.sun.javafx.geom.Dimension2D`. * `com.sun.javafx.geom.Dimension2D` became a record. * `javafx.geometry.Dimension2D`: fields became `final`. I'm not sure we need the imple

Re: Possible mistakes in com.sun.javafx.geom.AreaOp

2024-11-29 Thread John Hendrikx
Hi Nir, I encountered that class before while doing raw warning clean-ups in graphics (which were never integrated). The problem IMHO is in the assignment in `calculate`: edges = pruneEdges(edges); This assignment is both confusing and unnecessary, and violates the principle of re-using variabl

Re: RFR: 8345261: Refactor the Dimension2D classes

2024-11-29 Thread John Hendrikx
On Fri, 29 Nov 2024 17:00:42 GMT, Nir Lisker wrote: > A small refactoring of the Dimension classes. > > * `com.sun.javafx.geom.Dimension` was removed and its uses were replaced by > `com.sun.javafx.geom.Dimension2D`. > * `com.sun.javafx.geom.Dimension2D` became a record. > * `javafx.geometry.Di

Possible mistakes in com.sun.javafx.geom.AreaOp

2024-11-29 Thread Nir Lisker
I came across a potential mistake in the class com.sun.javafx.geom.AreaOp. It uses raw Vector types and while trying to add generic parameters there for type safety, I got some conflicts. In the method AreaOp::calculate, the arguments should be Vector and the return type should also be Vector, but