Re: Class ButtonAccessibility is implemented twice in JFX 17.0.13

2024-11-15 Thread Johan Vos
This is a good question. JDK-8311806 is a P4 bug, so my (non-formal) algorithm would say not to backport this. But then, this clearly can create crashes and it is a simple fix that is not affecting other platforms, so I am very much in favour of backporting it. Note that I raised this point on the

Scene 3D objects throw exception on Android devices

2024-11-15 Thread Ashley Hales
Hi, I posted a thread some time ago about Scene 3D objects causing a error when they try to create the shader. At the time I was advised to recompile the project using the new Gluon library rather than JavaFXPorts. I have now done this but the result is not compatible with my device. I have fou

Re: JEP: JavaFX controls in the title bar

2024-11-15 Thread Michael Strauß
I don't really like the idea of supporting multiple HeaderBars. If we did that, we'd have application developers deviating from the de-facto implementation requirement that a HeaderBar be placed at the top of the window, and extend its entire width. If that is not the case, then leftSystemInset and

Re: JEP: JavaFX controls in the title bar

2024-11-15 Thread Andy Goryachev
weather app effect: extend the HeaderBar to the full height, use that as the main container. multiple HeaderBars is something we probably should avoid. -andy From: openjfx-dev on behalf of Martin Fox Date: Friday, November 15, 2024 at 15:24 To: Michael Strauß Cc: OpenJFX Subject: Re: JEP:

Re: RFR: 8290037: Bindings should clean up after themselves when their weak listeners go out of scope [v2]

2024-11-15 Thread Marius Hanl
On Thu, 14 Jul 2022 19:48:04 GMT, John Hendrikx wrote: >> This is an initial (incomplete) implementation of 8290037 for evaluation. >> >> If the approach is agreed, I will modify the rest of the `*PropertyBase` >> classes which use weak listeners, and add some tests. >> >> I didn't use `Cleane

Re: RFR: 8301121: RichTextArea Control (Incubator) [v45]

2024-11-15 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: JEP: JavaFX controls in the title bar

2024-11-15 Thread Michael Strauß
That's correct. The only thing you can't do out-of-the-box with HeaderBar is assign different backgrounds to each of the areas (HeaderBar is a Region, which only has a single background). Of course, you can place another layout container in one of the areas, and give the nested container a differe

Re: JEP: JavaFX controls in the title bar

2024-11-15 Thread Martin Fox
Michael, On the Mac a common UI layout is to have a splitter view that extends to the top of the window with separate toolbars in each panel. Have you given any thought on supporting this layout in an EXTENDED window? (I realize this is a Mac thing; Apple loves their sidebars. Microsoft dabbled

RFR: 8341687: Memory leak in TableView after interacting with TableMenuButton

2024-11-15 Thread Marius Hanl
There are multiple issues in the `TableMenu` logic that result in a memory leak. The following problems are now fixed with this PR: - The listener, that is registered to the `col.visibleProperty()` was not weak nor was it ever unregistered - The fix is to do pretty much the same that was alrea

Re: RFR: 8335469: [XWayland] crash when an AWT ScreenCast session overlaps with an FX ScreenCast session [v2]

2024-11-15 Thread Kevin Rushforth
On Fri, 15 Nov 2024 02:21:57 GMT, Alexander Zvegintsev wrote: >> This is the FX counterpart of the >> [openjdk/jdk/pull/22131](https://github.com/openjdk/jdk/pull/22131) / >> `b.`(aka crash prevention part) >> >> It does not crash without the >> [openjdk/jdk/pull/22131](https://github.com/op

Re: RFR: 8343196: Add build property to identify experimental builds of JavaFX

2024-11-15 Thread Ambarish Rapte
On Thu, 14 Nov 2024 12:02:02 GMT, Ambarish Rapte wrote: >> Introduce a new build property `jfx.experimental.release.suffix` to be used >> for the early access builds of an under development feature in JavaFX. >> This property would be set to a value ONLY in a branch specific to an >> experiment

Re: [External] : Re: Class ButtonAccessibility is implemented twice in JFX 17.0.13

2024-11-15 Thread Kevin Rushforth
FWIW, since it is crashing, I would suggest that the priority -- at least for jfx17u -- is higher than a P4 (maybe a P2). We usually don't take the time to adjust the priority of a bug after it is fixed, so we will sometimes backport bugs with a lower priority than would otherwise meet the crit

[jfx17u] RFR: 8311806: Class ButtonAccessibility is implemented twice

2024-11-15 Thread Johan Vos
8311806: Class ButtonAccessibility is implemented twice - Commit messages: - Backport ad5e66a7ca31994ecbdae3fc7d0b951e0a6f8197 Changes: https://git.openjdk.org/jfx17u/pull/209/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u&pr=209&range=00 Issue: https://bugs.openjdk.org/

[jfx17u] Integrated: 8311806: Class ButtonAccessibility is implemented twice

2024-11-15 Thread Johan Vos
On Fri, 15 Nov 2024 09:29:17 GMT, Johan Vos wrote: > 8311806: Class ButtonAccessibility is implemented twice This pull request has now been integrated. Changeset: 00dc6895 Author:Johan Vos URL: https://git.openjdk.org/jfx17u/commit/00dc6895117b2aff8a5120ce9d32bc8317a704a5 Stats:

Re: RFR: 8335469: [XWayland] crash when an AWT ScreenCast session overlaps with an FX ScreenCast session [v2]

2024-11-15 Thread Alexander Zvegintsev
On Fri, 15 Nov 2024 12:53:46 GMT, Kevin Rushforth wrote: > Can you rerun it? Sure, done https://github.com/azvegint/jfx/actions/runs/11849042656 - PR Comment: https://git.openjdk.org/jfx/pull/1639#issuecomment-2478894882

Re: Scene 3D objects throw exception on Android devices

2024-11-15 Thread Nir Lisker
This is a question for Gluon, not OpenJFX, as JavaFXPorts and the newer Gluon client are not part of JavaFX (it's the other way around). I suggest StackOverflow, they are active there. I can tell you that JavaFXPorts was EOL years ago. Also that the MBOX might not have a pipeline with 3D support (

Re: RFR: 8301121: RichTextArea Control (Incubator) [v44]

2024-11-15 Thread Andy Goryachev
> Incubating a new feature - rich text control, **RichTextArea**, intended to > bridge the functional gap with Swing and its StyledEditorKit/JEditorPane. The > main design goal is to provide a control that is complete enough to be useful > out-of-the box, as well as open to extension by the appl

Re: JEP: JavaFX controls in the title bar

2024-11-15 Thread Martin Fox
Perhaps a better app to look at is Mac Weather. The sidebar background color and translucency effects extend all the way to the top of the window. Easy to set up with multiple header bars, considerably more complicated with just one. If an application developer wants this effect we could either