RFR: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null

2024-08-27 Thread Jose Pereda
This PR adds a couple of null checks to `LogicalFont` and `FTFactory`, that make use of `FontConfigManager::getFontConfigFont`, which under certain cases, can return null. I've tested this PR on both Linux (Ubuntu 22.04.4) and Android, just using `-Dprism.useFontConfig=false`. On Ubuntu, I've

RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView

2024-08-27 Thread Oliver Schmidtmer
On a Shadow state update with cleared shadow, the new values were not transmitted to the Java GraphicsDecoder - Commit messages: - 8334124: Rendering issues with CSS "text-shadow" in WebView Changes: https://git.openjdk.org/jfx/pull/1547/files Webrev: https://webrevs.openjdk.org/

Re: RFR: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null

2024-08-27 Thread Kevin Rushforth
On Tue, 27 Aug 2024 15:50:54 GMT, Jose Pereda wrote: > This PR adds a couple of null checks to `LogicalFont` and `FTFactory`, that > make use of `FontConfigManager::getFontConfigFont`, which under certain > cases, can return null. > > I've tested this PR on both Linux (Ubuntu 22.04.4) and Andr

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView

2024-08-27 Thread Kevin Rushforth
On Tue, 27 Aug 2024 15:55:47 GMT, Oliver Schmidtmer wrote: > On a Shadow state update with cleared shadow, the new values were not > transmitted to the Java GraphicsDecoder Reviewers: @kevinrushforth @jaybhaskar @Schmidor Would it be possible to add an automated test for this? -

Re: RFR: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null

2024-08-27 Thread John Hendrikx
On Tue, 27 Aug 2024 15:50:54 GMT, Jose Pereda wrote: > Shouldn't we fail gracefully after LogicalFont::getSlot0Resource if > slot0FontResource is finally null? It calls `PrismFontFactory::getDefaultFontResource` -- this function looks practically everywhere to find some kind of font. I think

Re: RFR: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null

2024-08-27 Thread John Hendrikx
On Tue, 27 Aug 2024 15:50:54 GMT, Jose Pereda wrote: > This PR adds a couple of null checks to `LogicalFont` and `FTFactory`, that > make use of `FontConfigManager::getFontConfigFont`, which under certain > cases, can return null. > > I've tested this PR on both Linux (Ubuntu 22.04.4) and Andr

Re: RFR: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null

2024-08-27 Thread John Hendrikx
On Tue, 27 Aug 2024 15:50:54 GMT, Jose Pereda wrote: > This PR adds a couple of null checks to `LogicalFont` and `FTFactory`, that > make use of `FontConfigManager::getFontConfigFont`, which under certain > cases, can return null. > > I've tested this PR on both Linux (Ubuntu 22.04.4) and Andr

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView [v2]

2024-08-27 Thread Oliver Schmidtmer
> On a Shadow state update with cleared shadow, the new values were not > transmitted to the Java GraphicsDecoder Oliver Schmidtmer has updated the pull request incrementally with one additional commit since the last revision: add test - Changes: - all: https://git.openjdk.org

Re: RFR: 8334124: Rendering issues with CSS "text-shadow" in WebView [v2]

2024-08-27 Thread Oliver Schmidtmer
On Tue, 27 Aug 2024 20:21:43 GMT, Oliver Schmidtmer wrote: >> On a Shadow state update with cleared shadow, the new values were not >> transmitted to the Java GraphicsDecoder > > Oliver Schmidtmer has updated the pull request incrementally with one > additional commit since the last revision: >

Withdrawn: 8334593: Adding, removing and then adding a JFXPanel again leads to NullPointerException

2024-08-27 Thread duke
On Fri, 28 Jun 2024 08:49:49 GMT, Prasanta Sadhukhan wrote: > Adding, then removing, and then adding a JFXPanel to the same component in > the Swing scene graph leads to a NullPointerException in GlassScene because > the sceneState is null. > Removing JFXPanel calls JFXPanel.removeNotify which