Re: RFR: 8330559: Trailing space not rendering correctly in TextFlow in RTL mode [v3]

2024-06-07 Thread Karthik P K
On Thu, 6 Jun 2024 16:53:47 GMT, Andy Goryachev wrote: > The code to reproduce was > > ``` > flow = new TextFlow( > t("Arabic:", Color.RED), > t(" ", Color.YELLOW), > t("العربية", Color.GREEN), > new Text("\n"), >

Re: RFR: 8330559: Trailing space not rendering correctly in TextFlow in RTL mode [v2]

2024-06-07 Thread Karthik P K
On Thu, 6 Jun 2024 23:47:44 GMT, Andy Goryachev wrote: >> I'm having some doubts about the solution still. It is mentioned that this >> problem can occur in text containing both LTR and RTL text together, >> however, as far as I can see, a `TextRun` never contains a mix of text >> directions.

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-06-07 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X concept when >> the window appea

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-06-07 Thread Thiago Milczarek Sayao
On Fri, 17 May 2024 19:10:17 GMT, Glavo wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 94 commits: >> >> - Merge branch 'master' into new_ime >> - Add signals to avoid warnings >> - Merge branc

Re: RFR: 8333147: update maven classifier syntax to recent gradle version

2024-06-07 Thread Kevin Rushforth
On Thu, 6 Jun 2024 17:35:54 GMT, Joeri Sykora wrote: > Replaces the deprecated `classifier` property with `archiveClassifier`. The > property was removed with the release of Gradle 8.0: > https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup Marked as r

Result: New OpenJFX Reviewer: John Hendrikx

2024-06-07 Thread Kevin Rushforth
Voting for John Hendrikx [1] to OpenJFX Reviewer [2] is now closed. Yes: 6 Veto: 0 Abstain: 0 According to the Bylaws definition of Three-Vote Consensus, this is sufficient to approve the nomination. -- Kevin [1] https://openjdk.org/census#jhendrikx [2] https://mail.openjdk.org/pipermail/ope

Integrated: 8333147: update maven classifier syntax to recent gradle version

2024-06-07 Thread Joeri Sykora
On Thu, 6 Jun 2024 17:35:54 GMT, Joeri Sykora wrote: > Replaces the deprecated `classifier` property with `archiveClassifier`. The > property was removed with the release of Gradle 8.0: > https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup This pull r

Re: 8289521: Publication to Apple App Store still not possible with JavaFX web 21

2024-06-07 Thread Michael Hall
Sorry, I did a little more digging on this. My best guess is that Apple is rejecting this because they think you are using a non-public API of their own. The OpenJFX version of MemoryPressureHandlerCocoa.mm matches what appears to be the current WebKit version. [1] Older versions appear somewh

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-06-07 Thread Glavo
On Fri, 17 May 2024 19:10:17 GMT, Glavo wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 94 commits: >> >> - Merge branch 'master' into new_ime >> - Add signals to avoid warnings >> - Merge branc

RFR: 8325445: [macOS] Colors are not displayed in sRGB color space

2024-06-07 Thread Martin Fox
When drawing to the screen JavaFX is producing sRGB colors but on macOS that’s not necessarily what the user is seeing. Since the pixels are not tagged as sRGB the OS is copying them unmodified to the frame buffer to be displayed in the screen’s color space. In general Mac’s don’t default to sRG

Re: RFR: 8325445: [macOS] Colors are not displayed in sRGB color space

2024-06-07 Thread Kevin Rushforth
On Fri, 7 Jun 2024 18:29:00 GMT, Martin Fox wrote: > When drawing to the screen JavaFX is producing sRGB colors but on macOS > that’s not necessarily what the user is seeing. Since the pixels are not > tagged as sRGB the OS is copying them unmodified to the frame buffer to be > displayed in th