Re: RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v5]

On Fri, 7 Apr 2023 22:42:20 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Revert "Make intellij see :systemTests dependecies" >> >>This reverts commit dca7eab24958e1214147

Re: RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v5]

On Sat, 6 May 2023 13:30:55 GMT, Thiago Milczarek Sayao wrote: >> checkstyle.xml line 1: >> >>> 1: >> >> I'm not keen on adding yet another top-level file in our repo. Can it go >> somewhere else? > > @kevinrushforth can you guide me what should I do about this file? Since we already have a

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v4]

On Tue, 2 May 2023 08:57:30 GMT, Ambarish Rapte wrote: >> Add `TEST_ONLY` flag to gradle with default value as false. >> Add new task named `shims`, This task depends on all shim tasks from all >> projects. Hence it will build all shim classes. >> >> If TEST_ONLY is set to true, the all non tes

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v31]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v30]

On Sun, 16 Apr 2023 00:03:47 GMT, Thiago Milczarek Sayao wrote: >> This PR fixes 8273379. >> >> I reverted back to use GDK (from >> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the >> events. >> >> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v31]

On Sat, 6 May 2023 20:24:34 GMT, Thiago Milczarek Sayao wrote: >> This PR fixes 8273379. >> >> I reverted back to use GDK (from >> [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the >> events. >> >> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). >

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v6]

> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. > > Here's whats happening: > > We include all event masks, so when using gtk3 (>= 3.4.0) it includes > `GDK_SMOOTH_SCROLL_MASK` meaning we

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v7]

> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. > > Here's whats happening: > > We include all event masks, so when using gtk3 (>= 3.4.0) it includes > `GDK_SMOOTH_SCROLL_MASK` meaning we

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v4]

On Wed, 1 Mar 2023 16:11:28 GMT, Andy Goryachev wrote: >> Will double check it, but I think I spaced out. > > dx = (dx != 0) ? -dx : 0; > > also, is jdouble a floating point type? if so, would that work correctly if > dx/dy are very small? It's a floating point type. Output is: Delta: -0,00

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v7]

> I replicated the fix on #1054 on Linux. > > Also fixes [Monocle: Stage no longer gets focus after fix for > JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision: - Merg

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v8]

> I replicated the fix on #1054 on Linux. > > Also fixes [Monocle: Stage no longer gets focus after fix for > JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev e

Re: RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v5]

On Thu, 27 Apr 2023 16:55:29 GMT, Jose Pereda wrote: >> @kevinrushforth I was checking and `SceneChangeShouldNotFocusStageTest` >> added on [JDK-8296621](https://bugs.openjdk.org/browse/JDK-8296621) does >> exactly that. >> >> But I noticed the same as you described on >> [JDK-8298500](https:

Re: RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v8]

> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this > scroll event type, deltas are sent to java with the value equal to zero. > > Here's whats happening: > > We include all event masks, so when using gtk3 (>= 3.4.0) it includes > `GDK_SMOOTH_SCROLL_MASK` meaning we

Re: RFR: 8273379: GTK3 stops sending key events during drag and drop [v32]

> This PR fixes 8273379. > > I reverted back to use GDK (from > [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. > > It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383). > > There's also some cleaup. > > To do general testing (two tests were add