> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
> they are rarely modified. These are re-used by caching them in a new class
> `ImmutablePseudoClassSetsCache`.
>
> In order to make this work, `BitSet` had to be cleaned up. It made
> assumptions about the collection
On Tue, 25 Apr 2023 05:40:13 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line
>> 546:
>>
>>> 544: }
>>> 545: if (obj instanceof BitSet bitSet) { // fast path if other
>>> is a BitSet
>>> 546: return equalsBitSet
The expected result was changed due to an enhancement in JDK:
[JDK-8284840](https://bugs.openjdk.org/browse/JDK-8284840): Update CLDR to
Version 42.0
Similar tests were corrected in JDK along with the enhancement: [check this for
example](https://github.com/openjdk/jdk/blob/4900517479f12b59cd8f1
> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
> they are rarely modified. These are re-used by caching them in a new class
> `ImmutablePseudoClassSetsCache`.
>
> In order to make this work, `BitSet` had to be cleaned up. It made
> assumptions about the collection
On Sun, 2 Apr 2023 23:49:55 GMT, Michael Strauß wrote:
>> I'm a bit unsure why that would be an improvement. Passing `null` to a
>> function that doesn't expect it should IMHO never just return `null` but
>> should instead be considered a programming error and result in a stack
>> trace. Pass
> This fix introduces immutable sets of `PseudoClass` almost everywhere, as
> they are rarely modified. These are re-used by caching them in a new class
> `ImmutablePseudoClassSetsCache`.
>
> In order to make this work, `BitSet` had to be cleaned up. It made
> assumptions about the collection
On Sat, 8 Apr 2023 17:37:27 GMT, Michael Strauß wrote:
>>> I could cache the hash code for the sets that are returned here (they are
>>> immutable sets returned by `Set.copyOf` -- I checked their code, and they
>>> don't cache the hash codes). That would however only help if you often pass
>>>
On Mon, 24 Apr 2023 18:05:50 GMT, Andy Goryachev wrote:
> Perhaps i did not emphasized one thing: I believe single pass algorithms
> would not work when all of the following are true:
>
> * min/max constraint(s)
> * grow property(ies) are set
> * fractional scale
> * snapping
>
> But then agai
On Tue, 3 Jan 2023 06:31:37 GMT, Michael Strauß wrote:
>> The children of HBox/VBox don't always pixel-snap to the same value as the
>> container itself when a render scale other than 1 is used. This can lead to
>> a visual glitch where the content bounds don't line up with the container
>> bo
On Fri, 21 Apr 2023 10:34:49 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and
> Mac.
> Sanity testing looks fine.
Builds and tests completed without issues.
-
Marked as reviewed by sykora (Author).
PR Review: https://git.op
Issue: The test fails, in case snapshot is taken before web view finish web
content load
Solution: Introduce a sleep , before taking snapshot of web view , to test
straight line
-
Commit messages:
- Fix straight line test, introduce a sleep before taking snapshot
Changes: https://
On Fri, 21 Apr 2023 10:34:49 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.10.4.Configured and verified on all Windows, Linux and
> Mac.
> Sanity testing looks fine.
This pull request has now been integrated.
Changeset: cf5b8389
Author:Hima Bindu Meda
URL:
https://git.openjdk.
On Tue, 25 Apr 2023 06:41:56 GMT, Jay Bhaskar wrote:
> Issue: [windows] Intermittent test failure in
> test.javafx.scene.web.MiscellaneousTest::testDOMTimer
> Analysis:
> setTimeout call is not a real-time function. it is considered just a minimum
> delay before the callback is executed. The
On Tue, 25 Apr 2023 12:18:17 GMT, Kevin Rushforth wrote:
>> Issue: [windows] Intermittent test failure in
>> test.javafx.scene.web.MiscellaneousTest::testDOMTimer
>> Analysis:
>> setTimeout call is not a real-time function. it is considered just a
>> minimum delay before the callback is execu
On Tue, 25 Apr 2023 07:02:47 GMT, Ambarish Rapte wrote:
> The expected result was changed due to an enhancement in JDK:
> [JDK-8284840](https://bugs.openjdk.org/browse/JDK-8284840): Update CLDR to
> Version 42.0
> Similar tests were corrected in JDK along with the enhancement: [check this
> fo
On Thu, 20 Apr 2023 13:28:23 GMT, Karthik P K wrote:
> Test was failing because `CountDownLatch` was not used to make sure that new
> date is selected and the delay present was not sufficient.
> If the current date is on the left edge of the date picker, this test would
> fail because of the wa
> The expected result was changed due to an enhancement in JDK:
> [JDK-8284840](https://bugs.openjdk.org/browse/JDK-8284840): Update CLDR to
> Version 42.0
> Similar tests were corrected in JDK along with the enhancement: [check this
> for
> example](https://github.com/openjdk/jdk/blob/49005174
On Tue, 25 Apr 2023 12:23:25 GMT, Kevin Rushforth wrote:
>> Ambarish Rapte has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review comment
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConvert
On Fri, 21 Apr 2023 19:16:22 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into scancode
>> - Added manual test for
On Tue, 25 Apr 2023 17:12:35 GMT, Martin Fox wrote:
>> For some reason, Command-+ on Mac did not generate console output in
>> KeyCharComboTest (in the ticket).
>> Using Windows+L (on the attached IBM keyboard) did generate stdout, but not
>> Windows-+.
>>
>> Am I doing something wrong?
>
> @a
On Tue, 25 Apr 2023 07:49:29 GMT, John Hendrikx wrote:
> It's logical width can take on any multiple of the physical pixel size
> divided by the render scale, which is 1 / 1.5 = 0.66.
No it cannot. Snapping imposes limitation on which logical coordinates are
acceptable. What's more, the dist
On Tue, 25 Apr 2023 17:20:38 GMT, Andy Goryachev wrote:
>> @andy-goryachev-oracle This bug is Linux-specific and this PR only fixes
>> Linux. It's still worth testing on Mac and Windows just to verify that
>> they're not affected. Those platforms also have problems with
>> KeyCharacterCombinat
On Tue, 25 Apr 2023 15:36:37 GMT, Ambarish Rapte wrote:
>> The expected result was changed due to an enhancement in JDK:
>> [JDK-8284840](https://bugs.openjdk.org/browse/JDK-8284840): Update CLDR to
>> Version 42.0
>> Similar tests were corrected in JDK along with the enhancement: [check this
On Tue, 25 Apr 2023 18:11:55 GMT, Martin Fox wrote:
>> @beldenfox thank you for doing this work! Should we be
>> reviewing/integrating PRs in a specific sequence?
>
> @andy-goryachev-oracle My highest priorities are #425 (Mac) and the Java code
> in this PR. I'll get it switched over to Window
On Tue, 25 Apr 2023 17:55:20 GMT, Andy Goryachev wrote:
> > It's logical width can take on any multiple of the physical pixel size
> > divided by the render scale, which is 1 / 1.5 = 0.66.
>
> No it cannot. Snapping imposes limitation on which logical coordinates are
> acceptable. What's more,
On Tue, 25 Apr 2023 07:02:47 GMT, Ambarish Rapte wrote:
> The expected result was changed due to an enhancement in JDK:
> [JDK-8284840](https://bugs.openjdk.org/browse/JDK-8284840): Update CLDR to
> Version 42.0
> Similar tests were corrected in JDK along with the enhancement: [check this
> fo
On Tue, 25 Apr 2023 11:42:28 GMT, Jay Bhaskar wrote:
> Issue: The test fails, in case snapshot is taken before web view finish web
> content load
> Solution: Introduce a sleep , before taking snapshot of web view , to test
> straight line
We have seen similar issues with snapshots containing W
Adding the following windows/macos system files to the root .gitignore:
# Ignore macOS files
.DS_Store
.DocumentRevisions-V100 // file backups
.fseventsd/ // contains log of file events
.Spotlight-V100 // usb root
.Trashes/ // usb root
.TemporaryItems/
.VolumeIcon.icns // attached disk icon
.co
> Monkey Tester - a JavaFX application designed to support manual ad-hoc
> testing of individual JavaFX controls.
>
> Feedback and suggestions are always welcome.
>
> 
Andy Gorya
Clean Backport
-
Commit messages:
- Backport cf5b8389cd70d41a22d645added25a9978640e2c
Changes: https://git.openjdk.org/jfx20u/pull/15/files
Webrev: https://webrevs.openjdk.org/?repo=jfx20u&pr=15&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8306115
Stats: 95 lines in 12 f
> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
> example, the following commands create a reproducible build:
>
>
> $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct)
> $ bash gradlew s
On Fri, 7 Apr 2023 06:22:05 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Wed, 26 Apr 2023 04:03:13 GMT, Hima Bindu Meda wrote:
> Clean Backport
This pull request has now been integrated.
Changeset: 2643ebf3
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx20u/commit/2643ebf31c55d5b7fb835316a8025c9139926d68
Stats: 95 lines in 12 files changed
On Fri, 21 Apr 2023 16:29:46 GMT, Andy Goryachev wrote:
> could you please check with the Monkey Tester? I could be doing something
> wrong.
I checked above scenario in Monkey tester and I'm also seeing same issue. But
in a simple test app which I created separately, it looks to be working. I
34 matches
Mail list logo
